• Q
    btrfs: inode: refactor the parameters of insert_reserved_file_extent() · 203f44c5
    Qu Wenruo 提交于
    Function insert_reserved_file_extent() takes a long list of parameters,
    which are all for btrfs_file_extent_item, even including two reserved
    members, encryption and other_encoding.
    
    This makes the parameter list unnecessary long for a function which only
    gets called twice.
    
    This patch will refactor the parameter list, by using
    btrfs_file_extent_item as parameter directly to hugely reduce the number
    of parameters.
    
    Also, since there are only two callers, one in btrfs_finish_ordered_io()
    which inserts file extent for ordered extent, and one
    __btrfs_prealloc_file_range().
    
    These two call sites have completely different context, where ordered
    extent can be compressed, but will always be regular extent, while the
    preallocated one is never going to be compressed and always has PREALLOC
    type.
    
    So use two small wrapper for these two different call sites to improve
    readability.
    Reviewed-by: NJosef Bacik <josef@toxicpanda.com>
    Signed-off-by: NQu Wenruo <wqu@suse.com>
    Reviewed-by: NDavid Sterba <dsterba@suse.com>
    Signed-off-by: NDavid Sterba <dsterba@suse.com>
    203f44c5
ctree.h 117.6 KB