• J
    x86: Clean up mtrr/generic.c · a1a499a3
    Jaswinder Singh Rajput 提交于
    Fix following trivial style problems:
    
      ERROR: trailing whitespace X 4
      WARNING: Use #include <linux/io.h> instead of <asm/io.h>
      WARNING: braces {} are not necessary for single statement blocks X 3
      ERROR: "foo * bar" should be "foo *bar"
      WARNING: line over 80 characters X 6
      ERROR: "foo * bar" should be "foo *bar"
      ERROR: spaces required around that '=' (ctx:VxO)
      ERROR: space required before that '-' (ctx:OxV)
      WARNING: suspect code indent for conditional statements (8, 12)
      ERROR: spaces required around that '=' (ctx:VxV)
      ERROR: do not initialise statics to 0 or NULL
      ERROR: space prohibited after that open parenthesis '(' X 2
      ERROR: space prohibited before that close parenthesis ')' X 2
      ERROR: trailing statements should be on next line
      ERROR: return is not a function, parentheses are not required
    
    Also use pr_debug and pr_warning where possible.
    
    arch/x86/kernel/cpu/mtrr/generic.o:
    
       text	   data	    bss	    dec	    hex	filename
       5652	     77	   4224	   9953	   26e1	generic.o.before
       5652	     77	   4220	   9949	   26dd	generic.o.after
    
    The md5 changed:
       b34d6c045f06daa4ed092b90cc760e8f  generic.o.before.asm
       a490c6251cfd8442fbffecc0e09a573d  generic.o.after.asm
    
    Because mtrr_state moved from data to bss, changing its
    offsets - and also because __LINE__ numbers changed.
    Suggested-by: NAlan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: NJaswinder Singh Rajput <jaswinderrajput@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Yinghai Lu <yinghai@kernel.org>
    LKML-Reference: <20090703164225.GA21447@elte.hu>
    [ Further cleanups to make the code more consistent ]
    Signed-off-by: NIngo Molnar <mingo@elte.hu>
    a1a499a3
generic.c 19.0 KB