builtin-diff.c 26.4 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11
/*
 * builtin-diff.c
 *
 * Builtin diff command: Analyze two perf.data input files, look up and read
 * DSOs and symbol information, sort them and produce a diff.
 */
#include "builtin.h"

#include "util/debug.h"
#include "util/event.h"
#include "util/hist.h"
12
#include "util/evsel.h"
13
#include "util/evlist.h"
14
#include "util/session.h"
15
#include "util/tool.h"
16 17 18
#include "util/sort.h"
#include "util/symbol.h"
#include "util/util.h"
19
#include "util/data.h"
20 21

#include <stdlib.h>
22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42
#include <math.h>

/* Diff command specific HPP columns. */
enum {
	PERF_HPP_DIFF__BASELINE,
	PERF_HPP_DIFF__PERIOD,
	PERF_HPP_DIFF__PERIOD_BASELINE,
	PERF_HPP_DIFF__DELTA,
	PERF_HPP_DIFF__RATIO,
	PERF_HPP_DIFF__WEIGHTED_DIFF,
	PERF_HPP_DIFF__FORMULA,

	PERF_HPP_DIFF__MAX_INDEX
};

struct diff_hpp_fmt {
	struct perf_hpp_fmt	 fmt;
	int			 idx;
	char			*header;
	int			 header_width;
};
43

44 45
struct data__file {
	struct perf_session	*session;
46
	struct perf_data_file	file;
47
	int			 idx;
48
	struct hists		*hists;
49
	struct diff_hpp_fmt	 fmt[PERF_HPP_DIFF__MAX_INDEX];
50 51 52 53 54 55 56 57 58 59 60
};

static struct data__file *data__files;
static int data__files_cnt;

#define data__for_each_file_start(i, d, s)	\
	for (i = s, d = &data__files[s];	\
	     i < data__files_cnt;		\
	     i++, d = &data__files[i])

#define data__for_each_file(i, d) data__for_each_file_start(i, d, 0)
61
#define data__for_each_file_new(i, d) data__for_each_file_start(i, d, 1)
62 63

static bool force;
64
static bool show_period;
65
static bool show_formula;
66
static bool show_baseline_only;
67
static unsigned int sort_compute;
68

69 70 71
static s64 compute_wdiff_w1;
static s64 compute_wdiff_w2;

72 73 74
enum {
	COMPUTE_DELTA,
	COMPUTE_RATIO,
75
	COMPUTE_WEIGHTED_DIFF,
76 77 78 79 80 81
	COMPUTE_MAX,
};

const char *compute_names[COMPUTE_MAX] = {
	[COMPUTE_DELTA] = "delta",
	[COMPUTE_RATIO] = "ratio",
82
	[COMPUTE_WEIGHTED_DIFF] = "wdiff",
83 84 85 86
};

static int compute;

87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
static int compute_2_hpp[COMPUTE_MAX] = {
	[COMPUTE_DELTA]		= PERF_HPP_DIFF__DELTA,
	[COMPUTE_RATIO]		= PERF_HPP_DIFF__RATIO,
	[COMPUTE_WEIGHTED_DIFF]	= PERF_HPP_DIFF__WEIGHTED_DIFF,
};

#define MAX_COL_WIDTH 70

static struct header_column {
	const char *name;
	int width;
} columns[PERF_HPP_DIFF__MAX_INDEX] = {
	[PERF_HPP_DIFF__BASELINE] = {
		.name  = "Baseline",
	},
	[PERF_HPP_DIFF__PERIOD] = {
		.name  = "Period",
		.width = 14,
	},
	[PERF_HPP_DIFF__PERIOD_BASELINE] = {
		.name  = "Base period",
		.width = 14,
	},
	[PERF_HPP_DIFF__DELTA] = {
		.name  = "Delta",
		.width = 7,
	},
	[PERF_HPP_DIFF__RATIO] = {
		.name  = "Ratio",
		.width = 14,
	},
	[PERF_HPP_DIFF__WEIGHTED_DIFF] = {
		.name  = "Weighted diff",
		.width = 14,
	},
	[PERF_HPP_DIFF__FORMULA] = {
		.name  = "Formula",
		.width = MAX_COL_WIDTH,
	}
};

128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
static int setup_compute_opt_wdiff(char *opt)
{
	char *w1_str = opt;
	char *w2_str;

	int ret = -EINVAL;

	if (!opt)
		goto out;

	w2_str = strchr(opt, ',');
	if (!w2_str)
		goto out;

	*w2_str++ = 0x0;
	if (!*w2_str)
		goto out;

	compute_wdiff_w1 = strtol(w1_str, NULL, 10);
	compute_wdiff_w2 = strtol(w2_str, NULL, 10);

	if (!compute_wdiff_w1 || !compute_wdiff_w2)
		goto out;

	pr_debug("compute wdiff w1(%" PRId64 ") w2(%" PRId64 ")\n",
		  compute_wdiff_w1, compute_wdiff_w2);

	ret = 0;

 out:
	if (ret)
		pr_err("Failed: wrong weight data, use 'wdiff:w1,w2'\n");

	return ret;
}

static int setup_compute_opt(char *opt)
{
	if (compute == COMPUTE_WEIGHTED_DIFF)
		return setup_compute_opt_wdiff(opt);

	if (opt) {
		pr_err("Failed: extra option specified '%s'", opt);
		return -EINVAL;
	}

	return 0;
}

177 178 179 180
static int setup_compute(const struct option *opt, const char *str,
			 int unset __maybe_unused)
{
	int *cp = (int *) opt->value;
181 182
	char *cstr = (char *) str;
	char buf[50];
183
	unsigned i;
184
	char *option;
185 186 187 188 189 190

	if (!str) {
		*cp = COMPUTE_DELTA;
		return 0;
	}

191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
	option = strchr(str, ':');
	if (option) {
		unsigned len = option++ - str;

		/*
		 * The str data are not writeable, so we need
		 * to use another buffer.
		 */

		/* No option value is longer. */
		if (len >= sizeof(buf))
			return -EINVAL;

		strncpy(buf, str, len);
		buf[len] = 0x0;
		cstr = buf;
	}

209
	for (i = 0; i < COMPUTE_MAX; i++)
210
		if (!strcmp(cstr, compute_names[i])) {
211
			*cp = i;
212
			return setup_compute_opt(option);
213 214 215
		}

	pr_err("Failed: '%s' is not computation method "
216
	       "(use 'delta','ratio' or 'wdiff')\n", str);
217 218 219
	return -EINVAL;
}

220
static double period_percent(struct hist_entry *he, u64 period)
221
{
222 223
	u64 total = hists__total_period(he->hists);

224 225 226
	return (period * 100.0) / total;
}

227
static double compute_delta(struct hist_entry *he, struct hist_entry *pair)
228
{
229 230
	double old_percent = period_percent(he, he->stat.period);
	double new_percent = period_percent(pair, pair->stat.period);
231

232 233 234
	pair->diff.period_ratio_delta = new_percent - old_percent;
	pair->diff.computed = true;
	return pair->diff.period_ratio_delta;
235 236
}

237
static double compute_ratio(struct hist_entry *he, struct hist_entry *pair)
238
{
239 240
	double old_period = he->stat.period ?: 1;
	double new_period = pair->stat.period;
241

242 243 244
	pair->diff.computed = true;
	pair->diff.period_ratio = new_period / old_period;
	return pair->diff.period_ratio;
245 246
}

247
static s64 compute_wdiff(struct hist_entry *he, struct hist_entry *pair)
248
{
249 250
	u64 old_period = he->stat.period;
	u64 new_period = pair->stat.period;
251

252 253 254
	pair->diff.computed = true;
	pair->diff.wdiff = new_period * compute_wdiff_w2 -
			   old_period * compute_wdiff_w1;
255

256
	return pair->diff.wdiff;
257 258
}

259 260
static int formula_delta(struct hist_entry *he, struct hist_entry *pair,
			 char *buf, size_t size)
261
{
262 263 264 265 266 267 268
	u64 he_total = he->hists->stats.total_period;
	u64 pair_total = pair->hists->stats.total_period;

	if (symbol_conf.filter_relative) {
		he_total = he->hists->stats.total_non_filtered_period;
		pair_total = pair->hists->stats.total_non_filtered_period;
	}
269 270 271
	return scnprintf(buf, size,
			 "(%" PRIu64 " * 100 / %" PRIu64 ") - "
			 "(%" PRIu64 " * 100 / %" PRIu64 ")",
272 273
			 pair->stat.period, pair_total,
			 he->stat.period, he_total);
274 275
}

276 277
static int formula_ratio(struct hist_entry *he, struct hist_entry *pair,
			 char *buf, size_t size)
278
{
279 280
	double old_period = he->stat.period;
	double new_period = pair->stat.period;
281 282 283 284

	return scnprintf(buf, size, "%.0F / %.0F", new_period, old_period);
}

285 286
static int formula_wdiff(struct hist_entry *he, struct hist_entry *pair,
			 char *buf, size_t size)
287
{
288 289
	u64 old_period = he->stat.period;
	u64 new_period = pair->stat.period;
290 291 292 293 294 295

	return scnprintf(buf, size,
		  "(%" PRIu64 " * " "%" PRId64 ") - (%" PRIu64 " * " "%" PRId64 ")",
		  new_period, compute_wdiff_w2, old_period, compute_wdiff_w1);
}

296 297
static int formula_fprintf(struct hist_entry *he, struct hist_entry *pair,
			   char *buf, size_t size)
298 299 300
{
	switch (compute) {
	case COMPUTE_DELTA:
301
		return formula_delta(he, pair, buf, size);
302
	case COMPUTE_RATIO:
303
		return formula_ratio(he, pair, buf, size);
304
	case COMPUTE_WEIGHTED_DIFF:
305
		return formula_wdiff(he, pair, buf, size);
306 307 308 309 310 311 312
	default:
		BUG_ON(1);
	}

	return -1;
}

313
static int hists__add_entry(struct hists *hists,
314
			    struct addr_location *al, u64 period,
315
			    u64 weight, u64 transaction)
316
{
317
	if (__hists__add_entry(hists, al, NULL, NULL, NULL, period, weight,
318
			       transaction, true) != NULL)
319 320
		return 0;
	return -ENOMEM;
321 322
}

323
static int diff__process_sample_event(struct perf_tool *tool __maybe_unused,
324
				      union perf_event *event,
325
				      struct perf_sample *sample,
326
				      struct perf_evsel *evsel,
327
				      struct machine *machine)
328 329
{
	struct addr_location al;
330
	struct hists *hists = evsel__hists(evsel);
331

332
	if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) {
333 334 335 336 337
		pr_warning("problem processing %d event, skipping it.\n",
			   event->header.type);
		return -1;
	}

338
	if (hists__add_entry(hists, &al, sample->period,
339
			     sample->weight, sample->transaction)) {
340
		pr_warning("problem incrementing symbol period, skipping event\n");
341 342 343
		return -1;
	}

344 345 346 347 348 349
	/*
	 * The total_period is updated here before going to the output
	 * tree since normally only the baseline hists will call
	 * hists__output_resort() and precompute needs the total
	 * period in order to sort entries by percentage delta.
	 */
350
	hists->stats.total_period += sample->period;
351
	if (!al.filtered)
352
		hists->stats.total_non_filtered_period += sample->period;
353

354 355 356
	return 0;
}

357 358 359
static struct perf_tool tool = {
	.sample	= diff__process_sample_event,
	.mmap	= perf_event__process_mmap,
360
	.mmap2	= perf_event__process_mmap2,
361
	.comm	= perf_event__process_comm,
362 363
	.exit	= perf_event__process_exit,
	.fork	= perf_event__process_fork,
364
	.lost	= perf_event__process_lost,
365
	.ordered_events = true,
366
	.ordering_requires_timestamps = true,
367 368
};

369 370 371 372 373
static struct perf_evsel *evsel_match(struct perf_evsel *evsel,
				      struct perf_evlist *evlist)
{
	struct perf_evsel *e;

374
	evlist__for_each(evlist, e) {
375 376
		if (perf_evsel__match2(evsel, e))
			return e;
377
	}
378 379 380 381

	return NULL;
}

382
static void perf_evlist__collapse_resort(struct perf_evlist *evlist)
383 384 385
{
	struct perf_evsel *evsel;

386
	evlist__for_each(evlist, evsel) {
387
		struct hists *hists = evsel__hists(evsel);
388

389
		hists__collapse_resort(hists, NULL);
390 391 392
	}
}

393 394 395 396 397 398 399 400 401
static struct data__file *fmt_to_data_file(struct perf_hpp_fmt *fmt)
{
	struct diff_hpp_fmt *dfmt = container_of(fmt, struct diff_hpp_fmt, fmt);
	void *ptr = dfmt - dfmt->idx;
	struct data__file *d = container_of(ptr, struct data__file, fmt);

	return d;
}

402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418
static struct hist_entry*
get_pair_data(struct hist_entry *he, struct data__file *d)
{
	if (hist_entry__has_pairs(he)) {
		struct hist_entry *pair;

		list_for_each_entry(pair, &he->pairs.head, pairs.node)
			if (pair->hists == d->hists)
				return pair;
	}

	return NULL;
}

static struct hist_entry*
get_pair_fmt(struct hist_entry *he, struct diff_hpp_fmt *dfmt)
{
419
	struct data__file *d = fmt_to_data_file(&dfmt->fmt);
420 421 422 423

	return get_pair_data(he, d);
}

424 425
static void hists__baseline_only(struct hists *hists)
{
426 427 428 429 430 431 432
	struct rb_root *root;
	struct rb_node *next;

	if (sort__need_collapse)
		root = &hists->entries_collapsed;
	else
		root = hists->entries_in;
433

434
	next = rb_first(root);
435
	while (next != NULL) {
436
		struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node_in);
437

438
		next = rb_next(&he->rb_node_in);
439
		if (!hist_entry__next_pair(he)) {
440
			rb_erase(&he->rb_node_in, root);
441
			hist_entry__delete(he);
442 443 444 445
		}
	}
}

446 447
static void hists__precompute(struct hists *hists)
{
448 449 450 451 452 453 454
	struct rb_root *root;
	struct rb_node *next;

	if (sort__need_collapse)
		root = &hists->entries_collapsed;
	else
		root = hists->entries_in;
455

456
	next = rb_first(root);
457
	while (next != NULL) {
458
		struct hist_entry *he, *pair;
459

460
		he   = rb_entry(next, struct hist_entry, rb_node_in);
461
		next = rb_next(&he->rb_node_in);
462 463

		pair = get_pair_data(he, &data__files[sort_compute]);
464 465
		if (!pair)
			continue;
466 467 468

		switch (compute) {
		case COMPUTE_DELTA:
469
			compute_delta(he, pair);
470 471
			break;
		case COMPUTE_RATIO:
472
			compute_ratio(he, pair);
473
			break;
474
		case COMPUTE_WEIGHTED_DIFF:
475
			compute_wdiff(he, pair);
476
			break;
477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
		default:
			BUG_ON(1);
		}
	}
}

static int64_t cmp_doubles(double l, double r)
{
	if (l > r)
		return -1;
	else if (l < r)
		return 1;
	else
		return 0;
}

static int64_t
494
__hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511
			int c)
{
	switch (c) {
	case COMPUTE_DELTA:
	{
		double l = left->diff.period_ratio_delta;
		double r = right->diff.period_ratio_delta;

		return cmp_doubles(l, r);
	}
	case COMPUTE_RATIO:
	{
		double l = left->diff.period_ratio;
		double r = right->diff.period_ratio;

		return cmp_doubles(l, r);
	}
512 513 514 515 516 517 518
	case COMPUTE_WEIGHTED_DIFF:
	{
		s64 l = left->diff.wdiff;
		s64 r = right->diff.wdiff;

		return r - l;
	}
519 520 521 522 523 524 525
	default:
		BUG_ON(1);
	}

	return 0;
}

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555
static int64_t
hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
			int c)
{
	bool pairs_left  = hist_entry__has_pairs(left);
	bool pairs_right = hist_entry__has_pairs(right);
	struct hist_entry *p_right, *p_left;

	if (!pairs_left && !pairs_right)
		return 0;

	if (!pairs_left || !pairs_right)
		return pairs_left ? -1 : 1;

	p_left  = get_pair_data(left,  &data__files[sort_compute]);
	p_right = get_pair_data(right, &data__files[sort_compute]);

	if (!p_left && !p_right)
		return 0;

	if (!p_left || !p_right)
		return p_left ? -1 : 1;

	/*
	 * We have 2 entries of same kind, let's
	 * make the data comparison.
	 */
	return __hist_entry__cmp_compute(p_left, p_right, c);
}

556
static int64_t
557 558
hist_entry__cmp_nop(struct perf_hpp_fmt *fmt __maybe_unused,
		    struct hist_entry *left __maybe_unused,
559 560 561 562 563 564
		    struct hist_entry *right __maybe_unused)
{
	return 0;
}

static int64_t
565 566
hist_entry__cmp_baseline(struct perf_hpp_fmt *fmt __maybe_unused,
			 struct hist_entry *left, struct hist_entry *right)
567 568 569 570 571 572 573 574 575 576
{
	if (sort_compute)
		return 0;

	if (left->stat.period == right->stat.period)
		return 0;
	return left->stat.period > right->stat.period ? 1 : -1;
}

static int64_t
577 578
hist_entry__cmp_delta(struct perf_hpp_fmt *fmt __maybe_unused,
		      struct hist_entry *left, struct hist_entry *right)
579 580 581 582 583
{
	return hist_entry__cmp_compute(right, left, COMPUTE_DELTA);
}

static int64_t
584 585
hist_entry__cmp_ratio(struct perf_hpp_fmt *fmt __maybe_unused,
		      struct hist_entry *left, struct hist_entry *right)
586 587 588 589 590
{
	return hist_entry__cmp_compute(right, left, COMPUTE_RATIO);
}

static int64_t
591 592
hist_entry__cmp_wdiff(struct perf_hpp_fmt *fmt __maybe_unused,
		      struct hist_entry *left, struct hist_entry *right)
593 594 595 596
{
	return hist_entry__cmp_compute(right, left, COMPUTE_WEIGHTED_DIFF);
}

597
static void hists__process(struct hists *hists)
598 599
{
	if (show_baseline_only)
600
		hists__baseline_only(hists);
601

602
	if (sort_compute)
603
		hists__precompute(hists);
604 605

	hists__output_resort(hists, NULL);
606

607
	hists__fprintf(hists, true, 0, 0, 0, stdout);
608 609
}

610 611 612 613 614 615 616 617 618
static void data__fprintf(void)
{
	struct data__file *d;
	int i;

	fprintf(stdout, "# Data files:\n");

	data__for_each_file(i, d)
		fprintf(stdout, "#  [%d] %s %s\n",
619
			d->idx, d->file.path,
620 621 622 623 624
			!d->idx ? "(Baseline)" : "");

	fprintf(stdout, "#\n");
}

625
static void data_process(void)
626
{
627 628
	struct perf_evlist *evlist_base = data__files[0].session->evlist;
	struct perf_evsel *evsel_base;
629
	bool first = true;
630

631
	evlist__for_each(evlist_base, evsel_base) {
632
		struct hists *hists_base = evsel__hists(evsel_base);
633 634
		struct data__file *d;
		int i;
635

636 637 638
		data__for_each_file_new(i, d) {
			struct perf_evlist *evlist = d->session->evlist;
			struct perf_evsel *evsel;
639
			struct hists *hists;
640 641 642 643 644

			evsel = evsel_match(evsel_base, evlist);
			if (!evsel)
				continue;

645 646
			hists = evsel__hists(evsel);
			d->hists = hists;
647

648
			hists__match(hists_base, hists);
649 650

			if (!show_baseline_only)
651
				hists__link(hists_base, hists);
652
		}
653

654
		fprintf(stdout, "%s# Event '%s'\n#\n", first ? "" : "\n",
655
			perf_evsel__name(evsel_base));
656

657
		first = false;
658

659
		if (verbose || data__files_cnt > 2)
660 661
			data__fprintf();

662
		hists__process(hists_base);
663 664
	}
}
665

666 667 668 669 670 671 672
static void data__free(struct data__file *d)
{
	int col;

	for (col = 0; col < PERF_HPP_DIFF__MAX_INDEX; col++) {
		struct diff_hpp_fmt *fmt = &d->fmt[col];

673
		zfree(&fmt->header);
674 675 676
	}
}

677 678 679 680 681 682
static int __cmd_diff(void)
{
	struct data__file *d;
	int ret = -EINVAL, i;

	data__for_each_file(i, d) {
683
		d->session = perf_session__new(&d->file, false, &tool);
684
		if (!d->session) {
685
			pr_err("Failed to open %s\n", d->file.path);
686
			ret = -1;
687 688
			goto out_delete;
		}
689

690 691
		ret = perf_session__process_events(d->session, &tool);
		if (ret) {
692
			pr_err("Failed to process %s\n", d->file.path);
693 694
			goto out_delete;
		}
695

696 697 698 699
		perf_evlist__collapse_resort(d->session->evlist);
	}

	data_process();
700

701 702 703 704
 out_delete:
	data__for_each_file(i, d) {
		if (d->session)
			perf_session__delete(d->session);
705 706

		data__free(d);
707
	}
708

709
	free(data__files);
710 711 712
	return ret;
}

713
static const char * const diff_usage[] = {
714
	"perf diff [<options>] [old_file] [new_file]",
715
	NULL,
716 717 718
};

static const struct option options[] = {
719
	OPT_INCR('v', "verbose", &verbose,
720
		    "be more verbose (show symbol address, etc)"),
721 722
	OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
		    "Show only items with match in baseline"),
723 724
	OPT_CALLBACK('c', "compute", &compute,
		     "delta,ratio,wdiff:w1,w2 (default delta)",
725 726
		     "Entries differential computation selection",
		     setup_compute),
727 728
	OPT_BOOLEAN('p', "period", &show_period,
		    "Show period values."),
729 730
	OPT_BOOLEAN('F', "formula", &show_formula,
		    "Show formula."),
731 732 733 734 735
	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
		    "dump raw trace in ASCII"),
	OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
	OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
		    "load module symbols - WARNING: use only with -k and LIVE kernel"),
736 737 738 739 740 741
	OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
		   "only consider symbols in these dsos"),
	OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
		   "only consider symbols in these comms"),
	OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
		   "only consider these symbols"),
742
	OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
743 744
		   "sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ..."
		   " Please refer the man page for the complete list."),
745 746 747
	OPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator",
		   "separator for columns, no spaces will be added between "
		   "columns '.' is reserved."),
748 749
	OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
		    "Look for files with symbols relative to this directory"),
750
	OPT_UINTEGER('o', "order", &sort_compute, "Specify compute sorting."),
751 752
	OPT_CALLBACK(0, "percentage", NULL, "relative|absolute",
		     "How to display percentage of filtered entries", parse_filter_percentage),
753 754 755
	OPT_END()
};

756
static double baseline_percent(struct hist_entry *he)
757
{
758 759 760
	u64 total = hists__total_period(he->hists);

	return 100.0 * he->stat.period / total;
761
}
762

763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791
static int hpp__color_baseline(struct perf_hpp_fmt *fmt,
			       struct perf_hpp *hpp, struct hist_entry *he)
{
	struct diff_hpp_fmt *dfmt =
		container_of(fmt, struct diff_hpp_fmt, fmt);
	double percent = baseline_percent(he);
	char pfmt[20] = " ";

	if (!he->dummy) {
		scnprintf(pfmt, 20, "%%%d.2f%%%%", dfmt->header_width - 1);
		return percent_color_snprintf(hpp->buf, hpp->size,
					      pfmt, percent);
	} else
		return scnprintf(hpp->buf, hpp->size, "%*s",
				 dfmt->header_width, pfmt);
}

static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size)
{
	double percent = baseline_percent(he);
	const char *fmt = symbol_conf.field_sep ? "%.2f" : "%6.2f%%";
	int ret = 0;

	if (!he->dummy)
		ret = scnprintf(buf, size, fmt, percent);

	return ret;
}

792 793 794 795 796 797 798 799
static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
				struct perf_hpp *hpp, struct hist_entry *he,
				int comparison_method)
{
	struct diff_hpp_fmt *dfmt =
		container_of(fmt, struct diff_hpp_fmt, fmt);
	struct hist_entry *pair = get_pair_fmt(he, dfmt);
	double diff;
800
	s64 wdiff;
801 802 803
	char pfmt[20] = " ";

	if (!pair)
804
		goto no_print;
805 806 807 808 809 810 811 812 813 814 815

	switch (comparison_method) {
	case COMPUTE_DELTA:
		if (pair->diff.computed)
			diff = pair->diff.period_ratio_delta;
		else
			diff = compute_delta(he, pair);

		scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
		return percent_color_snprintf(hpp->buf, hpp->size,
					pfmt, diff);
816 817 818 819 820 821 822 823 824 825 826
	case COMPUTE_RATIO:
		if (he->dummy)
			goto dummy_print;
		if (pair->diff.computed)
			diff = pair->diff.period_ratio;
		else
			diff = compute_ratio(he, pair);

		scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
		return value_color_snprintf(hpp->buf, hpp->size,
					pfmt, diff);
827 828 829 830 831 832 833 834 835 836 837 838
	case COMPUTE_WEIGHTED_DIFF:
		if (he->dummy)
			goto dummy_print;
		if (pair->diff.computed)
			wdiff = pair->diff.wdiff;
		else
			wdiff = compute_wdiff(he, pair);

		scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
		return color_snprintf(hpp->buf, hpp->size,
				get_percent_color(wdiff),
				pfmt, wdiff);
839 840 841 842
	default:
		BUG_ON(1);
	}
dummy_print:
843 844 845
	return scnprintf(hpp->buf, hpp->size, "%*s",
			dfmt->header_width, "N/A");
no_print:
846 847 848 849 850 851 852 853 854 855
	return scnprintf(hpp->buf, hpp->size, "%*s",
			dfmt->header_width, pfmt);
}

static int hpp__color_delta(struct perf_hpp_fmt *fmt,
			struct perf_hpp *hpp, struct hist_entry *he)
{
	return __hpp__color_compare(fmt, hpp, he, COMPUTE_DELTA);
}

856 857 858 859 860 861
static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
			struct perf_hpp *hpp, struct hist_entry *he)
{
	return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
}

862 863 864 865 866 867
static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
			struct perf_hpp *hpp, struct hist_entry *he)
{
	return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
}

868 869 870 871 872 873
static void
hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
{
	switch (idx) {
	case PERF_HPP_DIFF__PERIOD_BASELINE:
		scnprintf(buf, size, "%" PRIu64, he->stat.period);
874
		break;
875 876

	default:
877
		break;
878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893
	}
}

static void
hpp__entry_pair(struct hist_entry *he, struct hist_entry *pair,
		int idx, char *buf, size_t size)
{
	double diff;
	double ratio;
	s64 wdiff;

	switch (idx) {
	case PERF_HPP_DIFF__DELTA:
		if (pair->diff.computed)
			diff = pair->diff.period_ratio_delta;
		else
894
			diff = compute_delta(he, pair);
895

896
		scnprintf(buf, size, "%+4.2F%%", diff);
897 898 899 900
		break;

	case PERF_HPP_DIFF__RATIO:
		/* No point for ratio number if we are dummy.. */
901 902
		if (he->dummy) {
			scnprintf(buf, size, "N/A");
903
			break;
904
		}
905 906 907 908

		if (pair->diff.computed)
			ratio = pair->diff.period_ratio;
		else
909
			ratio = compute_ratio(he, pair);
910 911 912 913 914 915 916

		if (ratio > 0.0)
			scnprintf(buf, size, "%14.6F", ratio);
		break;

	case PERF_HPP_DIFF__WEIGHTED_DIFF:
		/* No point for wdiff number if we are dummy.. */
917 918
		if (he->dummy) {
			scnprintf(buf, size, "N/A");
919
			break;
920
		}
921 922 923 924

		if (pair->diff.computed)
			wdiff = pair->diff.wdiff;
		else
925
			wdiff = compute_wdiff(he, pair);
926 927 928 929 930 931

		if (wdiff != 0)
			scnprintf(buf, size, "%14ld", wdiff);
		break;

	case PERF_HPP_DIFF__FORMULA:
932
		formula_fprintf(he, pair, buf, size);
933
		break;
934 935 936 937 938

	case PERF_HPP_DIFF__PERIOD:
		scnprintf(buf, size, "%" PRIu64, pair->stat.period);
		break;

939 940 941
	default:
		BUG_ON(1);
	};
942 943 944
}

static void
945 946
__hpp__entry_global(struct hist_entry *he, struct diff_hpp_fmt *dfmt,
		    char *buf, size_t size)
947
{
948
	struct hist_entry *pair = get_pair_fmt(he, dfmt);
949
	int idx = dfmt->idx;
950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968

	/* baseline is special */
	if (idx == PERF_HPP_DIFF__BASELINE)
		hpp__entry_baseline(he, buf, size);
	else {
		if (pair)
			hpp__entry_pair(he, pair, idx, buf, size);
		else
			hpp__entry_unpair(he, idx, buf, size);
	}
}

static int hpp__entry_global(struct perf_hpp_fmt *_fmt, struct perf_hpp *hpp,
			     struct hist_entry *he)
{
	struct diff_hpp_fmt *dfmt =
		container_of(_fmt, struct diff_hpp_fmt, fmt);
	char buf[MAX_COL_WIDTH] = " ";

969
	__hpp__entry_global(he, dfmt, buf, MAX_COL_WIDTH);
970 971 972 973 974 975 976 977

	if (symbol_conf.field_sep)
		return scnprintf(hpp->buf, hpp->size, "%s", buf);
	else
		return scnprintf(hpp->buf, hpp->size, "%*s",
				 dfmt->header_width, buf);
}

978 979
static int hpp__header(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
		       struct perf_evsel *evsel __maybe_unused)
980 981 982 983 984 985 986 987 988
{
	struct diff_hpp_fmt *dfmt =
		container_of(fmt, struct diff_hpp_fmt, fmt);

	BUG_ON(!dfmt->header);
	return scnprintf(hpp->buf, hpp->size, dfmt->header);
}

static int hpp__width(struct perf_hpp_fmt *fmt,
989 990
		      struct perf_hpp *hpp __maybe_unused,
		      struct perf_evsel *evsel __maybe_unused)
991 992 993 994 995 996 997 998
{
	struct diff_hpp_fmt *dfmt =
		container_of(fmt, struct diff_hpp_fmt, fmt);

	BUG_ON(dfmt->header_width <= 0);
	return dfmt->header_width;
}

999
static void init_header(struct data__file *d, struct diff_hpp_fmt *dfmt)
1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
{
#define MAX_HEADER_NAME 100
	char buf_indent[MAX_HEADER_NAME];
	char buf[MAX_HEADER_NAME];
	const char *header = NULL;
	int width = 0;

	BUG_ON(dfmt->idx >= PERF_HPP_DIFF__MAX_INDEX);
	header = columns[dfmt->idx].name;
	width  = columns[dfmt->idx].width;

	/* Only our defined HPP fmts should appear here. */
	BUG_ON(!header);

1014 1015 1016
	if (data__files_cnt > 2)
		scnprintf(buf, MAX_HEADER_NAME, "%s/%d", header, d->idx);

1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030
#define NAME (data__files_cnt > 2 ? buf : header)
	dfmt->header_width = width;
	width = (int) strlen(NAME);
	if (dfmt->header_width < width)
		dfmt->header_width = width;

	scnprintf(buf_indent, MAX_HEADER_NAME, "%*s",
		  dfmt->header_width, NAME);

	dfmt->header = strdup(buf_indent);
#undef MAX_HEADER_NAME
#undef NAME
}

1031
static void data__hpp_register(struct data__file *d, int idx)
1032
{
1033 1034 1035 1036 1037 1038 1039 1040
	struct diff_hpp_fmt *dfmt = &d->fmt[idx];
	struct perf_hpp_fmt *fmt = &dfmt->fmt;

	dfmt->idx = idx;

	fmt->header = hpp__header;
	fmt->width  = hpp__width;
	fmt->entry  = hpp__entry_global;
1041 1042
	fmt->cmp    = hist_entry__cmp_nop;
	fmt->collapse = hist_entry__cmp_nop;
1043 1044

	/* TODO more colors */
1045 1046
	switch (idx) {
	case PERF_HPP_DIFF__BASELINE:
1047
		fmt->color = hpp__color_baseline;
1048
		fmt->sort  = hist_entry__cmp_baseline;
1049 1050 1051
		break;
	case PERF_HPP_DIFF__DELTA:
		fmt->color = hpp__color_delta;
1052
		fmt->sort  = hist_entry__cmp_delta;
1053
		break;
1054 1055
	case PERF_HPP_DIFF__RATIO:
		fmt->color = hpp__color_ratio;
1056
		fmt->sort  = hist_entry__cmp_ratio;
1057
		break;
1058 1059
	case PERF_HPP_DIFF__WEIGHTED_DIFF:
		fmt->color = hpp__color_wdiff;
1060
		fmt->sort  = hist_entry__cmp_wdiff;
1061
		break;
1062
	default:
1063
		fmt->sort  = hist_entry__cmp_nop;
1064 1065
		break;
	}
1066

1067
	init_header(d, dfmt);
1068
	perf_hpp__column_register(fmt);
1069
	perf_hpp__register_sort_field(fmt);
1070 1071 1072 1073
}

static void ui_init(void)
{
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088
	struct data__file *d;
	int i;

	data__for_each_file(i, d) {

		/*
		 * Baseline or compute realted columns:
		 *
		 *   PERF_HPP_DIFF__BASELINE
		 *   PERF_HPP_DIFF__DELTA
		 *   PERF_HPP_DIFF__RATIO
		 *   PERF_HPP_DIFF__WEIGHTED_DIFF
		 */
		data__hpp_register(d, i ? compute_2_hpp[compute] :
					  PERF_HPP_DIFF__BASELINE);
1089

1090 1091 1092 1093 1094 1095 1096 1097 1098
		/*
		 * And the rest:
		 *
		 * PERF_HPP_DIFF__FORMULA
		 * PERF_HPP_DIFF__PERIOD
		 * PERF_HPP_DIFF__PERIOD_BASELINE
		 */
		if (show_formula && i)
			data__hpp_register(d, PERF_HPP_DIFF__FORMULA);
1099

1100 1101 1102
		if (show_period)
			data__hpp_register(d, i ? PERF_HPP_DIFF__PERIOD :
						  PERF_HPP_DIFF__PERIOD_BASELINE);
1103
	}
1104 1105
}

1106
static int data_init(int argc, const char **argv)
1107
{
1108 1109 1110 1111 1112
	struct data__file *d;
	static const char *defaults[] = {
		"perf.data.old",
		"perf.data",
	};
1113
	bool use_default = true;
1114 1115 1116 1117
	int i;

	data__files_cnt = 2;

1118
	if (argc) {
1119
		if (argc == 1)
1120
			defaults[1] = argv[0];
1121 1122 1123 1124
		else {
			data__files_cnt = argc;
			use_default = false;
		}
1125
	} else if (perf_guest) {
1126 1127
		defaults[0] = "perf.data.host";
		defaults[1] = "perf.data.guest";
1128 1129
	}

1130 1131 1132 1133 1134
	if (sort_compute >= (unsigned int) data__files_cnt) {
		pr_err("Order option out of limit.\n");
		return -EINVAL;
	}

1135 1136 1137 1138 1139
	data__files = zalloc(sizeof(*data__files) * data__files_cnt);
	if (!data__files)
		return -ENOMEM;

	data__for_each_file(i, d) {
1140 1141 1142 1143 1144 1145
		struct perf_data_file *file = &d->file;

		file->path  = use_default ? defaults[i] : argv[i];
		file->mode  = PERF_DATA_MODE_READ,
		file->force = force,

1146 1147 1148 1149 1150 1151 1152 1153
		d->idx  = i;
	}

	return 0;
}

int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
{
1154 1155 1156 1157 1158
	int ret = hists__init();

	if (ret < 0)
		return ret;

1159 1160
	perf_config(perf_default_config, NULL);

1161 1162
	argc = parse_options(argc, argv, options, diff_usage, 0);

1163
	if (symbol__init(NULL) < 0)
1164 1165
		return -1;

1166 1167 1168
	if (data_init(argc, argv) < 0)
		return -1;

1169 1170
	ui_init();

1171 1172
	sort__mode = SORT_MODE__DIFF;

1173 1174 1175
	if (setup_sorting() < 0)
		usage_with_options(diff_usage, options);

1176
	setup_pager();
1177

1178
	sort__setup_elide(NULL);
1179

1180 1181
	return __cmd_diff();
}