1. 16 6月, 2014 4 次提交
    • A
      CLIENT KILL: fix closing link of the current client. · e06b3819
      antirez 提交于
      e06b3819
    • A
      New features for CLIENT KILL. · e7affd26
      antirez 提交于
      e7affd26
    • A
      Assign an unique non-repeating ID to each new client. · f26f79ea
      antirez 提交于
      This will be used by CLIENT KILL and is also a good way to ensure a
      given client is still the same across CLIENT LIST calls.
      
      The output of CLIENT LIST was modified to include the new ID, but this
      change is considered to be backward compatible as the API does not imply
      you can do positional parsing, since each filed as a different name.
      f26f79ea
    • A
      Client types generalized. · 56d26c23
      antirez 提交于
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      56d26c23
  2. 12 6月, 2014 2 次提交
    • A
      Scripting: regression test for issue #1811. · aa19fd61
      antirez 提交于
      aa19fd61
    • A
      Fix semantics of Lua calls to SELECT. · 96e0fe62
      antirez 提交于
      Lua scripts are executed in the context of the currently selected
      database (as selected by the caller of the script).
      
      However Lua scripts are also free to use the SELECT command in order to
      affect other DBs. When SELECT is called frm Lua, the old behavior, before
      this commit, was to automatically set the Lua caller selected DB to the
      last DB selected by Lua. See for example the following sequence of
      commands:
      
          SELECT 0
          SET x 10
          EVAL "redis.call('select','1')" 0
          SET x 20
      
      Before this commit after the execution of this sequence of commands,
      we'll have x=10 in DB 0, and x=20 in DB 1.
      
      Because of the problem above, there was a bug affecting replication of
      Lua scripts, because of the actual implementation of replication. It was
      possible to fix the implementation of Lua scripts in order to fix the
      issue, but looking closely, the bug is the consequence of the behavior
      of Lua ability to set the caller's DB.
      
      Under the old semantics, a script selecting a different DB, has no simple
      ways to restore the state and select back the previously selected DB.
      Moreover the script auhtor must remember that the restore is needed,
      otherwise the new commands executed by the caller, will be executed in
      the context of a different DB.
      
      So this commit fixes both the replication issue, and this hard-to-use
      semantics, by removing the ability of Lua, after the script execution,
      to force the caller to switch to the DB selected by the Lua script.
      
      The new behavior of the previous sequence of commadns is to just set
      X=20 in DB 0. However Lua scripts are still capable of writing / reading
      from different DBs if needed.
      
      WARNING: This is a semantical change that will break programs that are
      conceived to select the client selected DB via Lua scripts.
      
      This fixes issue #1811.
      96e0fe62
  3. 11 6月, 2014 5 次提交
  4. 10 6月, 2014 14 次提交
  5. 09 6月, 2014 2 次提交
  6. 07 6月, 2014 4 次提交
    • A
      ROLE output improved for slaves. · 6a13193d
      antirez 提交于
      Info about the replication state with the master added.
      6a13193d
    • A
      ROLE command added. · d34c2fa3
      antirez 提交于
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      d34c2fa3
    • A
      Cluster: check that configEpoch never goes back. · 32d0a79f
      antirez 提交于
      Since there are ways to alter the configEpoch outside of the failover
      procedure (for exampel CLUSTER SET-CONFIG-EPOCH and via the configEpoch
      collision resolution algorithm), make always sure, before replacing our
      configEpoch with a new one, that it is greater than the current one.
      32d0a79f
    • A
      Cluster: SET-CONFIG-EPOCH should update currentEpoch. · a2c2ef7d
      antirez 提交于
      SET-CONFIG-EPOCH, used by redis-trib at cluster creation time, failed to
      update the currentEpoch, making it possible after a failover for a
      server to set its configEpoch to a value smaller than the current one
      (since configEpochs are obtained using currentEpoch).
      
      The bug totally break the Redis Cluster algorithms and protocols
      allowing for permanent split brain conditions about the slots
      configuration as shown in issue #1799.
      a2c2ef7d
  7. 06 6月, 2014 4 次提交
  8. 05 6月, 2014 5 次提交
    • A
      Don't process min-slaves-to-write for slaves. · 14fb0ac6
      antirez 提交于
      Replication is totally broken when a slave has this option, since it
      stops accepting updates from masters.
      
      This fixes issue #1434.
      14fb0ac6
    • A
      Tests for min-slaves-* feature. · 134fd9ea
      antirez 提交于
      134fd9ea
    • A
      Fixed dbuf variable scope in luaRedisGenericCommand(). · 3758f27b
      antirez 提交于
      I'm not sure if while the visibility is the inner block, the fact we
      point to 'dbuf' is a problem or not, probably the stack var isx
      guaranteed to live until the function returns. However obvious code is
      better anyway.
      3758f27b
    • A
      Regression test for issue #1118. · 3307db49
      antirez 提交于
      3307db49
    • A
      Scripting: better Lua number -> string conversion in luaRedisGenericCommand(). · 072982d8
      antirez 提交于
      The lua_to*string() family of functions use a non optimal format
      specifier when converting integers to strings. This has both the problem
      of the number being converted in exponential notation, which we don't
      use as a Redis return value when floating point numbers are involed,
      and, moreover, there is a loss of precision since the default format
      specifier is not able to represent numbers that must be represented
      exactly in the IEEE 754 number mantissa.
      
      The new code handles it as a special case using a saner conversion.
      
      This fixes issue #1118.
      072982d8