Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
wrr-cat
apollo
提交
976b69d0
apollo
项目概览
wrr-cat
/
apollo
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
apollo
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
976b69d0
编写于
9月 09, 2018
作者:
J
Jason Song
提交者:
GitHub
9月 09, 2018
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #1462 from nobodyiam/remove-change-listener
add removeChangeListener api
上级
ee4cfccc
3f428211
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
71 addition
and
0 deletion
+71
-0
apollo-client/src/main/java/com/ctrip/framework/apollo/Config.java
...ient/src/main/java/com/ctrip/framework/apollo/Config.java
+8
-0
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/AbstractConfig.java
.../com/ctrip/framework/apollo/internals/AbstractConfig.java
+6
-0
apollo-client/src/test/java/com/ctrip/framework/apollo/internals/DefaultConfigTest.java
...m/ctrip/framework/apollo/internals/DefaultConfigTest.java
+57
-0
未找到文件。
apollo-client/src/main/java/com/ctrip/framework/apollo/Config.java
浏览文件 @
976b69d0
...
...
@@ -178,6 +178,14 @@ public interface Config {
*/
public
void
addChangeListener
(
ConfigChangeListener
listener
,
Set
<
String
>
interestedKeys
);
/**
* Remove the change listener
*
* @param listener the specific config change listener to remove
* @return true if the specific config change listener is found and removed
*/
public
boolean
removeChangeListener
(
ConfigChangeListener
listener
);
/**
* Return a set of the property names
*
...
...
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/AbstractConfig.java
浏览文件 @
976b69d0
...
...
@@ -85,6 +85,12 @@ public abstract class AbstractConfig implements Config {
}
}
@Override
public
boolean
removeChangeListener
(
ConfigChangeListener
listener
)
{
m_interestedKeys
.
remove
(
listener
);
return
m_listeners
.
remove
(
listener
);
}
@Override
public
Integer
getIntProperty
(
String
key
,
Integer
defaultValue
)
{
try
{
...
...
apollo-client/src/test/java/com/ctrip/framework/apollo/internals/DefaultConfigTest.java
浏览文件 @
976b69d0
...
...
@@ -3,6 +3,7 @@ package com.ctrip.framework.apollo.internals;
import
static
org
.
junit
.
Assert
.
assertArrayEquals
;
import
static
org
.
junit
.
Assert
.
assertEquals
;
import
static
org
.
junit
.
Assert
.
assertFalse
;
import
static
org
.
junit
.
Assert
.
assertTrue
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
times
;
import
static
org
.
mockito
.
Mockito
.
verify
;
...
...
@@ -705,6 +706,62 @@ public class DefaultConfigTest {
assertFalse
(
interestedInSomeKeyNotChangedFuture
.
isDone
());
}
@Test
public
void
testRemoveChangeListener
()
throws
Exception
{
String
someNamespace
=
"someNamespace"
;
final
ConfigChangeEvent
someConfigChangEvent
=
mock
(
ConfigChangeEvent
.
class
);
ConfigChangeEvent
anotherConfigChangEvent
=
mock
(
ConfigChangeEvent
.
class
);
final
SettableFuture
<
ConfigChangeEvent
>
someListenerFuture1
=
SettableFuture
.
create
();
final
SettableFuture
<
ConfigChangeEvent
>
someListenerFuture2
=
SettableFuture
.
create
();
ConfigChangeListener
someListener
=
new
ConfigChangeListener
()
{
@Override
public
void
onChange
(
ConfigChangeEvent
changeEvent
)
{
if
(
someConfigChangEvent
==
changeEvent
)
{
someListenerFuture1
.
set
(
changeEvent
);
}
else
{
someListenerFuture2
.
set
(
changeEvent
);
}
}
};
final
SettableFuture
<
ConfigChangeEvent
>
anotherListenerFuture1
=
SettableFuture
.
create
();
final
SettableFuture
<
ConfigChangeEvent
>
anotherListenerFuture2
=
SettableFuture
.
create
();
ConfigChangeListener
anotherListener
=
new
ConfigChangeListener
()
{
@Override
public
void
onChange
(
ConfigChangeEvent
changeEvent
)
{
if
(
someConfigChangEvent
==
changeEvent
)
{
anotherListenerFuture1
.
set
(
changeEvent
);
}
else
{
anotherListenerFuture2
.
set
(
changeEvent
);
}
}
};
ConfigChangeListener
yetAnotherListener
=
mock
(
ConfigChangeListener
.
class
);
DefaultConfig
config
=
new
DefaultConfig
(
someNamespace
,
mock
(
ConfigRepository
.
class
));
config
.
addChangeListener
(
someListener
);
config
.
addChangeListener
(
anotherListener
);
config
.
fireConfigChange
(
someConfigChangEvent
);
assertEquals
(
someConfigChangEvent
,
someListenerFuture1
.
get
(
500
,
TimeUnit
.
MILLISECONDS
));
assertEquals
(
someConfigChangEvent
,
anotherListenerFuture1
.
get
(
500
,
TimeUnit
.
MILLISECONDS
));
assertFalse
(
config
.
removeChangeListener
(
yetAnotherListener
));
assertTrue
(
config
.
removeChangeListener
(
someListener
));
config
.
fireConfigChange
(
anotherConfigChangEvent
);
assertEquals
(
anotherConfigChangEvent
,
anotherListenerFuture2
.
get
(
500
,
TimeUnit
.
MILLISECONDS
));
TimeUnit
.
MILLISECONDS
.
sleep
(
100
);
assertFalse
(
someListenerFuture2
.
isDone
());
}
@Test
public
void
testGetPropertyNames
()
{
String
someKeyPrefix
=
"someKey"
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录