提交 4f37245c 编写于 作者: J Jason Song 提交者: GitHub

Merge pull request #377 from lepdou/open

delete item api move operator field to request body
...@@ -68,17 +68,17 @@ public class ItemController { ...@@ -68,17 +68,17 @@ public class ItemController {
RequestPrecondition.checkArguments( RequestPrecondition.checkArguments(
!StringUtils.isContainEmpty(item.getKey(), item.getValue(), item.getDataChangeLastModifiedBy()), !StringUtils.isContainEmpty(item.getKey(), item.getValue(), item.getDataChangeLastModifiedBy()),
"key,value,dataChangeLastModifiedBy 字段不能为空"); "key,value,dataChangeLastModifiedBy can not be empty");
RequestPrecondition.checkArguments(item.getKey().equals(key), "path中的key和payload中的key不一致"); RequestPrecondition.checkArguments(item.getKey().equals(key), "Key in path and payload is not consistent");
if (userService.findByUserId(item.getDataChangeLastModifiedBy()) == null) { if (userService.findByUserId(item.getDataChangeLastModifiedBy()) == null) {
throw new BadRequestException("用户不存在"); throw new BadRequestException("user(dataChangeLastModifiedBy) not exists");
} }
ItemDTO toUpdateItem = itemService.loadItem(Env.fromString(env), appId, clusterName, namespaceName, item.getKey()); ItemDTO toUpdateItem = itemService.loadItem(Env.fromString(env), appId, clusterName, namespaceName, item.getKey());
if (toUpdateItem == null) { if (toUpdateItem == null) {
throw new BadRequestException("item不存在"); throw new BadRequestException("item not exists");
} }
//protect. only value,comment,lastModifiedBy can be modified //protect. only value,comment,lastModifiedBy can be modified
toUpdateItem.setComment(item.getComment()); toUpdateItem.setComment(item.getComment());
...@@ -97,12 +97,12 @@ public class ItemController { ...@@ -97,12 +97,12 @@ public class ItemController {
HttpServletRequest request) { HttpServletRequest request) {
if (userService.findByUserId(operator) == null) { if (userService.findByUserId(operator) == null) {
throw new BadRequestException("用户不存在"); throw new BadRequestException("user(operator) not exists");
} }
ItemDTO toDeleteItem = itemService.loadItem(Env.valueOf(env), appId, clusterName, namespaceName, key); ItemDTO toDeleteItem = itemService.loadItem(Env.valueOf(env), appId, clusterName, namespaceName, key);
if (toDeleteItem == null){ if (toDeleteItem == null){
throw new BadRequestException("item不存在"); throw new BadRequestException("item not exists");
} }
itemService.deleteItem(Env.fromString(env), toDeleteItem.getId(), operator); itemService.deleteItem(Env.fromString(env), toDeleteItem.getId(), operator);
......
...@@ -47,7 +47,7 @@ public class ReleaseController { ...@@ -47,7 +47,7 @@ public class ReleaseController {
"releaseTitle and releaseBy can not be empty"); "releaseTitle and releaseBy can not be empty");
if (userService.findByUserId(model.getReleasedBy()) == null) { if (userService.findByUserId(model.getReleasedBy()) == null) {
throw new BadRequestException("用户不存在."); throw new BadRequestException("user(releaseBy) not exists");
} }
model.setAppId(appId); model.setAppId(appId);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册