1. 26 6月, 2017 8 次提交
  2. 25 6月, 2017 1 次提交
  3. 23 6月, 2017 16 次提交
  4. 22 6月, 2017 3 次提交
    • P
      Merge pull request #14677 from karalabe/miner-cli-gasprice · c98d9b49
      Péter Szilágyi 提交于
      cmd/geth: corrently init gas price for CLI CPU mining
      c98d9b49
    • F
      eth/downloader: separate state sync from queue (#14460) · 0042f13d
      Felix Lange 提交于
      * eth/downloader: separate state sync from queue
      
      Scheduling of state node downloads hogged the downloader queue lock when
      new requests were scheduled. This caused timeouts for other requests.
      With this change, state sync is fully independent of all other downloads
      and doesn't involve the queue at all.
      
      State sync is started and checked on in processContent. This is slightly
      awkward because processContent doesn't have a select loop. Instead, the
      queue is closed by an auxiliary goroutine when state sync fails. We
      tried several alternatives to this but settled on the current approach
      because it's the least amount of change overall.
      
      Handling of the pivot block has changed slightly: the queue previously
      prevented import of pivot block receipts before the state of the pivot
      block was available. In this commit, the receipt will be imported before
      the state. This causes an annoyance where the pivot block is committed
      as fast block head even when state downloads fail. Stay tuned for more
      updates in this area ;)
      
      * eth/downloader: remove cancelTimeout channel
      
      * eth/downloader: retry state requests on timeout
      
      * eth/downloader: improve comment
      
      * eth/downloader: mark peers idle when state sync is done
      
      * eth/downloader: move pivot block splitting to processContent
      
      This change also ensures that pivot block receipts aren't imported
      before the pivot block itself.
      
      * eth/downloader: limit state node retries
      
      * eth/downloader: improve state node error handling and retry check
      
      * eth/downloader: remove maxStateNodeRetries
      
      It fails the sync too much.
      
      * eth/downloader: remove last use of cancelCh in statesync.go
      
      Fixes TestDeliverHeadersHang*Fast and (hopefully)
      the weird cancellation behaviour at the end of fast sync.
      
      * eth/downloader: fix leak in runStateSync
      
      * eth/downloader: don't run processFullSyncContent in LightSync mode
      
      * eth/downloader: improve comments
      
      * eth/downloader: fix vet, megacheck
      
      * eth/downloader: remove unrequested tasks anyway
      
      * eth/downloader, trie: various polishes around duplicate items
      
      This commit explicitly tracks duplicate and unexpected state
      delieveries done against a trie Sync structure, also adding
      there to import info logs.
      
      The commit moves the db batch used to commit trie changes one
      level deeper so its flushed after every node insertion. This
      is needed to avoid a lot of duplicate retrievals caused by
      inconsistencies between Sync internals and database. A better
      approach is to track not-yet-written states in trie.Sync and
      flush on commit, but I'm focuing on correctness first now.
      
      The commit fixes a regression around pivot block fail count.
      The counter previously was reset to 1 if and only if a sync
      cycle progressed (inserted at least 1 entry to the database).
      The current code reset it already if a node was delivered,
      which is not stong enough, because unless it ends up written
      to disk, an attacker can just loop and attack ad infinitum.
      
      The commit also fixes a regression around state deliveries
      and timeouts. The old downloader tracked if a delivery is
      stale (none of the deliveries were requestedt), in which
      case it didn't mark the node idle and did not send further
      requests, since it signals a past timeout. The current code
      did mark it idle even on stale deliveries, which eventually
      caused two requests to be in flight at the same time, making
      the deliveries always stale and mass duplicating retrievals
      between multiple peers.
      
      * eth/downloader: fix state request leak
      
      This commit fixes the hang seen sometimes while doing the state
      sync. The cause of the hang was a rare combination of events:
      request state data from peer, peer drops and reconnects almost
      immediately. This caused a new download task to be assigned to
      the peer, overwriting the old one still waiting for a timeout,
      which in turned leaked the requests out, never to be retried.
      The fix is to ensure that a task assignment moves any pending
      one back into the retry queue.
      
      The commit also fixes a regression with peer dropping due to
      stalls. The current code considered a peer stalling if they
      timed out delivering 1 item. However, the downloader never
      requests only one, the minimum is 2 (attempt to fine tune
      estimated latency/bandwidth). The fix is simply to drop if
      a timeout is detected at 2 items.
      
      Apart from the above bugfixes, the commit contains some code
      polishes I made while debugging the hang.
      
      * core, eth, trie: support batched trie sync db writes
      
      * trie: rename SyncMemCache to syncMemBatch
      0042f13d
    • P
      d4326888
  5. 21 6月, 2017 12 次提交