* core/rawdb : log format fix for Unindexing transaction

* core/rawdb: tiny fixup
Co-authored-by: NPéter Szilágyi <peterke@gmail.com>

* les: drop the message if the entire p2p connection is stuck

* les: fix lint

core: fixup blockchain tests

params: bump CHTs for the v1.9.14 release

* cmd, core, eth: init tx lookup in background

* core/rawdb: tiny log fixes to make it clearer what's happening

* core, eth: fix rebase errors

* core/rawdb: make reindexing less generic, but more optimal

* rlp: implement rlp list iterator

* core/rawdb: new implementation of tx indexing/unindex using generic tx iterator and hashing rlp-data

* core/rawdb, cmd/utils: fix review concerns

* cmd/utils: fix merge issue

* core/rawdb: add some log formatting polishes
Co-authored-by: Nrjl493456442 <garyrong0905@gmail.com>
Co-authored-by: NPéter Szilágyi <peterke@gmail.com>

* p2p: add low port check in dialer

We already have a check like this for UDP ports, add a similar one in
the dialer. This prevents dials to port zero and it's also an extra
layer of protection against spamming HTTP servers.

* p2p/discover: use errLowPort in v4 code

* p2p: change port check

* p2p: add comment

* p2p/simulations/adapters: ensure assigned port is in all node records

* core/rawdb: Stop freezer process as part of freezer.Close()

When you call db.Close(), it was closing the leveldb database first,
then closing the freezer, but never stopping the freezer process.
This could cause the freezer to attempt to write to leveldb after
leveldb had been closed, leading to a crash with a non-zero exit code.

This change adds a quit channel to the freezer, and freezer.Close()
will not return until the freezer process has stopped.

Additionally, when you call freezerdb.Close(), it will close the
AncientStore before closing leveldb, to ensure that the freezer goroutine
will be stopped before leveldb is closed.

* core/rawdb: Fix formatting for golint

* core/rawdb: Use backoff flag to avoid repeating select

* core/rawdb: Include accidentally omitted backoff

Fixes #21046

* params: remove outdated discv5 bootnodes

* cmd/utils: deprecated bootnodesv4/v5 flags

core/state: make GetCodeSize mirror GetCode implementation wise

* accounts/abi/bind/backend, internal/ethapi: recap gas limit with balance

* accounts, internal: address comment and fix lint

* accounts, internal: extend log message

* tiny nits to format hexutil.Big and nil properly
Co-authored-by: NPéter Szilágyi <peterke@gmail.com>

* build: Fix CLI params for windows LNK files

closes #21054

* Remove parameters

* core/state: more verbose stateb errors

* core/state: fix flaw

* core/state: fixed lint
Co-authored-by: NMarius van der Wijden <m.vanderwijden@live.de>

This finally adds the error check that the documentation of StateDB.dbErr
promises to do. dbErr was added in 9e5f03b6 (June 2017), and the check was
already missing in that commit. We somehow survived without it for three years.

* Include 0x0000 address into the dump if it is present

* core/state: go fmt
Co-authored-by: NAlexey Akhunov <akhounov@gmail.com>

* accounts/abi/bind: add void if no return args specified

Currently the java generator generates invalid input on pure/view functions
that have no return type. e.g. `function f(uint u) view public {}`
This is not a problem in practice as people rarely ever write functions like this.

* accounts/abi/bind: use elseif instead of nested if

core/state/snapshot: don't create storage list for non-existing accounts

* eth: don't reassign more cache than is being made available

* eth: don't inadvertently enable snapshot in a case where --snapshot wasn't given

eth: skip transaction announcer goroutine on eth<65

cmd/geth: handle memfixes on 32bit arch with large RAM

* accounts/abi: added getType func to Type struct

* accounts/abi: fixed tuple unpack

* accounts/abi: removed type.Type

* accounts/abi: added comment

* accounts/abi: removed unused types

* accounts/abi: removed superfluous declarations

* accounts/abi: typo

tests: skip consensus test using 1GB RAM

* rpc flags related to starting http server renamed to http

* old rpc flags aliased and still functional

* pprof flags fixed

* renames gpo related flags

* linted

* renamed rpc flags for consistency and clarity

* added warn logs

* added more warn logs for all deprecated flags for consistency

* moves legacy flags to separate file, hides older flags under show-deprecated-flags command

* legacy prefix and moved some more legacy flags to legacy file

* fixed circular import

* added docs

* fixed imports lint error

* added notes about when flags were deprecated

* cmd/utils: group flags by deprecation date + reorder by date,

* modified deprecated comments for consistency, added warn log for --rpc

* making sure deprecated flags are still functional

* show-deprecated-flags command cleaned up

* fixed lint errors

* corrected merge conflict

* IsSet --> GlobalIsSet

* uncategorized flags, if not deprecated, displayed under misc
Co-authored-by: NMartin Holst Swende <martin@swende.se>

core/state/snapshot: release iterator after verification

tests: cleanup snapshot generator goroutine leak

* accounts/abi: removed Kind from Type struct

* accounts/abi: removed unused code