1. 17 4月, 2019 3 次提交
  2. 10 4月, 2019 4 次提交
  3. 09 4月, 2019 3 次提交
  4. 08 4月, 2019 10 次提交
  5. 02 4月, 2019 2 次提交
  6. 20 2月, 2019 4 次提交
  7. 19 2月, 2019 14 次提交
    • L
      swarm: Reinstate Pss Protocol add call through swarm service (#19117) · 7ae2a7bd
      lash 提交于
      * swarm: Reinstate Pss Protocol add call through swarm service
      
      * swarm: Even less self
      
      (cherry picked from commit d88c6ce6)
      7ae2a7bd
    • K
      contracts/*: golint updates for this or self warning · fd34bf59
      Kiel barry 提交于
      (cherry picked from commit 53b823af)
      fd34bf59
    • H
      cmd/swarm/swarm-smoke: Trigger chunk debug on timeout (#19101) · 99623017
      holisticode 提交于
      * cmd/swarm/swarm-smoke: first version trigger has-chunks on timeout
      
      * cmd/swarm/swarm-smoke: finalize trigger to chunk debug
      
      * cmd/swarm/swarm-smoke: fixed httpEndpoint for trigger
      
      * cmd/swarm/swarm-smoke: port
      
      * cmd/swarm/swarm-smoke: ws not rpc
      
      * cmd/swarm/swarm-smoke: added debug output
      
      * cmd/swarm/swarm-smoke: addressed PR comments
      
      * cmd/swarm/swarm-smoke: renamed track-timeout and track-chunks
      
      (cherry picked from commit 62d7688d)
      99623017
    • F
      p2p, swarm: fix node up races by granular locking (#18976) · 88577076
      Ferenc Szabo 提交于
      * swarm/network: DRY out repeated giga comment
      
      I not necessarily agree with the way we wait for event propagation.
      But I truly disagree with having duplicated giga comments.
      
      * p2p/simulations: encapsulate Node.Up field so we avoid data races
      
      The Node.Up field was accessed concurrently without "proper" locking.
      There was a lock on Network and that was used sometimes to access
      the  field. Other times the locking was missed and we had
      a data race.
      
      For example: https://github.com/ethereum/go-ethereum/pull/18464
      The case above was solved, but there were still intermittent/hard to
      reproduce races. So let's solve the issue permanently.
      
      resolves: ethersphere/go-ethereum#1146
      
      * p2p/simulations: fix unmarshal of simulations.Node
      
      Making Node.Up field private in 13292ee897e345045fbfab3bda23a77589a271c1
      broke TestHTTPNetwork and TestHTTPSnapshot. Because the default
      UnmarshalJSON does not handle unexported fields.
      
      Important: The fix is partial and not proper to my taste. But I cut
      scope as I think the fix may require a change to the current
      serialization format. New ticket:
      https://github.com/ethersphere/go-ethereum/issues/1177
      
      * p2p/simulations: Add a sanity test case for Node.Config UnmarshalJSON
      
      * p2p/simulations: revert back to defer Unlock() pattern for Network
      
      It's a good patten to call `defer Unlock()` right after `Lock()` so
      (new) error cases won't miss to unlock. Let's get back to that pattern.
      
      The patten was abandoned in 85a79b3a,
      while fixing a data race. That data race does not exist anymore,
      since the Node.Up field got hidden behind its own lock.
      
      * p2p/simulations: consistent naming for test providers Node.UnmarshalJSON
      
      * p2p/simulations: remove JSON annotation from private fields of Node
      
      As unexported fields are not serialized.
      
      * p2p/simulations: fix deadlock in Network.GetRandomDownNode()
      
      Problem: GetRandomDownNode() locks -> getDownNodeIDs() ->
      GetNodes() tries to lock -> deadlock
      
      On Network type, unexported functions must assume that `net.lock`
      is already acquired and should not call exported functions which
      might try to lock again.
      
      * p2p/simulations: ensure method conformity for Network
      
      Connect* methods were moved to p2p/simulations.Network from
      swarm/network/simulation. However these new methods did not follow
      the pattern of Network methods, i.e., all exported method locks
      the whole Network either for read or write.
      
      * p2p/simulations: fix deadlock during network shutdown
      
      `TestDiscoveryPersistenceSimulationSimAdapter` often got into deadlock.
      The execution was stuck on two locks, i.e, `Kademlia.lock` and
      `p2p/simulations.Network.lock`. Usually the test got stuck once in each
      20 executions with high confidence.
      
      `Kademlia` was stuck in `Kademlia.EachAddr()` and `Network` in
      `Network.Stop()`.
      
      Solution: in `Network.Stop()` `net.lock` must be released before
      calling `node.Stop()` as stopping a node (somehow - I did not find
      the exact code path) causes `Network.InitConn()` to be called from
      `Kademlia.SuggestPeer()` and that blocks on `net.lock`.
      
      Related ticket: https://github.com/ethersphere/go-ethereum/issues/1223
      
      * swarm/state: simplify if statement in DBStore.Put()
      
      * p2p/simulations: remove faulty godoc from private function
      
      The comment started with the wrong method name.
      
      The method is simple and self explanatory. Also, it's private.
      => Let's just remove the comment.
      
      (cherry picked from commit 50b872bf)
      88577076
    • G
      swarm/pss: refactoring (#19110) · d6c1fcbe
      gluk256 提交于
      * swarm/pss: split pss and keystore
      
      * swarm/pss: moved whisper to keystore
      
      * swarm/pss: goimports fixed
      
      (cherry picked from commit 12ca3b17)
      d6c1fcbe
    • E
      swarm/storage/netstore: add fetcher cancellation on shutdown (#19049) · 79cac793
      Elad 提交于
      swarm/network/stream: remove netstore internal wg
      swarm/network/stream: run individual tests with t.Run
      
      (cherry picked from commit 3ee09ba0)
      79cac793
    • H
      swarm/network: Saturation check for healthy networks (#19071) · 5de6b6b5
      holisticode 提交于
      * swarm/network: new saturation for  implementation
      
      * swarm/network: re-added saturation func in Kademlia as it is used elsewhere
      
      * swarm/network: saturation with higher MinBinSize
      
      * swarm/network: PeersPerBin with depth check
      
      * swarm/network: edited tests to pass new saturated check
      
      * swarm/network: minor fix saturated check
      
      * swarm/network/simulations/discovery: fixed renamed RPC call
      
      * swarm/network: renamed to isSaturated and returns bool
      
      * swarm/network: early depth check
      
      (cherry picked from commit 2af24724)
      5de6b6b5
    • E
      swarm/storage: fix influxdb gc metrics report (#19102) · 3d2bedf8
      Elad 提交于
      (cherry picked from commit 5b8ae788)
      3d2bedf8
    • J
      swarm: fix network/stream data races (#19051) · 8ea3d8ad
      Janoš Guljaš 提交于
      * swarm/network/stream: newStreamerTester cleanup only if err is nil
      
      * swarm/network/stream: raise newStreamerTester waitForPeers timeout
      
      * swarm/network/stream: fix data races in GetPeerSubscriptions
      
      * swarm/storage: prevent data race on LDBStore.batchesC
      
      https://github.com/ethersphere/go-ethereum/issues/1198#issuecomment-461775049
      
      * swarm/network/stream: fix TestGetSubscriptionsRPC data race
      
      https://github.com/ethersphere/go-ethereum/issues/1198#issuecomment-461768477
      
      * swarm/network/stream: correctly use Simulation.Run callback
      
      https://github.com/ethersphere/go-ethereum/issues/1198#issuecomment-461783804
      
      * swarm/network: protect addrCountC in Kademlia.AddrCountC function
      
      https://github.com/ethersphere/go-ethereum/issues/1198#issuecomment-462273444
      
      * p2p/simulations: fix a deadlock calling getRandomNode with lock
      
      https://github.com/ethersphere/go-ethereum/issues/1198#issuecomment-462317407
      
      * swarm/network/stream: terminate disconnect goruotines in tests
      
      * swarm/network/stream: reduce memory consumption when testing data races
      
      * swarm/network/stream: add watchDisconnections helper function
      
      * swarm/network/stream: add concurrent counter for tests
      
      * swarm/network/stream: rename race/norace test files and use const
      
      * swarm/network/stream: remove watchSim and its panic
      
      * swarm/network/stream: pass context in watchDisconnections
      
      * swarm/network/stream: add concurrent safe bool for watchDisconnections
      
      * swarm/storage: fix LDBStore.batchesC data race by not closing it
      
      (cherry picked from commit 3fd6db2b)
      8ea3d8ad
    • E
      swarm: fix uptime gauge update goroutine leak by introducing cleanup functions (#19040) · a0127019
      Elad 提交于
      (cherry picked from commit d596bea2)
      a0127019
    • H
      swarm/storage: fix HashExplore concurrency bug ethersphere#1211 (#19028) · 7a333e41
      holisticode 提交于
      * swarm/storage: fix HashExplore concurrency bug ethersphere#1211
      
      *  swarm/storage: lock as value not pointer
      
      * swarm/storage: wait for  to complete
      
      * swarm/storage: fix linter problems
      
      * swarm/storage: append to nil slice
      
      (cherry picked from commit 3d22a46c)
      7a333e41
    • G
      swarm/pss: mutex lifecycle fixed (#19045) · 799fe995
      gluk256 提交于
      (cherry picked from commit b30109df)
      799fe995
    • R
      swarm/docker: add global-store and split docker images (#19038) · 3b02b0ba
      Rafael Matias 提交于
      (cherry picked from commit 6cb7d52a)
      3b02b0ba
    • J
      cmd/swarm/global-store: global store cmd (#19014) · 85217b08
      Janoš Guljaš 提交于
      (cherry picked from commit 33d0a0ef)
      85217b08