• F
    eth/downloader: don't hang for spurious deliveries · 900da3d8
    Felix Lange 提交于
    Unexpected deliveries could block indefinitely if they arrived at the
    right time. The fix is to ensure that the cancellation channel is
    always closed when the sync ends, unblocking any deliveries. Also remove
    the atomic check for whether a sync is currently running because it
    doesn't help and can be misleading.
    
    Cancelling always seems to break the tests though. The downloader
    spawned d.process whenever new data arrived, making it somewhat hard to
    track when block processing was actually done. Fix this by running
    d.process in a dedicated goroutine that is tied to the lifecycle of the
    sync. d.process gets notified of new work by the queue instead of being
    invoked all the time. This removes a ton of weird workaround code,
    including a hairy use of atomic CAS.
    900da3d8
queue.go 34.8 KB