add test

dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactory.java

@@ -45,12 +45,14 @@ public class ScriptAlertChannelFactory implements AlertChannelFactory {
                 .addValidate(Validate.newBuilder()
                         .setRequired(false)
                         .build())
+                .setPlaceholder("please enter your custom parameters, which will be passed to you when calling your script")
                 .build();
         // need check file type and file exist
         InputParam scriptPathParam = InputParam.newBuilder(ScriptParamsConstants.NAME_SCRIPT_PATH, ScriptParamsConstants.SCRIPT_PATH)
                 .addValidate(Validate.newBuilder()
                         .setRequired(true)
                         .build())
+                .setPlaceholder("please upload the file to the disk directory of the alarm server, and ensure that the path is absolute and has the corresponding access rights")
                 .build();
 
         RadioParam scriptTypeParams = RadioParam.newBuilder(ScriptParamsConstants.NAME_SCRIPT_TYPE, ScriptParamsConstants.SCRIPT_TYPE)

dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java

@@ -46,7 +46,7 @@ public class ScriptSender {
     public AlertResult sendScriptAlert(String msg) {
         AlertResult alertResult = new AlertResult();
         if (ScriptType.of(scriptType).equals(ScriptType.SHELL)) {
-            executeShellScript(msg);
+            return executeShellScript(msg);
         }
         return alertResult;
     }

dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java

+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.alert.script;
+
+import org.junit.Test;
+
+/**
+ * ProcessUtilsTest
+ */
+public class ProcessUtilsTest {
+
+    private static final String rootPath=System.getProperty("user.dir");
+
+    private static final String shellFilPath=rootPath+"/dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/test/script/shell/example.sh";
+
+    private String[] cmd={"/bin/sh", "-c", shellFilPath + " " + "testMsg" + " " + "userParams"};
+
+    @Test
+    public void testExecuteScript(){
+        ProcessUtils.executeScript(cmd);
+    }
+}

dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java

+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.alert.script;
+
+import org.apache.dolphinscheduler.spi.alert.AlertResult;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+/**
+ * ScriptSenderTest
+ */
+public class ScriptSenderTest {
+
+    private static Map<String, String> scriptConfig = new HashMap<>();
+
+    private static final String rootPath = System.getProperty("user.dir");
+
+    private static final String shellFilPath = rootPath + "/src/test/script/shell/scriptTest.sh";
+
+    @Before
+    public void initScriptConfig() {
+
+        scriptConfig.put(ScriptParamsConstants.NAME_SCRIPT_TYPE, String.valueOf(ScriptType.SHELL.getCode()));
+        scriptConfig.put(ScriptParamsConstants.NAME_SCRIPT_USER_PARAMS, "userParams");
+        scriptConfig.put(ScriptParamsConstants.NAME_SCRIPT_PATH, shellFilPath);
+    }
+
+    @Test
+    public void testScriptSenderTest() {
+        ScriptSender scriptSender = new ScriptSender(scriptConfig);
+        AlertResult alertResult;
+        alertResult = scriptSender.sendScriptAlert("success");
+        Assert.assertEquals("true", alertResult.getStatus());
+        alertResult = scriptSender.sendScriptAlert("errorMsg");
+        Assert.assertEquals("false", alertResult.getStatus());
+    }
+
+}

dolphinscheduler-alert-plugin/dolphinscheduler-alert-script/src/test/script/shell/scriptTest.sh

+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+msg=$1
+content=$2
+
+if  [ $msg = errorMsg ]
+   then
+     exit 12
+fi
+exit 0
\ No newline at end of file

pom.xml

@@ -957,6 +957,9 @@
                         <include>**/plugin/alert/dingtalk/DingTalkAlertChannelFactoryTest.java</include>
                         <include>**/plugin/alert/wechat/WeChatSenderTest.java</include>
                         <include>**/plugin/alert/wechat/WeChatAlertChannelFactoryTest.java</include>
+                        <include>**/plugin/alert/script/ProcessUtilsTest.java</include>
+                        <include>**/plugin/alert/script/ScriptAlertChannelFactoryTest.java</include>
+                        <include>**/plugin/alert/script/ScriptSenderTest.java</include>
                         <include>**/spi/params/PluginParamsTransferTest.java</include>
                         <include>**/alert/plugin/EmailAlertPluginTest.java</include>
                         <include>**/alert/plugin/AlertPluginManagerTest.java</include>