1. 25 3月, 2014 3 次提交
    • J
      [JENKINS-22326] Calling into foreign code from a toString method, like... · a01ebae1
      Jesse Glick 提交于
      [JENKINS-22326] Calling into foreign code from a toString method, like Queue.Item.getWhy → QueueTaskDispatcher, is unsafe.
      a01ebae1
    • J
      Null safety during failing tests (BuildTriggerTest.testMavenBuildTrigger in this case). · fa496c7b
      Jesse Glick 提交于
      java.lang.NullPointerException
      	at hudson.model.Job.getBuildDir(Job.java:790)
      	at hudson.model.Run.getRootDir(Run.java:993)
      	at hudson.model.Run.getLogFile(Run.java:1306)
      	at hudson.model.Run.execute(Run.java:1664)
      	at hudson.maven.MavenBuild.access$900(MavenBuild.java:94)
      	at hudson.maven.MavenBuild$ProxyImpl2.close(MavenBuild.java:636)
      	at hudson.maven.AbstractMavenBuilder.end(AbstractMavenBuilder.java:106)
      	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:839)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:523)
      	at hudson.model.Run.execute(Run.java:1688)
      	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:519)
      	at hudson.model.ResourceController.execute(ResourceController.java:88)
      	at hudson.model.Executor.run(Executor.java:231)
      java.lang.NullPointerException
      	at hudson.model.BuildStepListener.all(BuildStepListener.java:31)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:739)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:714)
      	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1054)
      	at hudson.model.Run.execute(Run.java:1733)
      	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:519)
      	at hudson.model.ResourceController.execute(ResourceController.java:88)
      	at hudson.model.Executor.run(Executor.java:231)
      fa496c7b
    • J
      Cannot call setResult during finalization phase. · 8c9430f1
      Jesse Glick 提交于
      From a random failure of BuildTriggerTest.testMavenBuildTrigger:
      java.lang.AssertionError
      	at hudson.model.Run.setResult(Run.java:425)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:722)
      	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1054)
      	at hudson.model.Run.execute(Run.java:1733)
      	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:519)
      	at hudson.model.ResourceController.execute(ResourceController.java:88)
      	at hudson.model.Executor.run(Executor.java:231)
      8c9430f1
  2. 24 3月, 2014 5 次提交
  3. 22 3月, 2014 4 次提交
  4. 21 3月, 2014 2 次提交
  5. 20 3月, 2014 5 次提交
  6. 19 3月, 2014 4 次提交
  7. 18 3月, 2014 7 次提交
  8. 17 3月, 2014 7 次提交
  9. 15 3月, 2014 3 次提交
    • K
      0db32eca
    • K
      Fixing a test failure. · bd8234cc
      Kohsuke Kawaguchi 提交于
      The intent of this test is to make sure that a floating User object without any storage returns false from canDelete() method.
      The earlier change made User.impersonate() to actually check if the user is a valid, so to make this test case work where it does
      "user.impersonate" and "user2.impersonate2", I'm creating valid accounts for these two users.
      
      Now what that means is that user2 is no longer a floating flyweight storage-less User, so it breaks the assumption of the
      "User should not be able to delete because he is not saved." assertion.
      
      To make this test case work, I'm introducing the 3rd user that is storage-less, and using it for the test.
      bd8234cc
    • J