Setting a nonempty contextPath turned up a couple problems in the test harness; goTo must be given a relative path.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2602/testReport/junit/hudson.model/JobTest/readPermission/
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:47898/jenkins//j_acegi_security_check
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:549)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:333)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:357)
	at com.gargoylesoftware.htmlunit.html.HtmlForm.submit(HtmlForm.java:196)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:1776)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.login(JenkinsRule.java:1788)
	at hudson.model.JobTest.readPermission(JobTest.java:182)

This reverts commit 9fb2a025.

This reverts commit f460e1e8.

[JENKINS-18326] add maven site support for nested submodules
Thanks!

[JENKINS-16845] Properly report the IllegalStateException, rather than throwing an NPE producing the exception message.
java.lang.NullPointerException
	at hudson.model.Run.getFullDisplayName(Run.java:711)
	at hudson.model.Run.toString(Run.java:706)
	at java.lang.String.valueOf(Unknown Source)
	at java.lang.StringBuilder.append(Unknown Source)
	at hudson.model.AbstractBuild.getPreviousBuild(AbstractBuild.java:218)

See f8916a839c5a7bfe6d0de100a33cf23de33de6e4 for the corresponding change in the remoting.

Since the error messages only use ASCII

As Jesse pointed out, contextual information is often useful in authenticating the build, which means we need to take Queue.Item (initially AbstractBuild was the parameter, which provided the context, and I failed to accommodate that in transition to AbstractProject.)

To still allow Queue.Tasks to provide a meaningful value fallback to Queue.Task.getDefaultAuthentication() as opposed to hard code it to ACL.SYSTEM. This allow plugins like remote-terminal-access to supply a meaningful secure value without forcing a configuration change to the user.

... because the fallback behaviour is sufficient for compatibility. In this way, we can phase in this feature more slowly

This is necessary because a part of the access control is determining which Executor can accept which Queue.Task, so we can't have the authenticator taking Executor as a parameter.

I briefly thought about changing ExecutorAuthenticator to authenticate Queue.SubTask, but doing this intelligently is very difficult as an authenticator wouldn't really be able to make any sensible decisions unless it checks for specific subtypes (think of the dist-fork plugin and the remote terminal access plugin that implements Queue.Task.) So I made the change to have it accept AbstractProject, which is really the primary use case anyway.

The relevant classes are renamed to better represent what it does now.

This required bridge method injector that maps boolean->void

[FIXED JENKINS-16974] Unsafe to define a function in <script> without a generated name, as it could clash with functions defined in unrelated *.jelly that happen to included in the same page.

[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven

https://ci.jenkins-ci.org/job/jenkins_main_trunk/2590/testReport/junit/hudson.matrix/MatrixTest/testSpaceInUrl/