git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30334 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30333 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30332 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30331 71c3de6d-444a-0410-be80-ed276b4c234a

user report indicates that if someone puts a null value into a system proeprty we get a hard-to-diagnose NPE. Adding code to proactively watch out for that:

[workspace] $ /usr/lib/jvm/sun-jdk-1.6/bin/java -cp /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-agent-1.355.jar:/usr/share/maven-bin-2.1/boot/classworlds-1.1.jar hudson.maven.agent.Main /usr/share/maven-bin-2.1 /opt/glassfish/server/glassfish/domains/domain1/applications/hudson/WEB-INF/lib/remoting-1.355.jar /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-interceptor-1.355.jar 35855 /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven2.1-interceptor-1.2.jar
<===[HUDSON REMOTING CAPACITY]===>���channel started
channel stopped
ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)
project=hudson.maven.MavenModuleSet@19cc863[Meetspace]
project.getModules()=[hudson.maven.MavenModule@19fef64[Meetspace/com.steeplesoft:meetspace], hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent], hudson.maven.MavenModule@11d8f11[Meetspace/com.steeplesoft.meetspace:plugin-engine], hudson.maven.MavenModule@b6e204[Meetspace/com.steeplesoft.meetspace:webapp], hudson.maven.MavenModule@b097da[Meetspace/com.steeplesoft.meetspace.plugins:helloworld-plugin], hudson.maven.MavenModule@1c18b6a[Meetspace/com.steeplesoft.meetspace.plugins:plugin-api], hudson.maven.MavenModule@1a80928[Meetspace/com.steeplesoft.meetspace.plugins:plugin-engine]]
project.getRootModule()=hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent]
FATAL: null
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30326 71c3de6d-444a-0410-be80-ed276b4c234a

https://www.dev.java.net/svn/hudson/branches/rc


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30321 71c3de6d-444a-0410-be80-ed276b4c234a

- Catch case in loadParametersFromAsm when not all parameter names were found
  (if a param has type "long" then an index is skipped, so a null is left in
   the array) and simply return null so it can fallback to a .stapler file.
  This fixes calling of Job.doTimelineData()
- Fix /adjuncts handling in some containers that don't like a leading /
  on a path for ClassLoader.getResource() (ok for jetty, bad for SJSWS7)
  This fixes loading of javascript for Timeline display in those containers.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30305 71c3de6d-444a-0410-be80-ed276b4c234a

Just show "ERROR" and show full error response only when this is clicked.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30304 71c3de6d-444a-0410-be80-ed276b4c234a

(e.g. batch-task plugin)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30303 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30302 71c3de6d-444a-0410-be80-ed276b4c234a

[FIXED HUDSON-6311] (actually, this change went in as rev.30287, but I'm testing if the issue update is working again)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30290 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30288 71c3de6d-444a-0410-be80-ed276b4c234a

[FIXED HUDSON-6311] reverted the problematic change and instead introduced the ideal signature in a new name.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30287 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30284 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30283 71c3de6d-444a-0410-be80-ed276b4c234a

Fixed UOE in the following exception. Maybe I shouldn't have relied on servlet filters and defined my own thing inside Stapler, so that this whole thing can happen after the request/response/stapler association was made.

But now it's too late. 

java.lang.UnsupportedOperationException
	at hudson.security.AccessDeniedHandlerImpl$1.getServletName(AccessDeniedHandlerImpl.java:58)
	at javax.servlet.GenericServlet.getServletName(GenericServlet.java:368)
	at javax.servlet.GenericServlet.log(GenericServlet.java:300)
	at javax.servlet.GenericServlet.init(GenericServlet.java:257)
	at org.kohsuke.stapler.Stapler.init(Stapler.java:67)
	at hudson.security.AccessDeniedHandlerImpl.handle(AccessDeniedHandlerImpl.java:56)
	at org.acegisecurity.ui.ExceptionTranslationFilter.handleException(ExceptionTranslationFilter.java:229)
	at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:176)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:112)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1088)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:829)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
	at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:488)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30282 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30281 71c3de6d-444a-0410-be80-ed276b4c234a

page title as described in case #1 in this issue.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30280 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30276 71c3de6d-444a-0410-be80-ed276b4c234a

as the index can be incorrect on node page or in a filtered view where
not all nodes are shown.  Use /computer/(name)/.. in links instead.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30275 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30273 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30269 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30268 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30238 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30237 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30236 71c3de6d-444a-0410-be80-ed276b4c234a

https://svn.dev.java.net/svn/hudson/branches/rc

........
  r30161 | kohsuke | 2010-04-16 20:12:58 -0700 (Fri, 16 Apr 2010) | 1 line
  
  forgot to commit this file
........
  r30162 | kohsuke | 2010-04-16 20:13:56 -0700 (Fri, 16 Apr 2010) | 1 line
  
  reworking the release process
........
  r30163 | kohsuke | 2010-04-16 20:47:30 -0700 (Fri, 16 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_355
........
  r30165 | kohsuke | 2010-04-16 20:47:51 -0700 (Fri, 16 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r30169 | kohsuke | 2010-04-16 22:56:23 -0700 (Fri, 16 Apr 2010) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30232 71c3de6d-444a-0410-be80-ed276b4c234a

fixed garbled response of XML API if xpath is specified. http://n4.nabble.com/Hudson-API-XML-td1723766.html#a1723766

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30178 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30139 71c3de6d-444a-0410-be80-ed276b4c234a

caused StringIndexOutOfBoundsException in UrlAnnotator.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30102 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30100 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30095 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30091 71c3de6d-444a-0410-be80-ed276b4c234a

HUDSON-6260 provide helpful information about the 'authenticated' group when adding a user/group to a matrix

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30088 71c3de6d-444a-0410-be80-ed276b4c234a

deadlock between saving project config and getting project page.. save locked
transientActions and then project itself; get locks project, then transientActions.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30087 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30074 71c3de6d-444a-0410-be80-ed276b4c234a

the comment was with the first attempted (and abandoned) implementation of console notes where files notes were sent over a separate channel.

Since now it's encoded into the log, this comment no longer applies.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30072 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30071 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30070 71c3de6d-444a-0410-be80-ed276b4c234a

https://www.dev.java.net/svn/hudson/branches/rc


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30069 71c3de6d-444a-0410-be80-ed276b4c234a