[FIXED HUDSON-5884] Making compilable with JDK 7 javac.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30701 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/java/hudson/DescriptorExtensionList.java

@@ -29,7 +29,6 @@ import hudson.model.Hudson;
 import hudson.model.ViewDescriptor;
 import hudson.model.Descriptor.FormException;
 import hudson.util.AdaptedIterator;
-import hudson.util.CopyOnWriteList;
 import hudson.util.Memoizer;
 import hudson.util.Iterators.FlattenIterator;
 import hudson.slaves.NodeDescriptor;
@@ -68,11 +67,13 @@ public class DescriptorExtensionList<T extends Describable<T>, D extends Descrip
     /**
      * Creates a new instance.
      */
-    public static <T extends Describable<T>,D extends Descriptor<T>>
-    DescriptorExtensionList<T,D> create(Hudson hudson, Class<T> describableType) {
-        if(describableType==(Class)Publisher.class) // javac or IntelliJ compiler complains if I don't have this cast
-            return (DescriptorExtensionList)new DescriptorExtensionListImpl(hudson);
-        return new DescriptorExtensionList<T,D>(hudson,describableType);
+    @SuppressWarnings({"unchecked", "rawtypes"}) // cannot use generic signature because it "overrides" method from ExtensionList
+    public static /*<T extends Describable<T>,D extends Descriptor<T>>*/
+    DescriptorExtensionList/*<T,D>*/ create(Hudson hudson, Class/*<T>*/ describableType) {
+        if (describableType == Publisher.class) {
+            return new DescriptorExtensionListImpl(hudson);
+        }
+        return new DescriptorExtensionList/*<T,D>*/(hudson,describableType);
     }
 
     /**

core/src/main/java/hudson/FileSystemProvisioner.java

@@ -186,7 +186,7 @@ public abstract class FileSystemProvisioner implements ExtensionPoint, Describab
      * Returns all the registered {@link FileSystemProvisioner} descriptors.
      */
     public static DescriptorExtensionList<FileSystemProvisioner,FileSystemProvisionerDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(FileSystemProvisioner.class);
+        return Hudson.getInstance().<FileSystemProvisioner,FileSystemProvisionerDescriptor>getDescriptorList(FileSystemProvisioner.class);
     }
 
     /**

core/src/main/java/hudson/Functions.java

@@ -657,7 +657,7 @@ public class Functions {
     }
 
     public static List<Descriptor<ComputerLauncher>> getComputerLauncherDescriptors() {
-        return Hudson.getInstance().getDescriptorList(ComputerLauncher.class);
+        return Hudson.getInstance().<ComputerLauncher,Descriptor<ComputerLauncher>>getDescriptorList(ComputerLauncher.class);
     }
 
     public static List<Descriptor<RetentionStrategy<?>>> getRetentionStrategyDescriptors() {

core/src/main/java/hudson/model/Hudson.java

@@ -348,7 +348,7 @@ public final class Hudson extends Node implements ItemGroup<TopLevelItem>, Stapl
      */
     private transient final Memoizer<Class,DescriptorExtensionList> descriptorLists = new Memoizer<Class,DescriptorExtensionList>() {
         public DescriptorExtensionList compute(Class key) {
-            return DescriptorExtensionList.create(Hudson.this,key);
+            return (DescriptorExtensionList) DescriptorExtensionList.create(Hudson.this,key);
         }
     };
 

core/src/main/java/hudson/model/Items.java

@@ -59,7 +59,7 @@ public class Items {
      * Returns all the registered {@link TopLevelItemDescriptor}s.
      */
     public static DescriptorExtensionList<TopLevelItem,TopLevelItemDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(TopLevelItem.class);
+        return Hudson.getInstance().<TopLevelItem,TopLevelItemDescriptor>getDescriptorList(TopLevelItem.class);
     }
 
     public static TopLevelItemDescriptor getDescriptor(String fqcn) {

core/src/main/java/hudson/model/ListView.java

@@ -52,7 +52,6 @@ import java.util.List;
 import java.util.TreeSet;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.Iterator;
 import java.util.SortedSet;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -240,7 +239,7 @@ public class ListView extends View implements Saveable {
         if (columns == null) {
             columns = new DescribableList<ListViewColumn,Descriptor<ListViewColumn>>(Saveable.NOOP);
         }
-        columns.rebuildHetero(req, req.getSubmittedForm(), Hudson.getInstance().getDescriptorList(ListViewColumn.class), "columns");
+        columns.rebuildHetero(req, req.getSubmittedForm(), ListViewColumn.all(), "columns");
     }
 
     @Extension

core/src/main/java/hudson/model/ParameterDefinition.java

@@ -27,7 +27,6 @@ import hudson.DescriptorExtensionList;
 import hudson.Extension;
 import hudson.ExtensionPoint;
 import hudson.AbortException;
-import hudson.cli.BuildCommand;
 import hudson.cli.CLICommand;
 import hudson.util.DescriptorList;
 
@@ -178,7 +177,7 @@ public abstract class ParameterDefinition implements
      * Returns all the registered {@link ParameterDefinition} descriptors.
      */
     public static DescriptorExtensionList<ParameterDefinition,ParameterDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(ParameterDefinition.class);
+        return Hudson.getInstance().<ParameterDefinition,ParameterDescriptor>getDescriptorList(ParameterDefinition.class);
     }
 
     /**

core/src/main/java/hudson/model/UserProperty.java

@@ -71,7 +71,7 @@ public abstract class UserProperty implements Describable<UserProperty>, Extensi
      * Returns all the registered {@link UserPropertyDescriptor}s.
      */
     public static DescriptorExtensionList<UserProperty,UserPropertyDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(UserProperty.class);
+        return Hudson.getInstance().<UserProperty,UserPropertyDescriptor>getDescriptorList(UserProperty.class);
     }
 
     public UserProperty reconfigure(StaplerRequest req, JSONObject form) throws FormException {

core/src/main/java/hudson/model/View.java

@@ -649,7 +649,7 @@ public abstract class View extends AbstractModelObject implements AccessControll
      * Returns all the registered {@link ViewDescriptor}s.
      */
     public static DescriptorExtensionList<View,ViewDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(View.class);
+        return Hudson.getInstance().<View,ViewDescriptor>getDescriptorList(View.class);
     }
 
     public static final Comparator<View> SORTER = new Comparator<View>() {

core/src/main/java/hudson/node_monitors/NodeMonitor.java

@@ -24,11 +24,9 @@
 package hudson.node_monitors;
 
 import hudson.ExtensionPoint;
-import hudson.Functions;
 import hudson.DescriptorExtensionList;
 import hudson.Extension;
 import hudson.tasks.Publisher;
-import hudson.scm.RepositoryBrowser;
 import hudson.model.Computer;
 import hudson.model.ComputerSet;
 import hudson.model.Describable;
@@ -37,10 +35,7 @@ import hudson.model.Hudson;
 import hudson.model.Descriptor;
 import hudson.util.DescriptorList;
 
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import java.util.List;
-import java.io.Serializable;
 
 import org.kohsuke.stapler.export.Exported;
 import org.kohsuke.stapler.export.ExportedBean;
@@ -146,6 +141,6 @@ public abstract class NodeMonitor implements ExtensionPoint, Describable<NodeMon
      * Returns all the registered {@link NodeMonitor} descriptors.
      */
     public static DescriptorExtensionList<NodeMonitor,Descriptor<NodeMonitor>> all() {
-        return Hudson.getInstance().getDescriptorList(NodeMonitor.class);
+        return Hudson.getInstance().<NodeMonitor,Descriptor<NodeMonitor>>getDescriptorList(NodeMonitor.class);
     }
 }

core/src/main/java/hudson/scm/SCM.java

@@ -546,7 +546,7 @@ public abstract class SCM implements Describable<SCM>, ExtensionPoint {
      * Returns all the registered {@link SCMDescriptor}s.
      */
     public static DescriptorExtensionList<SCM,SCMDescriptor<?>> all() {
-        return Hudson.getInstance().getDescriptorList(SCM.class);
+        return Hudson.getInstance().<SCM,SCMDescriptor<?>>getDescriptorList(SCM.class);
     }
 
     /**

core/src/main/java/hudson/security/AuthorizationStrategy.java

@@ -170,7 +170,7 @@ public abstract class AuthorizationStrategy extends AbstractDescribableImpl<Auth
      * Returns all the registered {@link AuthorizationStrategy} descriptors.
      */
     public static DescriptorExtensionList<AuthorizationStrategy,Descriptor<AuthorizationStrategy>> all() {
-        return Hudson.getInstance().getDescriptorList(AuthorizationStrategy.class);
+        return Hudson.getInstance().<AuthorizationStrategy,Descriptor<AuthorizationStrategy>>getDescriptorList(AuthorizationStrategy.class);
     }
 
     /**

core/src/main/java/hudson/security/SecurityRealm.java

@@ -498,7 +498,7 @@ public abstract class SecurityRealm extends AbstractDescribableImpl<SecurityReal
      * Returns all the registered {@link SecurityRealm} descriptors.
      */
     public static DescriptorExtensionList<SecurityRealm,Descriptor<SecurityRealm>> all() {
-        return Hudson.getInstance().getDescriptorList(SecurityRealm.class);
+        return Hudson.getInstance().<SecurityRealm,Descriptor<SecurityRealm>>getDescriptorList(SecurityRealm.class);
     }
 
 

core/src/main/java/hudson/security/csrf/CrumbIssuer.java

@@ -146,7 +146,7 @@ public abstract class CrumbIssuer implements Describable<CrumbIssuer>, Extension
      * Returns all the registered {@link CrumbIssuer} descriptors.
      */
     public static DescriptorExtensionList<CrumbIssuer, Descriptor<CrumbIssuer>> all() {
-        return Hudson.getInstance().getDescriptorList(CrumbIssuer.class);
+        return Hudson.getInstance().<CrumbIssuer, Descriptor<CrumbIssuer>>getDescriptorList(CrumbIssuer.class);
     }
 
     public Api getApi() {

core/src/main/java/hudson/slaves/Cloud.java

@@ -137,7 +137,7 @@ public abstract class Cloud extends AbstractModelObject implements ExtensionPoin
      * Returns all the registered {@link Cloud} descriptors.
      */
     public static DescriptorExtensionList<Cloud,Descriptor<Cloud>> all() {
-        return Hudson.getInstance().getDescriptorList(Cloud.class);
+        return Hudson.getInstance().<Cloud,Descriptor<Cloud>>getDescriptorList(Cloud.class);
     }
 
     /**

core/src/main/java/hudson/slaves/NodeDescriptor.java

@@ -29,7 +29,6 @@ import hudson.model.Node;
 import hudson.model.Hudson;
 import hudson.util.DescriptorList;
 import hudson.util.FormValidation;
-import hudson.Extension;
 import hudson.DescriptorExtensionList;
 import hudson.Util;
 
@@ -87,7 +86,7 @@ public abstract class NodeDescriptor extends Descriptor<Node> {
      * Returns all the registered {@link NodeDescriptor} descriptors.
      */
     public static DescriptorExtensionList<Node,NodeDescriptor> all() {
-        return Hudson.getInstance().getDescriptorList(Node.class);
+        return Hudson.getInstance().<Node,NodeDescriptor>getDescriptorList(Node.class);
     }
 
     /**

core/src/main/java/hudson/tasks/BuildWrapper.java

@@ -209,6 +209,6 @@ public abstract class BuildWrapper extends AbstractDescribableImpl<BuildWrapper>
     // for compatibility we can't use BuildWrapperDescriptor
     public static DescriptorExtensionList<BuildWrapper,Descriptor<BuildWrapper>> all() {
         // use getDescriptorList and not getExtensionList to pick up legacy instances
-        return Hudson.getInstance().getDescriptorList(BuildWrapper.class);
+        return Hudson.getInstance().<BuildWrapper,Descriptor<BuildWrapper>>getDescriptorList(BuildWrapper.class);
     }
 }

core/src/main/java/hudson/tasks/Builder.java

@@ -26,15 +26,12 @@ package hudson.tasks;
 import hudson.ExtensionPoint;
 import hudson.Extension;
 import hudson.DescriptorExtensionList;
-import hudson.model.Action;
 import hudson.model.Build;
 import hudson.model.BuildListener;
 import hudson.model.Describable;
-import hudson.model.Project;
 import hudson.model.Descriptor;
 import hudson.model.Hudson;
 
-import java.util.Collection;
 
 /**
  * {@link BuildStep}s that perform the actual build.
@@ -75,6 +72,6 @@ public abstract class Builder extends BuildStepCompatibilityLayer implements Bui
      */
     // for backward compatibility, the signature is not BuildStepDescriptor
     public static DescriptorExtensionList<Builder,Descriptor<Builder>> all() {
-        return Hudson.getInstance().getDescriptorList(Builder.class);
+        return Hudson.getInstance().<Builder,Descriptor<Builder>>getDescriptorList(Builder.class);
     }
 }

core/src/main/java/hudson/tasks/Publisher.java

@@ -26,7 +26,6 @@ package hudson.tasks;
 import hudson.DescriptorExtensionList;
 import hudson.Extension;
 import hudson.ExtensionComponent;
-import hudson.Launcher;
 import hudson.model.Action;
 import hudson.model.Build;
 import hudson.model.BuildListener;
@@ -34,7 +33,6 @@ import hudson.model.Describable;
 import hudson.model.Project;
 import hudson.model.Descriptor;
 import hudson.model.Hudson;
-import hudson.model.AbstractBuild;
 
 import java.util.List;
 import java.util.ArrayList;
@@ -171,6 +169,6 @@ public abstract class Publisher extends BuildStepCompatibilityLayer implements B
      */
     // for backward compatibility, the signature is not BuildStepDescriptor
     public static DescriptorExtensionList<Publisher,Descriptor<Publisher>> all() {
-        return Hudson.getInstance().getDescriptorList(Publisher.class);
+        return Hudson.getInstance().<Publisher,Descriptor<Publisher>>getDescriptorList(Publisher.class);
     }
 }

core/src/main/java/hudson/tasks/junit/TestDataPublisher.java

@@ -55,7 +55,7 @@ public abstract class TestDataPublisher extends AbstractDescribableImpl<TestData
 			BuildListener listener, TestResult testResult) throws IOException, InterruptedException;
 
 	public static DescriptorExtensionList<TestDataPublisher, Descriptor<TestDataPublisher>> all() {
-		return Hudson.getInstance().getDescriptorList(TestDataPublisher.class);
+		return Hudson.getInstance().<TestDataPublisher, Descriptor<TestDataPublisher>>getDescriptorList(TestDataPublisher.class);
 	}
 
 }

core/src/main/java/hudson/tools/ToolInstallation.java

@@ -180,7 +180,7 @@ public abstract class ToolInstallation extends AbstractDescribableImpl<ToolInsta
      */
     public static DescriptorExtensionList<ToolInstallation,ToolDescriptor<?>> all() {
         // use getDescriptorList and not getExtensionList to pick up legacy instances
-        return Hudson.getInstance().getDescriptorList(ToolInstallation.class);
+        return Hudson.getInstance().<ToolInstallation,ToolDescriptor<?>>getDescriptorList(ToolInstallation.class);
     }
 
     private static final long serialVersionUID = 1L;

core/src/main/java/hudson/tools/ToolInstallerDescriptor.java

@@ -48,7 +48,7 @@ public abstract class ToolInstallerDescriptor<T extends ToolInstaller> extends D
     }
 
     public static DescriptorExtensionList<ToolInstaller,ToolInstallerDescriptor<?>> all() {
-        return Hudson.getInstance().getDescriptorList(ToolInstaller.class);
+        return Hudson.getInstance().<ToolInstaller,ToolInstallerDescriptor<?>>getDescriptorList(ToolInstaller.class);
     }
 
     /**

core/src/main/java/hudson/util/DescriptorList.java

@@ -142,7 +142,7 @@ public final class DescriptorList<T extends Describable<T>> extends AbstractList
         if(type==null)
             return legacy;
         else
-            return Hudson.getInstance().getDescriptorList(type);
+            return Hudson.getInstance().<T,Descriptor<T>>getDescriptorList(type);
     }
 
     /**

core/src/main/java/hudson/views/ListViewColumn.java

@@ -24,7 +24,6 @@
 package hudson.views;
 
 import hudson.DescriptorExtensionList;
-import hudson.Extension;
 import hudson.ExtensionPoint;
 import hudson.model.Describable;
 import hudson.model.Descriptor;
@@ -71,7 +70,7 @@ public abstract class ListViewColumn implements ExtensionPoint, Describable<List
      * Returns all the registered {@link ListViewColumn} descriptors.
      */
     public static DescriptorExtensionList<ListViewColumn, Descriptor<ListViewColumn>> all() {
-        return Hudson.getInstance().getDescriptorList(ListViewColumn.class);
+        return Hudson.getInstance().<ListViewColumn, Descriptor<ListViewColumn>>getDescriptorList(ListViewColumn.class);
     }
 
     /**