提交 37f5ac48 编写于 作者: K Kamran Ahmed

Handle non-existing elements

上级 5829a936
......@@ -11,6 +11,7 @@ export default class Overlay {
this.lastSelectedPosition = new Position({});
this.window = window;
this.document = document;
this.prepareContext();
this.setSize();
......@@ -18,7 +19,7 @@ export default class Overlay {
// Prepares the overlay
prepareContext() {
const overlay = document.createElement('canvas');
const overlay = this.document.createElement('canvas');
this.overlay = overlay;
this.context = overlay.getContext('2d');
......@@ -34,7 +35,6 @@ export default class Overlay {
// Highlights the dom element on the screen
highlight(element) {
if (!element) {
// @todo - clearing the overlay
return;
}
......@@ -48,6 +48,10 @@ export default class Overlay {
this.draw();
}
clear() {
this.document.body.removeChild(this.overlay);
}
draw() {
// Reset the overlay
this.context.clearRect(0, 0, this.overlay.width, this.overlay.height);
......@@ -56,15 +60,15 @@ export default class Overlay {
// Cut out the cleared region
this.context.clearRect(
this.selectedPosition.left - window.scrollX,
this.selectedPosition.top - window.scrollY,
this.selectedPosition.left - this.window.scrollX,
this.selectedPosition.top - this.window.scrollY,
(this.selectedPosition.right - this.selectedPosition.left),
(this.selectedPosition.bottom - this.selectedPosition.top),
);
// Append the overlay if not there already
if (!this.overlay.parentNode) {
document.body.appendChild(this.overlay);
this.document.body.appendChild(this.overlay);
}
}
......
......@@ -21,7 +21,11 @@ export default class Sholo {
throw new Error('Element can only be string or the dom element');
}
const element = new Element(domElement);
this.overlay.highlight(element);
if (domElement) {
const element = new Element(domElement);
this.overlay.highlight(element);
} else {
this.overlay.clear();
}
}
}
......@@ -46,6 +46,7 @@
<script>
const nodesToSelect = [
'.section__header',
'asdfsfd',
'.section__how',
'.section__examples'
];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册