upgrade eslint-config (https://github.com/wechaty/wechaty/issues/1917)

bin/io-client.ts

@@ -44,7 +44,7 @@ __________________________________________________
 `
 
 async function main () {
-  let token = config.token
+  const token = config.token
 
   if (!token) {
     throw new Error('token not found: please set WECHATY_TOKEN in environment before run io-client')

package.json

@@ -96,26 +96,23 @@
     "state-switch": "^0.6.2",
     "watchdog": "^0.8.1",
     "wechaty-puppet": "^0.20.1",
-    "wechaty-puppet-hostie": "^0.3.16",
+    "wechaty-puppet-hostie": "^0.3.19",
     "ws": "^7.0.0"
   },
   "devDependencies": {
     "@babel/core": "^7.0.1",
     "@babel/node": "^7.0.0",
     "@babel/preset-env": "^7.0.0",
-    "@chatie/eslint-config": "^0.8.1",
+    "@chatie/eslint-config": "^0.9.1",
     "@chatie/git-scripts": "^0.2.3",
     "@chatie/semver": "^0.4.7",
     "@chatie/tsconfig": "^0.8.0",
-    "@types/blessed": "^0.1.10",
     "@types/cuid": "^1.3.0",
     "@types/glob": "^7.1.1",
-    "@types/mime": "^2.0.0",
     "@types/open-graph": "^0.2.0",
     "@types/promise-retry": "^1.1.3",
     "@types/raven": "^2.1.0",
     "@types/retry": "^0.12.0",
-    "@types/sinon": "^7.0.4",
     "@types/ws": "^7.2.1",
     "apiai": "^4.0.0",
     "check-node-version": "^4.0.1",
@@ -128,7 +125,6 @@
     "nyc": "^15.0.0",
     "qrcode-terminal": "^0.12.0",
     "shx": "^0.3.0",
-    "sinon": "^9.0.0",
     "sloc": "^0.2.0",
     "tstest": "^0.4.1",
     "typedoc": "^0.16.10",

src/doctor.ts

@@ -35,7 +35,7 @@ export class Doctor {
     const spawn = require('child_process').spawnSync
     let version: string
     try {
-      const cmd = spawn('chromedriver', [ '--version' ])
+      const cmd = spawn('chromedriver', ['--version'])
       version = cmd.error || cmd.stdout.toString() || cmd.stderr.toString()
     } catch (e) {
       version = e.message
@@ -49,7 +49,7 @@ export class Doctor {
   public testTcp (): Promise<boolean> {
     log.verbose('Doctor', 'testTcp()')
 
-    return new Promise<boolean>(async (resolve, reject) => {
+    return new Promise<boolean>((resolve, reject) => {
       /**
        * Server
        */

src/helper-functions/pure/xml.spec.ts

@@ -38,6 +38,7 @@ test('stripHtml()', async t => {
 
 test('unescapeHtml()', async t => {
   const HTML_BEFORE_UNESCAPE  = ''|"|>|<|&'
+  // eslint-disable-next-line
   const HTML_AFTER_UNESCAPE   = `'|"|>|<|&`
 
   const unescapedHtml = unescapeHtml(HTML_BEFORE_UNESCAPE)

src/io.ts

@@ -256,20 +256,28 @@ export class Io {
 
     switch (ioEvent.name) {
       case 'botie':
-        const payload = ioEvent.payload
-        if (payload.onMessage) {
-          const script = payload.script
-          try {
-            /* eslint-disable-next-line */
-            const fn = eval(script)
-            if (typeof fn === 'function') {
-              this.onMessage = fn
-            } else {
-              log.warn('Io', 'server pushed function is invalid')
+        {
+          const payload = ioEvent.payload
+          if (payload.onMessage) {
+            const script = payload.script
+            try {
+              /**
+                 * https://github.com/Chatie/botie/issues/2
+                 *  const AsyncFunction = Object.getPrototypeOf(async () => {}).constructor
+                 *  const fn = new AsyncFunction('require', 'github', 'context', script)
+                 */
+              // eslint-disable-next-line
+              const fn = eval(script)
+
+              if (typeof fn === 'function') {
+                this.onMessage = fn
+              } else {
+                log.warn('Io', 'server pushed function is invalid')
+              }
+            } catch (e) {
+              log.warn('Io', 'server pushed function exception: %s', e)
+              this.options.wechaty.emit('error', e)
             }
-          } catch (e) {
-            log.warn('Io', 'server pushed function exception: %s', e)
-            this.options.wechaty.emit('error', e)
           }
         }
         break
@@ -287,25 +295,26 @@ export class Io {
 
       case 'update':
         log.verbose('Io', 'on(update): %s', ioEvent.payload)
-
-        const wechaty = this.options.wechaty
-        if (wechaty.logonoff()) {
-          const loginEvent: IoEvent = {
-            name    : 'login',
-            payload : {
-              id   : wechaty.userSelf().id,
-              name : wechaty.userSelf().name(),
-            },
+        {
+          const wechaty = this.options.wechaty
+          if (wechaty.logonoff()) {
+            const loginEvent: IoEvent = {
+              name    : 'login',
+              payload : {
+                id   : wechaty.userSelf().id,
+                name : wechaty.userSelf().name(),
+              },
+            }
+            await this.send(loginEvent)
           }
-          await this.send(loginEvent)
-        }
 
-        if (this.scanPayload) {
-          const scanEvent: IoEventScan = {
-            name:     'scan',
-            payload:  this.scanPayload,
+          if (this.scanPayload) {
+            const scanEvent: IoEventScan = {
+              name:     'scan',
+              payload:  this.scanPayload,
+            }
+            await this.send(scanEvent)
           }
-          await this.send(scanEvent)
         }
 
         break

src/puppet-manager.ts

@@ -192,9 +192,9 @@ export class PuppetManager {
     }
 
     // https://github.com/GoogleChrome/puppeteer/issues/1597#issuecomment-351945645
-    if (gfw && !process.env['PUPPETEER_DOWNLOAD_HOST']) {
+    if (gfw && !process.env.PUPPETEER_DOWNLOAD_HOST) {
       log.info('PuppetManager', 'preInstallPuppeteer() set PUPPETEER_DOWNLOAD_HOST=https://npm.taobao.org/mirrors/')
-      process.env['PUPPETEER_DOWNLOAD_HOST'] = 'https://npm.taobao.org/mirrors/'
+      process.env.PUPPETEER_DOWNLOAD_HOST = 'https://npm.taobao.org/mirrors/'
     }
   }
 

src/user/contact.ts

@@ -63,6 +63,7 @@ export class Contact extends Accessory implements Sayable {
   protected static get pool () {
     return this[POOL]
   }
+
   protected static set pool (newPool: Map<string, Contact>) {
     if (this === Contact) {
       throw new Error(
@@ -753,7 +754,7 @@ export class Contact extends Accessory implements Sayable {
       // log.silly('Contact', `ready() this.puppet.contactPayload(%s) resolved`, this)
 
     } catch (e) {
-      log.verbose('Contact', `ready() this.puppet.contactPayload(%s) exception: %s`,
+      log.verbose('Contact', 'ready() this.puppet.contactPayload(%s) exception: %s',
         this.id,
         e.message,
       )

src/user/message.spec.ts

@@ -78,7 +78,7 @@ test('recalled()', async t => {
 
   sandbox.stub(puppet, 'roomMemberList').callsFake(async () => {
     await new Promise((resolve) => setImmediate(resolve))
-    return [ EXPECTED_FROM_CONTACT_ID, EXPECTED_TO_CONTACT_ID ]
+    return [EXPECTED_FROM_CONTACT_ID, EXPECTED_TO_CONTACT_ID]
   })
 
   sandbox.stub(puppet, 'contactPayload').callsFake(async (id: string) => {

src/user/room-invitation.ts

@@ -309,7 +309,7 @@ export class RoomInvitation extends Accessory implements Acceptable {
    * .start()
    */
   public async toJSON (): Promise<string> {
-    log.verbose('RoomInvitation', `toJSON()`)
+    log.verbose('RoomInvitation', 'toJSON()')
     const payload = await this.puppet.roomInvitationPayload(this.id)
     return JSON.stringify(payload)
   }

src/user/room.ts

@@ -614,7 +614,7 @@ export class Room extends Accessory implements Sayable {
       const textListLength = textList.length
       const varListLength  = varList.length
       if (textListLength - varListLength !== 1) {
-        throw new Error(`Can not say message, invalid Templated String Array.`)
+        throw new Error('Can not say message, invalid Templated String Array.')
       }
       let finalText = ''
 

src/wechaty.ts

@@ -93,7 +93,7 @@ import {
 export const WECHATY_EVENT_DICT = {
   ...CHAT_EVENT_DICT,
   dong      : 'Should be emitted after we call `Wechaty.ding()`',
-  error     : `Will be emit when there's an Error occurred.`,
+  error     : "Will be emit when there's an Error occurred.",
   heartbeat : 'Will be emited periodly after the Wechaty started. If not, means that the Wechaty had died.',
   ready     : 'All underlined data source are ready for use.',
   start     : 'Will be emitted after the Wechaty had been started.',
@@ -505,11 +505,11 @@ export class Wechaty extends Accessory implements Sayable {
 
     // DEPRECATED for 'friend' event
     if (event as any === 'friend') {
-      log.warn('Wechaty', `on('friend', contact, friendRequest) is DEPRECATED. use on('friendship', friendship) instead`)
+      log.warn('Wechaty', "on('friend', contact, friendRequest) is DEPRECATED. use on('friendship', friendship) instead")
       if (typeof listener === 'function') {
         const oldListener = listener
         listener = (...args: any[]) => {
-          log.warn('Wechaty', `on('friend', contact, friendRequest) is DEPRECATED. use on('friendship', friendship) instead`)
+          log.warn('Wechaty', "on('friend', contact, friendRequest) is DEPRECATED. use on('friendship', friendship) instead")
           oldListener.apply(this, args)
         }
       }