Merge pull request #4738 from josedonizetti/move-supported-drivers-per-platform

Move supported drivers per platform

Makefile

@@ -289,7 +289,7 @@ mdlint:
 	@$(MARKDOWNLINT) $(MINIKUBE_MARKDOWN_FILES)
 
 out/docs/minikube.md: $(shell find cmd) $(shell find pkg/minikube/constants) pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go
-	go run -ldflags="$(MINIKUBE_LDFLAGS)" hack/help_text/gen_help_text.go
+	go run -ldflags="$(MINIKUBE_LDFLAGS)" -tags gendocs hack/help_text/gen_help_text.go
 
 out/minikube_$(DEB_VERSION).deb: out/minikube-linux-amd64
 	cp -r installers/linux/deb/minikube_deb_template out/minikube_$(DEB_VERSION)

pkg/minikube/constants/constants.go

@@ -89,21 +89,6 @@ const DriverXhyve = "xhyve"
 // DriverParallels is the parallels driver option name
 const DriverParallels = "parallels"
 
-// SupportedVMDrivers is a list of supported drivers on all platforms. Currently
-// used in gendocs.
-var SupportedVMDrivers = [...]string{
-	DriverVirtualbox,
-	DriverParallels,
-	DriverVmwareFusion,
-	DriverKvmOld,
-	DriverXhyve,
-	DriverHyperv,
-	DriverHyperkit,
-	DriverKvm2,
-	DriverVmware,
-	DriverNone,
-}
-
 // DefaultMinipath is the default Minikube path (under the home directory)
 var DefaultMinipath = filepath.Join(homedir.HomeDir(), ".minikube")
 

pkg/minikube/constants/constants_darwin.go

-// +build darwin
+// +build darwin, !gendocs
 
 /*
 Copyright 2016 The Kubernetes Authors All rights reserved.
@@ -19,3 +19,13 @@ limitations under the License.
 package constants
 
 var DefaultMountDir = "/Users"
+
+// SupportedVMDrivers is a list of supported drivers on Darwin.
+var SupportedVMDrivers = [...]string{
+	DriverVirtualbox,
+	DriverParallels,
+	DriverVmwareFusion,
+	DriverXhyve,
+	DriverHyperKit,
+	DriverVmware,
+}

pkg/minikube/constants/constants_gendocs.go

+// +build gendocs
+
+/*
+Copyright 2016 The Kubernetes Authors All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package constants
+
+var DefaultMountDir = "$HOME"
+
+// SupportedVMDrivers is a list of supported drivers on all platforms.
+var SupportedVMDrivers = [...]string{
+	DriverVirtualbox,
+	DriverParallels,
+	DriverVmwareFusion,
+	DriverKvmOld,
+	DriverXhyve,
+	DriverHyperv,
+	DriverHyperkit,
+	DriverKvm2,
+	DriverVmware,
+	DriverNone,
+}

pkg/minikube/constants/constants_linux.go

-// +build linux
+// +build linux, !gendocs
 
 /*
 Copyright 2016 The Kubernetes Authors All rights reserved.
@@ -24,3 +24,14 @@ import (
 
 // DefaultMountDir is the default mount dir
 var DefaultMountDir = homedir.HomeDir()
+
+// SupportedVMDrivers is a list of supported drivers on Linux.
+var SupportedVMDrivers = [...]string{
+	DriverVirtualbox,
+	DriverParallels,
+	DriverVmwareFusion,
+	DriverKvmOld,
+	DriverKvm2,
+	DriverVmware,
+	DriverNone,
+}

pkg/minikube/constants/constants_windows.go

-// +build windows
+// +build windows, !gendocs
 
 /*
 Copyright 2016 The Kubernetes Authors All rights reserved.
@@ -23,3 +23,11 @@ import (
 )
 
 var DefaultMountDir = homedir.HomeDir()
+
+// SupportedVMDrivers is a list of supported drivers on Windows.
+var SupportedVMDrivers = [...]string{
+	DriverVirtualbox,
+	DriverVmwareFusion,
+	DriverHyperv,
+	DriverVmware,
+}