Merge pull request #4076 from sharifelgamal/4010

Avoid surfacing "error: no objects passed to apply" non-error from addon-manager

pkg/minikube/logs/logs.go

@@ -35,6 +35,9 @@ import (
 // rootCauseRe is a regular expression that matches known failure root causes
 var rootCauseRe = regexp.MustCompile(`^error: |eviction manager: pods.* evicted|unknown flag: --|forbidden.*no providers available|eviction manager:.*evicted`)
 
+// ignoreRe is a regular expression that matches spurious errors to not surface
+var ignoreCauseRe = regexp.MustCompile("error: no objects passed to apply")
+
 // importantPods are a list of pods to retrieve logs for, in addition to the bootstrapper logs.
 var importantPods = []string{
 	"kube-apiserver",
@@ -62,7 +65,7 @@ func Follow(r cruntime.Manager, bs bootstrapper.Bootstrapper, runner bootstrappe
 
 // IsProblem returns whether this line matches a known problem
 func IsProblem(line string) bool {
-	return rootCauseRe.MatchString(line)
+	return rootCauseRe.MatchString(line) && !ignoreCauseRe.MatchString(line)
 }
 
 // FindProblems finds possible root causes among the logs

pkg/minikube/logs/logs_test.go

@@ -33,6 +33,7 @@ func TestIsProblem(t *testing.T) {
 		{"apiserver-auth-mode #2852", true, `{"log":"Error: unknown flag: --Authorization.Mode\n","stream":"stderr","time":"2018-06-17T22:16:35.134161966Z"}`},
 		{"apiserver-admission #3524", true, "error: unknown flag: --GenericServerRunOptions.AdmissionControl"},
 		{"no-providers-available #3818", true, ` kubelet.go:1662] Failed creating a mirror pod for "kube-apiserver-minikube_kube-system(c7d572aebd3d33b17fa78ae6395b6d0a)": pods "kube-apiserver-minikube" is forbidden: no providers available to validate pod request`},
+		{"no-objects-passed-to-apply #4010", false, "error: no objects passed to apply"},
 	}
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {