@@ -32,8 +32,8 @@ You can also achieve persistence by creating a PV in a mounted host folder.
## Dynamic provisioning and CSI
In addition, minikube implements a very simple, canonical implementation of dynamic storage controller that runs alongside its deployment. This manages provisioning of *hostPath* volumes (rather then via the previous, in-tree hostPath provider).
In addition, minikube implements a very simple, canonical implementation of dynamic storage controller that runs alongside its deployment. This manages provisioning of *hostPath* volumes (rather then via the previous, in-tree hostPath provider).
The default [Storage Provisioner Controller](https://github.com/kubernetes/minikube/blob/master/pkg/storage/storage_provisioner.go) is managed internally, in the minikube codebase, demonstrating how easy it is to plug a custom storage controller into kubernetes as a storage component of the system, and provides pods with dynamically, to test your pod's behaviour when persistent storage is mapped to it.
Note that this is not a CSI based storage provider, rather, it simply declares a PersistentVolume object of type hostpath dynamically when the controller see's that there is an outstanding storage request.
NOTE: this is not a CSI based storage provider. It simply declares an appropriate PersistentVolume in response to an incoming storage request.
@@ -17,15 +17,16 @@ We'd love to accept your patches! Before we can take them, [please fill out eith
### Finding issues to work on
*["good first issue"](https://github.com/kubernetes/minikube/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) - issues where there is a clear path to resolution
*["help wanted"](https://github.com/kubernetes/minikube/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+) - any issue where we've identified a need, but not the resources to work on it.
* High impact issues are labelled as *priority/important-soon* or *priority/important-longterm*
*["help wanted"](https://github.com/kubernetes/minikube/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+) - issues where we've identified a need but not resources to work on them
"priority/important-soon" or "priority/important-longterm: - high impact issues that need to be addressed in the next couple of releases.
* Ask on the #minikube Slack if you aren't sure
Once you've discovered an issue to work on:
*add a comment mentioning that you plan to work on the issue
*send a PR out that mentions the issue
*Once there is a PR, comment on the issue with `/assign` to assign it to yourself
*Add a comment mentioning that you plan to work on the issue
*Send a PR out that mentions the issue
*Comment on the issue with `/assign` to assign it to yourself