Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Chu Peng 楚鹏
minikube
提交
4f6a9f65
M
minikube
项目概览
Chu Peng 楚鹏
/
minikube
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
M
minikube
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
4f6a9f65
编写于
6月 23, 2020
作者:
M
Medya Ghazizadeh
提交者:
GitHub
6月 23, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #8518 from afbjorklund/docker-containerd
Make sure to use internal containerd for docker
上级
b1c26a2d
4027ba49
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
57 addition
and
21 deletion
+57
-21
pkg/minikube/cruntime/cruntime_test.go
pkg/minikube/cruntime/cruntime_test.go
+50
-21
pkg/minikube/cruntime/docker.go
pkg/minikube/cruntime/docker.go
+7
-0
未找到文件。
pkg/minikube/cruntime/cruntime_test.go
浏览文件 @
4f6a9f65
...
...
@@ -478,6 +478,16 @@ func (f *FakeRunner) systemctl(args []string, root bool) (string, error) { // no
return
out
,
nil
}
return
out
,
fmt
.
Errorf
(
"%s in state: %v"
,
svc
,
state
)
case
"cat"
:
f
.
t
.
Logf
(
"fake systemctl: %s cat: %v"
,
svc
,
state
)
if
svc
==
"docker.service"
{
out
+=
"[Unit]
\n
"
out
+=
"Description=Docker Application Container Engine
\n
"
out
+=
"Documentation=https://docs.docker.com
\n
"
//out += "BindsTo=containerd.service\n"
return
out
,
nil
}
return
out
,
fmt
.
Errorf
(
"%s cat unimplemented"
,
svc
)
default
:
return
out
,
fmt
.
Errorf
(
"unimplemented fake action: %q"
,
action
)
}
...
...
@@ -526,6 +536,14 @@ var defaultServices = map[string]serviceState{
"containerd"
:
SvcExited
,
}
// allServices reflects the state of all actual services running at once
var
allServices
=
map
[
string
]
serviceState
{
"docker"
:
SvcRunning
,
"crio"
:
SvcRunning
,
"crio-shutdown"
:
SvcExited
,
"containerd"
:
SvcRunning
,
}
func
TestDisable
(
t
*
testing
.
T
)
{
var
tests
=
[]
struct
{
runtime
string
...
...
@@ -558,32 +576,43 @@ func TestDisable(t *testing.T) {
func
TestEnable
(
t
*
testing
.
T
)
{
var
tests
=
[]
struct
{
runtime
string
want
map
[
string
]
serviceState
runtime
string
services
map
[
string
]
serviceState
want
map
[
string
]
serviceState
}{
{
"docker"
,
map
[
string
]
serviceState
{
"docker"
:
SvcRunning
,
"containerd"
:
SvcExited
,
"crio"
:
SvcExited
,
"crio-shutdown"
:
SvcExited
,
}},
{
"containerd"
,
map
[
string
]
serviceState
{
"docker"
:
SvcExited
,
"containerd"
:
SvcRestarted
,
"crio"
:
SvcExited
,
"crio-shutdown"
:
SvcExited
,
}},
{
"crio"
,
map
[
string
]
serviceState
{
"docker"
:
SvcExited
,
"containerd"
:
SvcExited
,
"crio"
:
SvcRunning
,
"crio-shutdown"
:
SvcExited
,
}},
{
"docker"
,
defaultServices
,
map
[
string
]
serviceState
{
"docker"
:
SvcRunning
,
"containerd"
:
SvcExited
,
"crio"
:
SvcExited
,
"crio-shutdown"
:
SvcExited
,
}},
{
"docker"
,
allServices
,
map
[
string
]
serviceState
{
"docker"
:
SvcRestarted
,
"containerd"
:
SvcExited
,
"crio"
:
SvcExited
,
"crio-shutdown"
:
SvcExited
,
}},
{
"containerd"
,
defaultServices
,
map
[
string
]
serviceState
{
"docker"
:
SvcExited
,
"containerd"
:
SvcRestarted
,
"crio"
:
SvcExited
,
"crio-shutdown"
:
SvcExited
,
}},
{
"crio"
,
defaultServices
,
map
[
string
]
serviceState
{
"docker"
:
SvcExited
,
"containerd"
:
SvcExited
,
"crio"
:
SvcRunning
,
"crio-shutdown"
:
SvcExited
,
}},
}
for
_
,
tc
:=
range
tests
{
t
.
Run
(
tc
.
runtime
,
func
(
t
*
testing
.
T
)
{
runner
:=
NewFakeRunner
(
t
)
for
k
,
v
:=
range
defaultS
ervices
{
for
k
,
v
:=
range
tc
.
s
ervices
{
runner
.
services
[
k
]
=
v
}
cr
,
err
:=
New
(
Config
{
Type
:
tc
.
runtime
,
Runner
:
runner
})
...
...
pkg/minikube/cruntime/docker.go
浏览文件 @
4f6a9f65
...
...
@@ -104,6 +104,8 @@ func (r *Docker) Active() bool {
// Enable idempotently enables Docker on a host
func
(
r
*
Docker
)
Enable
(
disOthers
,
forceSystemd
bool
)
error
{
containerdWasActive
:=
r
.
Init
.
Active
(
"containerd"
)
if
disOthers
{
if
err
:=
disableOthers
(
r
,
r
.
Runner
);
err
!=
nil
{
glog
.
Warningf
(
"disableOthers: %v"
,
err
)
...
...
@@ -117,6 +119,11 @@ func (r *Docker) Enable(disOthers, forceSystemd bool) error {
return
r
.
Init
.
Restart
(
"docker"
)
}
if
containerdWasActive
&&
!
dockerBoundToContainerd
(
r
.
Runner
)
{
// Make sure to use the internal containerd
return
r
.
Init
.
Restart
(
"docker"
)
}
return
r
.
Init
.
Start
(
"docker"
)
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录