functional_test.go 32.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
// +build integration

/*
Copyright 2016 The Kubernetes Authors All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package integration

import (
22 23 24 25 26 27 28 29 30
	"bytes"
	"context"
	"encoding/json"
	"fmt"
	"io/ioutil"
	"net/http"
	"net/url"
	"os"
	"os/exec"
31
	"path"
32
	"path/filepath"
33
	"regexp"
T
tstromberg 已提交
34
	"runtime"
35
	"strings"
36
	"testing"
37 38
	"time"

39 40
	"github.com/google/go-cmp/cmp"

M
Medya Gh 已提交
41
	"k8s.io/minikube/pkg/minikube/config"
42 43
	"k8s.io/minikube/pkg/minikube/localpath"

44 45
	"github.com/elazarl/goproxy"
	"github.com/hashicorp/go-retryablehttp"
46
	"github.com/otiai10/copy"
47 48 49
	"github.com/phayes/freeport"
	"github.com/pkg/errors"
	"golang.org/x/build/kubernetes/api"
M
Medya Gh 已提交
50
	"k8s.io/minikube/pkg/minikube/config"
51
	"k8s.io/minikube/pkg/util/retry"
52 53
)

54 55 56 57
// validateFunc are for subtests that share a single setup
type validateFunc func(context.Context, *testing.T, string)

// TestFunctional are functionality tests which can safely share a profile in parallel
N
Nick Kubala 已提交
58
func TestFunctional(t *testing.T) {
59 60

	profile := UniqueProfileName("functional")
M
Medya Gh 已提交
61
	ctx, cancel := context.WithTimeout(context.Background(), Minutes(40))
62
	defer func() {
63 64 65
		if !*cleanup {
			return
		}
66 67
		p := localSyncTestPath()
		if err := os.Remove(p); err != nil {
68
			t.Logf("unable to remove %q: %v", p, err)
69
		}
70 71
		p = localTestCertPath()
		if err := os.Remove(p); err != nil {
72
			t.Logf("unable to remove %q: %v", p, err)
73
		}
74 75
		CleanupWithLogs(t, profile, cancel)
	}()
76 77 78 79 80 81 82

	// Serial tests
	t.Run("serial", func(t *testing.T) {
		tests := []struct {
			name      string
			validator validateFunc
		}{
83 84
			{"CopySyncFile", setupFileSync},                 // Set file for the file sync test case
			{"StartWithProxy", validateStartWithProxy},      // Set everything else up for success
M
Medya Gh 已提交
85
			{"SoftStart", validateSoftStart},                // do a soft start. ensure config didnt change.
86 87 88 89
			{"KubeContext", validateKubeContext},            // Racy: must come immediately after "minikube start"
			{"KubectlGetPods", validateKubectlGetPods},      // Make sure apiserver is up
			{"CacheCmd", validateCacheCmd},                  // Caches images needed for subsequent tests because of proxy
			{"MinikubeKubectlCmd", validateMinikubeKubectl}, // Make sure `minikube kubectl` works
90 91 92 93
		}
		for _, tc := range tests {
			tc := tc
			t.Run(tc.name, func(t *testing.T) {
M
Medya Gh 已提交
94 95 96 97 98 99
				if strings.Contains(tc.name, "StartWithProxy") || strings.Contains(tc.name, "SoftStart") {
					tc.validator(ctx, t, profile, 8441)
				} else {
					tc.validator(ctx, t, profile)
				}

100
			})
M
Medya Gh 已提交
101
		}
102
	})
M
Medya Gh 已提交
103

104 105 106 107 108 109 110 111 112 113 114 115 116
	// Now that we are out of the woods, lets go.
	MaybeParallel(t)

	// Parallelized tests
	t.Run("parallel", func(t *testing.T) {
		tests := []struct {
			name      string
			validator validateFunc
		}{
			{"ComponentHealth", validateComponentHealth},
			{"ConfigCmd", validateConfigCmd},
			{"DashboardCmd", validateDashboardCmd},
			{"DNS", validateDNS},
T
Thomas Stromberg 已提交
117
			{"DryRun", validateDryRun},
J
Josh Woodcock 已提交
118
			{"StatusCmd", validateStatusCmd},
119 120 121
			{"LogsCmd", validateLogsCmd},
			{"MountCmd", validateMountCmd},
			{"ProfileCmd", validateProfileCmd},
122
			{"ServiceCmd", validateServiceCmd},
123
			{"AddonsCmd", validateAddonsCmd},
124 125 126
			{"PersistentVolumeClaim", validatePersistentVolumeClaim},
			{"TunnelCmd", validateTunnelCmd},
			{"SSHCmd", validateSSHCmd},
127
			{"MySQL", validateMySQL},
128
			{"FileSync", validateFileSync},
129
			{"CertSync", validateCertSync},
130
			{"UpdateContextCmd", validateUpdateContextCmd},
131
			{"DockerEnv", validateDockerEnv},
M
Medya Gh 已提交
132
			{"NodeLabels", validateNodeLabels},
133 134 135 136 137 138 139 140
		}
		for _, tc := range tests {
			tc := tc
			t.Run(tc.name, func(t *testing.T) {
				MaybeParallel(t)
				tc.validator(ctx, t, profile)
			})
		}
M
Medya Gh 已提交
141
	})
142 143
}

M
Medya Gh 已提交
144 145
// validateNodeLabels checks if minikube cluster is created with correct kubernetes's node label
func validateNodeLabels(ctx context.Context, t *testing.T, profile string) {
M
Medya Gh 已提交
146
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "get", "nodes", "--output=go-template", "--template='{{range $k, $v := (index .items 0).metadata.labels}}{{$k}} {{end}}'"))
M
Medya Gh 已提交
147
	if err != nil {
M
Medya Gh 已提交
148
		t.Errorf("failed to 'kubectl get nodes' with args %q: %v", rr.Command(), err)
M
Medya Gh 已提交
149 150 151
	}
	expectedLabels := []string{"minikube.k8s.io/commit", "minikube.k8s.io/version", "minikube.k8s.io/updated_at", "minikube.k8s.io/name"}
	for _, el := range expectedLabels {
M
Medya Gh 已提交
152
		if !strings.Contains(rr.Output(), el) {
M
Medya Gh 已提交
153
			t.Errorf("expected to have label %q in node labels but got : %s", el, rr.Output())
M
Medya Gh 已提交
154 155 156 157
		}
	}
}

158 159
// check functionality of minikube after evaling docker-env
func validateDockerEnv(ctx context.Context, t *testing.T, profile string) {
M
Medya Gh 已提交
160
	mctx, cancel := context.WithTimeout(ctx, Seconds(13))
161 162 163 164 165
	defer cancel()
	// we should be able to get minikube status with a bash which evaled docker-env
	c := exec.CommandContext(mctx, "/bin/bash", "-c", "eval $("+Target()+" -p "+profile+" docker-env) && "+Target()+" status -p "+profile)
	rr, err := Run(t, c)
	if err != nil {
166
		t.Fatalf("failed to do minikube status after eval-ing docker-env %s", err)
167 168
	}
	if !strings.Contains(rr.Output(), "Running") {
M
Medya Gh 已提交
169
		t.Fatalf("expected status output to include 'Running' after eval docker-env but got: *%s*", rr.Output())
170 171
	}

M
Medya Gh 已提交
172
	mctx, cancel = context.WithTimeout(ctx, Seconds(13))
173 174 175 176 177
	defer cancel()
	// do a eval $(minikube -p profile docker-env) and check if we are point to docker inside minikube
	c = exec.CommandContext(mctx, "/bin/bash", "-c", "eval $("+Target()+" -p "+profile+" docker-env) && docker images")
	rr, err = Run(t, c)
	if err != nil {
M
Medya Gh 已提交
178
		t.Fatalf("failed to run minikube docker-env. args %q : %v ", rr.Command(), err)
179 180 181 182
	}

	expectedImgInside := "gcr.io/k8s-minikube/storage-provisioner"
	if !strings.Contains(rr.Output(), expectedImgInside) {
M
Medya Gh 已提交
183
		t.Fatalf("expected 'docker images' to have %q inside minikube. but the output is: *%s*", expectedImgInside, rr.Output())
184 185 186 187
	}

}

M
Medya Gh 已提交
188
func validateStartWithProxy(ctx context.Context, t *testing.T, profile string, apiServerPort int) {
189 190
	srv, err := startHTTPProxy(t)
	if err != nil {
191
		t.Fatalf("failed to set up the test proxy: %s", err)
192
	}
193 194

	// Use more memory so that we may reliably fit MySQL and nginx
M
Medya Gh 已提交
195 196
	// changing api server so later in soft start we verify it didn't change
	startArgs := append([]string{"start", "-p", profile, fmt.Sprintf("--apiserver-port=%d", apiServerPort), "--wait=true"}, StartArgs()...)
197
	c := exec.CommandContext(ctx, Target(), startArgs...)
198 199 200 201 202 203
	env := os.Environ()
	env = append(env, fmt.Sprintf("HTTP_PROXY=%s", srv.Addr))
	env = append(env, "NO_PROXY=")
	c.Env = env
	rr, err := Run(t, c)
	if err != nil {
M
Medya Gh 已提交
204
		t.Errorf("failed minikube start. args %q: %v", rr.Command(), err)
205 206 207 208 209 210 211 212 213 214 215 216 217
	}

	want := "Found network options:"
	if !strings.Contains(rr.Stdout.String(), want) {
		t.Errorf("start stdout=%s, want: *%s*", rr.Stdout.String(), want)
	}

	want = "You appear to be using a proxy"
	if !strings.Contains(rr.Stderr.String(), want) {
		t.Errorf("start stderr=%s, want: *%s*", rr.Stderr.String(), want)
	}
}

M
Medya Gh 已提交
218 219
// validateSoftStart validates that after minikube already started, a "minikube start" should not change the configs.
func validateSoftStart(ctx context.Context, t *testing.T, profile string, apiPortBefore int) {
M
Medya Gh 已提交
220
	start := time.Now()
M
Medya Gh 已提交
221
	// the test before this had been start with --apiserver-port=8441
M
Medya Gh 已提交
222 223 224 225 226 227 228 229 230 231
	beforeCfg := config.LoadProfile(profile)
	if beforeCfg.Config.NodePort != apiPortBefore {
		t.Errorf("expected cluster config node port before soft start to be %d but got %s", apiPortBefore, beforeCfg.Config.NodePort)
	}

	softStartArgs := append([]string{"start", "-p", profile})
	c := exec.CommandContext(ctx, Target(), softStartArgs...)
	if err != nil {
		t.Errorf("failed to soft start minikube. args %q: %v", rr.Command(), err)
	}
M
Medya Gh 已提交
232
	t.Logf("soft start took %s for %q cluster.", time.Since(start), profile)
M
Medya Gh 已提交
233 234 235 236 237

	afterCfg := config.LoadProfile(profile)
	if afterCfg.Config.NodePort != apiPortBefore {
		t.Errorf("expected node port in the config not change after soft start. exepceted node port to be %d but got %d.", apiPortBefore, afterCfg.Config.NodePort)
	}
M
Medya Gh 已提交
238

M
Medya Gh 已提交
239 240
}

241 242 243 244
// validateKubeContext asserts that kubectl is properly configured (race-condition prone!)
func validateKubeContext(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "config", "current-context"))
	if err != nil {
M
Medya Gh 已提交
245
		t.Errorf("failed to get current-context. args %q : %v", rr.Command(), err)
246 247
	}
	if !strings.Contains(rr.Stdout.String(), profile) {
248
		t.Errorf("expected current-context = %q, but got *%q*", profile, rr.Stdout.String())
249 250 251
	}
}

P
Priya Wadhwa 已提交
252 253
// validateKubectlGetPods asserts that `kubectl get pod -A` returns non-zero content
func validateKubectlGetPods(ctx context.Context, t *testing.T, profile string) {
254
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "get", "po", "-A"))
P
Priya Wadhwa 已提交
255
	if err != nil {
M
Medya Gh 已提交
256
		t.Errorf("failed to get kubectl pods: args %q : %v", rr.Command(), err)
P
Priya Wadhwa 已提交
257
	}
258
	if rr.Stderr.String() != "" {
259
		t.Errorf("expected stderr to be empty but got *%q*: args %q", rr.Stderr, rr.Command())
260
	}
T
Thomas Stromberg 已提交
261
	if !strings.Contains(rr.Stdout.String(), "kube-system") {
262
		t.Errorf("expected stdout to include *kube-system* but got *%q*. args: %q", rr.Stdout, rr.Command())
P
Priya Wadhwa 已提交
263 264 265
	}
}

266 267
// validateMinikubeKubectl validates that the `minikube kubectl` command returns content
func validateMinikubeKubectl(ctx context.Context, t *testing.T, profile string) {
268 269
	// Must set the profile so that it knows what version of Kubernetes to use
	kubectlArgs := []string{"-p", profile, "kubectl", "--", "--context", profile, "get", "pods"}
P
Priya Wadhwa 已提交
270
	rr, err := Run(t, exec.CommandContext(ctx, Target(), kubectlArgs...))
271
	if err != nil {
M
Medya Gh 已提交
272
		t.Fatalf("failed to get pods. args %q: %v", rr.Command(), err)
273 274 275
	}
}

276 277 278 279
// validateComponentHealth asserts that all Kubernetes components are healthy
func validateComponentHealth(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "get", "cs", "-o=json"))
	if err != nil {
M
Medya Gh 已提交
280
		t.Fatalf("failed to get components. args %q: %v", rr.Command(), err)
281 282 283 284
	}
	cs := api.ComponentStatusList{}
	d := json.NewDecoder(bytes.NewReader(rr.Stdout.Bytes()))
	if err := d.Decode(&cs); err != nil {
M
Medya Gh 已提交
285
		t.Fatalf("failed to decode kubectl json output: args %q : %v", rr.Command(), err)
286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
	}

	for _, i := range cs.Items {
		status := api.ConditionFalse
		for _, c := range i.Conditions {
			if c.Type != api.ComponentHealthy {
				continue
			}
			status = c.Status
		}
		if status != api.ConditionTrue {
			t.Errorf("unexpected status: %v - item: %+v", status, i)
		}
	}
}

J
Josh Woodcock 已提交
302
func validateStatusCmd(ctx context.Context, t *testing.T, profile string) {
303
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "status"))
J
Josh Woodcock 已提交
304
	if err != nil {
M
Medya Gh 已提交
305
		t.Errorf("failed to run minikube status. args %q : %v", rr.Command(), err)
J
Josh Woodcock 已提交
306 307 308
	}

	// Custom format
309
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "status", "-f", "host:{{.Host}},kublet:{{.Kubelet}},apiserver:{{.APIServer}},kubeconfig:{{.Kubeconfig}}"))
J
Josh Woodcock 已提交
310
	if err != nil {
M
Medya Gh 已提交
311
		t.Errorf("failed to run minikube status with custom format: args %q: %v", rr.Command(), err)
J
Josh Woodcock 已提交
312
	}
313 314
	re := `host:([A-z]+),kublet:([A-z]+),apiserver:([A-z]+),kubeconfig:([A-z]+)`
	match, _ := regexp.MatchString(re, rr.Stdout.String())
J
Josh Woodcock 已提交
315
	if !match {
M
Medya Gh 已提交
316
		t.Errorf("failed to match regex %q for minikube status with custom format. args %q. output: %s", re, rr.Command(), rr.Output())
J
Josh Woodcock 已提交
317 318 319
	}

	// Json output
320
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "status", "-o", "json"))
J
Josh Woodcock 已提交
321
	if err != nil {
M
Medya Gh 已提交
322
		t.Errorf("failed to run minikube status with json output. args %q : %v", rr.Command(), err)
J
Josh Woodcock 已提交
323 324 325 326
	}
	var jsonObject map[string]interface{}
	err = json.Unmarshal(rr.Stdout.Bytes(), &jsonObject)
	if err != nil {
M
Medya Gh 已提交
327
		t.Errorf("failed to decode json from minikube status. args %q. %v", rr.Command(), err)
J
Josh Woodcock 已提交
328 329
	}
	if _, ok := jsonObject["Host"]; !ok {
M
Medya Gh 已提交
330
		t.Errorf("%q failed: %v. Missing key %s in json object", rr.Command(), err, "Host")
J
Josh Woodcock 已提交
331 332
	}
	if _, ok := jsonObject["Kubelet"]; !ok {
M
Medya Gh 已提交
333
		t.Errorf("%q failed: %v. Missing key %s in json object", rr.Command(), err, "Kubelet")
J
Josh Woodcock 已提交
334 335
	}
	if _, ok := jsonObject["APIServer"]; !ok {
M
Medya Gh 已提交
336
		t.Errorf("%q failed: %v. Missing key %s in json object", rr.Command(), err, "APIServer")
J
Josh Woodcock 已提交
337 338
	}
	if _, ok := jsonObject["Kubeconfig"]; !ok {
M
Medya Gh 已提交
339
		t.Errorf("%q failed: %v. Missing key %s in json object", rr.Command(), err, "Kubeconfig")
J
Josh Woodcock 已提交
340 341 342
	}
}

343 344 345 346 347
// validateDashboardCmd asserts that the dashboard command works
func validateDashboardCmd(ctx context.Context, t *testing.T, profile string) {
	args := []string{"dashboard", "--url", "-p", profile, "--alsologtostderr", "-v=1"}
	ss, err := Start(t, exec.CommandContext(ctx, Target(), args...))
	if err != nil {
348
		t.Errorf("failed to run minikube dashboard. args %q : %v", args, err)
349 350 351 352 353 354
	}
	defer func() {
		ss.Stop(t)
	}()

	start := time.Now()
M
Medya Gh 已提交
355
	s, err := ReadLineWithTimeout(ss.Stdout, Seconds(300))
356
	if err != nil {
T
tstromberg 已提交
357 358 359 360
		if runtime.GOOS == "windows" {
			t.Skipf("failed to read url within %s: %v\noutput: %q\n", time.Since(start), err, s)
		}
		t.Fatalf("failed to read url within %s: %v\noutput: %q\n", time.Since(start), err, s)
361 362 363 364 365 366 367 368 369
	}

	u, err := url.Parse(strings.TrimSpace(s))
	if err != nil {
		t.Fatalf("failed to parse %q: %v", s, err)
	}

	resp, err := retryablehttp.Get(u.String())
	if err != nil {
370
		t.Fatalf("failed to http get %q: %v\nresponse: %+v", u.String(), err, resp)
371
	}
372

373 374 375
	if resp.StatusCode != http.StatusOK {
		body, err := ioutil.ReadAll(resp.Body)
		if err != nil {
376
			t.Errorf("failed to read http response body from dashboard %q: %v", u.String(), err)
377 378 379 380
		}
		t.Errorf("%s returned status code %d, expected %d.\nbody:\n%s", u, resp.StatusCode, http.StatusOK, body)
	}
}
M
Medya Gh 已提交
381

382 383 384 385
// validateDNS asserts that all Kubernetes DNS is healthy
func validateDNS(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "replace", "--force", "-f", filepath.Join(*testdataDir, "busybox.yaml")))
	if err != nil {
M
Medya Gh 已提交
386
		t.Fatalf("failed to kubectl replace busybox : args %q: %v", rr.Command(), err)
387 388
	}

M
typo  
Medya Gh 已提交
389
	names, err := PodWait(ctx, t, profile, "default", "integration-test=busybox", Minutes(4))
390
	if err != nil {
391
		t.Fatalf("failed waiting for busybox pod : %v", err)
392 393
	}

394 395 396 397 398 399
	nslookup := func() error {
		rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "exec", names[0], "nslookup", "kubernetes.default"))
		return err
	}

	// If the coredns process was stable, this retry wouldn't be necessary.
400
	if err = retry.Expo(nslookup, 1*time.Second, Minutes(1)); err != nil {
401
		t.Errorf("failed to do nslookup on kubernetes.default: %v", err)
402 403 404 405
	}

	want := []byte("10.96.0.1")
	if !bytes.Contains(rr.Stdout.Bytes(), want) {
406
		t.Errorf("failed nslookup: got=%q, want=*%q*", rr.Stdout.Bytes(), want)
407 408 409
	}
}

T
Thomas Stromberg 已提交
410 411
// validateDryRun asserts that the dry-run mode quickly exits with the right code
func validateDryRun(ctx context.Context, t *testing.T, profile string) {
412
	// dry-run mode should always be able to finish quickly (<5s)
M
Medya Gh 已提交
413
	mctx, cancel := context.WithTimeout(ctx, Seconds(5))
T
Thomas Stromberg 已提交
414 415 416
	defer cancel()

	// Too little memory!
417
	startArgs := append([]string{"start", "-p", profile, "--dry-run", "--memory", "250MB", "--alsologtostderr", "-v=1"}, StartArgs()...)
T
Thomas Stromberg 已提交
418 419 420 421 422 423 424 425
	c := exec.CommandContext(mctx, Target(), startArgs...)
	rr, err := Run(t, c)

	wantCode := 78 // exit.Config
	if rr.ExitCode != wantCode {
		t.Errorf("dry-run(250MB) exit code = %d, wanted = %d: %v", rr.ExitCode, wantCode, err)
	}

M
Medya Gh 已提交
426
	dctx, cancel := context.WithTimeout(ctx, Seconds(5))
T
Thomas Stromberg 已提交
427
	defer cancel()
428
	startArgs = append([]string{"start", "-p", profile, "--dry-run", "--alsologtostderr", "-v=1"}, StartArgs()...)
T
Thomas Stromberg 已提交
429 430 431 432 433 434 435
	c = exec.CommandContext(dctx, Target(), startArgs...)
	rr, err = Run(t, c)
	if rr.ExitCode != 0 || err != nil {
		t.Errorf("dry-run exit code = %d, wanted = %d: %v", rr.ExitCode, 0, err)
	}
}

M
Medya Gh 已提交
436
// validateCacheCmd tests functionality of cache command (cache add, delete, list)
437 438 439 440
func validateCacheCmd(ctx context.Context, t *testing.T, profile string) {
	if NoneDriver() {
		t.Skipf("skipping: cache unsupported by none")
	}
M
Medya Gh 已提交
441 442
	t.Run("cache", func(t *testing.T) {
		t.Run("add", func(t *testing.T) {
443
			for _, img := range []string{"busybox:latest", "busybox:1.28.4-glibc", "k8s.gcr.io/pause:latest"} {
444
				rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "cache", "add", img))
M
Medya Gh 已提交
445
				if err != nil {
M
Medya Gh 已提交
446
					t.Errorf("failed to cache add image %q. args %q err %v", img, rr.Command(), err)
M
Medya Gh 已提交
447 448 449
				}
			}
		})
M
Medya Ghazizadeh 已提交
450
		t.Run("delete_busybox:1.28.4-glibc", func(t *testing.T) {
451
			rr, err := Run(t, exec.CommandContext(ctx, Target(), "cache", "delete", "busybox:1.28.4-glibc"))
M
Medya Gh 已提交
452
			if err != nil {
M
Medya Gh 已提交
453
				t.Errorf("failed to delete image busybox:1.28.4-glibc from cache. args %q: %v", rr.Command(), err)
M
Medya Gh 已提交
454 455
			}
		})
M
Medya Gh 已提交
456

M
Medya Gh 已提交
457 458 459
		t.Run("list", func(t *testing.T) {
			rr, err := Run(t, exec.CommandContext(ctx, Target(), "cache", "list"))
			if err != nil {
M
Medya Gh 已提交
460
				t.Errorf("failed to do cache list. args %q: %v", rr.Command(), err)
M
Medya Gh 已提交
461 462
			}
			if !strings.Contains(rr.Output(), "k8s.gcr.io/pause") {
M
Medya Gh 已提交
463
				t.Errorf("expected 'cache list' output to include 'k8s.gcr.io/pause' but got:\n ***%s***", rr.Output())
M
Medya Gh 已提交
464 465
			}
			if strings.Contains(rr.Output(), "busybox:1.28.4-glibc") {
M
Medya Gh 已提交
466
				t.Errorf("expected 'cache list' output not to include busybox:1.28.4-glibc but got:\n ***%s***", rr.Output())
M
Medya Gh 已提交
467 468
			}
		})
M
Medya Gh 已提交
469

M
Medya Ghazizadeh 已提交
470
		t.Run("verify_cache_inside_node", func(t *testing.T) {
M
Medya Gh 已提交
471
			rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "sudo", "crictl", "images"))
M
Medya Gh 已提交
472
			if err != nil {
M
Medya Gh 已提交
473
				t.Errorf("failed to get images by %q ssh %v", rr.Command(), err)
M
Medya Gh 已提交
474
			}
M
Medya Gh 已提交
475
			if !strings.Contains(rr.Output(), "1.28.4-glibc") {
M
Medya Gh 已提交
476
				t.Errorf("expected '1.28.4-glibc' to be in the output but got *%s*", rr.Output())
M
Medya Gh 已提交
477 478 479
			}

		})
M
Medya Gh 已提交
480

M
Medya Ghazizadeh 已提交
481
		t.Run("cache_reload", func(t *testing.T) { // deleting image inside minikube node manually and expecting reload to bring it back
M
Medya Gh 已提交
482 483
			img := "busybox:latest"
			// deleting image inside minikube node manually
M
Medya Gh 已提交
484
			rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "sudo", "docker", "rmi", img)) // for some reason crictl rmi doesn't work
M
Medya Gh 已提交
485 486 487 488 489 490
			if err != nil {
				t.Errorf("failed to delete inside the node %q : %v", rr.Command(), err)
			}
			// make sure the image is deleted.
			rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "sudo", "crictl", "inspecti", img))
			if err == nil {
491
				t.Errorf("expected an error. because image should not exist. but got *nil error* ! cmd: %q", rr.Command())
M
Medya Gh 已提交
492
			}
M
Medya Gh 已提交
493
			// minikube cache reload.
M
Medya Gh 已提交
494 495
			rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "cache", "reload"))
			if err != nil {
496
				t.Errorf("expected %q to run successfully but got error: %v", rr.Command(), err)
M
Medya Gh 已提交
497
			}
M
Medya Gh 已提交
498
			// make sure 'cache reload' brought back the manually deleted image.
M
Medya Gh 已提交
499 500
			rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "sudo", "crictl", "inspecti", img))
			if err != nil {
501
				t.Errorf("expected %q to run successfully but got error: %v", rr.Command(), err)
M
Medya Gh 已提交
502 503 504
			}
		})

M
Medya Gh 已提交
505
	})
506 507 508 509 510 511 512 513 514 515 516
}

// validateConfigCmd asserts basic "config" command functionality
func validateConfigCmd(ctx context.Context, t *testing.T, profile string) {
	tests := []struct {
		args    []string
		wantOut string
		wantErr string
	}{
		{[]string{"unset", "cpus"}, "", ""},
		{[]string{"get", "cpus"}, "", "Error: specified key could not be found in config"},
T
Thomas Stromberg 已提交
517
		{[]string{"set", "cpus", "2"}, "", "! These changes will take effect upon a minikube delete and then a minikube start"},
518 519 520 521 522 523 524 525 526
		{[]string{"get", "cpus"}, "2", ""},
		{[]string{"unset", "cpus"}, "", ""},
		{[]string{"get", "cpus"}, "", "Error: specified key could not be found in config"},
	}

	for _, tc := range tests {
		args := append([]string{"-p", profile, "config"}, tc.args...)
		rr, err := Run(t, exec.CommandContext(ctx, Target(), args...))
		if err != nil && tc.wantErr == "" {
M
Medya Gh 已提交
527
			t.Errorf("failed to config minikube. args %q : %v", rr.Command(), err)
528 529 530 531
		}

		got := strings.TrimSpace(rr.Stdout.String())
		if got != tc.wantOut {
532
			t.Errorf("expected config output for %q to be -%q- but got *%q*", rr.Command(), tc.wantOut, got)
533 534 535
		}
		got = strings.TrimSpace(rr.Stderr.String())
		if got != tc.wantErr {
536
			t.Errorf("expected config error for %q to be -%q- but got *%q*", rr.Command(), tc.wantErr, got)
537 538 539 540 541 542 543 544
		}
	}
}

// validateLogsCmd asserts basic "logs" command functionality
func validateLogsCmd(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "logs"))
	if err != nil {
M
Medya Gh 已提交
545
		t.Errorf("%s failed: %v", rr.Command(), err)
546 547 548
	}
	for _, word := range []string{"Docker", "apiserver", "Linux", "kubelet"} {
		if !strings.Contains(rr.Stdout.String(), word) {
M
Medya Gh 已提交
549
			t.Errorf("excpeted minikube logs to include word: -%q- but got \n***%s***\n", word, rr.Output())
550 551 552 553
		}
	}
}

J
Josh Woodcock 已提交
554
// validateProfileCmd asserts "profile" command functionality
555
func validateProfileCmd(ctx context.Context, t *testing.T, profile string) {
M
Medya Gh 已提交
556 557 558 559 560
	t.Run("profile_not_create", func(t *testing.T) {
		// Profile command should not create a nonexistent profile
		nonexistentProfile := "lis"
		rr, err := Run(t, exec.CommandContext(ctx, Target(), "profile", nonexistentProfile))
		if err != nil {
M
Medya Gh 已提交
561
			t.Errorf("%s failed: %v", rr.Command(), err)
M
Medya Gh 已提交
562 563 564
		}
		rr, err = Run(t, exec.CommandContext(ctx, Target(), "profile", "list", "--output", "json"))
		if err != nil {
M
Medya Gh 已提交
565
			t.Errorf("%s failed: %v", rr.Command(), err)
M
Medya Gh 已提交
566 567 568 569
		}
		var profileJSON map[string][]map[string]interface{}
		err = json.Unmarshal(rr.Stdout.Bytes(), &profileJSON)
		if err != nil {
M
Medya Gh 已提交
570
			t.Errorf("%s failed: %v", rr.Command(), err)
M
Medya Gh 已提交
571 572 573 574 575 576 577
		}
		for profileK := range profileJSON {
			for _, p := range profileJSON[profileK] {
				var name = p["Name"]
				if name == nonexistentProfile {
					t.Errorf("minikube profile %s should not exist", nonexistentProfile)
				}
578
			}
579
		}
M
Medya Gh 已提交
580
	})
581

M
Medya Gh 已提交
582 583
	t.Run("profile_list", func(t *testing.T) {
		// List profiles
M
lint  
Medya Gh 已提交
584
		rr, err := Run(t, exec.CommandContext(ctx, Target(), "profile", "list"))
M
Medya Gh 已提交
585
		if err != nil {
M
Medya Gh 已提交
586
			t.Errorf("failed to list profiles: args %q : %v", rr.Command(), err)
M
Medya Gh 已提交
587
		}
J
Josh Woodcock 已提交
588

M
Medya Gh 已提交
589 590 591 592 593 594 595 596 597 598 599
		// Table output
		listLines := strings.Split(strings.TrimSpace(rr.Stdout.String()), "\n")
		profileExists := false
		for i := 3; i < (len(listLines) - 1); i++ {
			profileLine := listLines[i]
			if strings.Contains(profileLine, profile) {
				profileExists = true
				break
			}
		}
		if !profileExists {
M
Medya Gh 已提交
600
			t.Errorf("expected 'profile list' output to include %q but got *%q*. args: %q", profile, rr.Stdout.String(), rr.Command())
J
Josh Woodcock 已提交
601
		}
M
Medya Gh 已提交
602 603 604 605
	})

	t.Run("profile_json_output", func(t *testing.T) {
		// Json output
M
lint  
Medya Gh 已提交
606
		rr, err := Run(t, exec.CommandContext(ctx, Target(), "profile", "list", "--output", "json"))
M
Medya Gh 已提交
607
		if err != nil {
M
Medya Gh 已提交
608
			t.Errorf("failed to list profiles with json format. args %q: %v", rr.Command(), err)
J
Josh Woodcock 已提交
609
		}
M
Medya Gh 已提交
610 611 612
		var jsonObject map[string][]map[string]interface{}
		err = json.Unmarshal(rr.Stdout.Bytes(), &jsonObject)
		if err != nil {
M
Medya Gh 已提交
613
			t.Errorf("failed to decode json from profile list: args %q: %v", rr.Command(), err)
M
Medya Gh 已提交
614 615
		}
		validProfiles := jsonObject["valid"]
M
lint  
Medya Gh 已提交
616
		profileExists := false
M
Medya Gh 已提交
617 618 619 620 621 622 623
		for _, profileObject := range validProfiles {
			if profileObject["Name"] == profile {
				profileExists = true
				break
			}
		}
		if !profileExists {
M
Medya Gh 已提交
624
			t.Errorf("expected the json of 'profile list' to include %q but got *%q*. args: %q", profile, rr.Stdout.String(), rr.Command())
M
Medya Gh 已提交
625 626 627
		}

	})
628 629 630
}

// validateServiceCmd asserts basic "service" command functionality
631
func validateServiceCmd(ctx context.Context, t *testing.T, profile string) {
632
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node", "--image=gcr.io/hello-minikube-zero-install/hello-node"))
633
	if err != nil {
M
Medya Gh 已提交
634
		t.Logf("%q failed: %v (may not be an error).", rr.Command(), err)
635
	}
636
	rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "expose", "deployment", "hello-node", "--type=NodePort", "--port=8080"))
637
	if err != nil {
M
Medya Gh 已提交
638
		t.Logf("%q failed: %v (may not be an error)", rr.Command(), err)
639 640
	}

641
	if _, err := PodWait(ctx, t, profile, "default", "app=hello-node", Minutes(10)); err != nil {
642
		t.Fatalf("failed waiting for hello-node pod: %v", err)
643 644
	}

645
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "list"))
646
	if err != nil {
M
Medya Gh 已提交
647
		t.Errorf("failed to do service list. args %q : %v", rr.Command(), err)
648
	}
649
	if !strings.Contains(rr.Stdout.String(), "hello-node") {
650
		t.Errorf("expected 'service list' to contain *hello-node* but got -%q-", rr.Stdout.String())
651 652
	}

653 654 655 656
	if NeedsPortForward() {
		t.Skipf("test is broken for port-forwarded drivers: https://github.com/kubernetes/minikube/issues/7383")
	}

657
	// Test --https --url mode
658
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "--namespace=default", "--https", "--url", "hello-node"))
659
	if err != nil {
M
Medya Gh 已提交
660
		t.Fatalf("failed to get service url. args %q : %v", rr.Command(), err)
661 662
	}
	if rr.Stderr.String() != "" {
663
		t.Errorf("expected stderr to be empty but got *%q*", rr.Stderr)
664
	}
665 666

	endpoint := strings.TrimSpace(rr.Stdout.String())
667 668
	u, err := url.Parse(endpoint)
	if err != nil {
669
		t.Fatalf("failed to parse service url endpoint %q: %v", endpoint, err)
670 671
	}
	if u.Scheme != "https" {
672
		t.Errorf("expected scheme to be 'https' but got %q", u.Scheme)
673 674 675
	}

	// Test --format=IP
676
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "hello-node", "--url", "--format={{.IP}}"))
677
	if err != nil {
M
Medya Gh 已提交
678
		t.Errorf("failed to get service url with custom format. args %q: %v", rr.Command(), err)
679
	}
680
	if strings.TrimSpace(rr.Stdout.String()) != u.Hostname() {
M
Medya Gh 已提交
681
		t.Errorf("expected 'service --format={{.IP}}' output to be -%q- but got *%q* . args %q.", u.Hostname(), rr.Stdout.String(), rr.Command())
682 683
	}

684 685
	// Test a regular URLminikube
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "hello-node", "--url"))
686
	if err != nil {
M
Medya Gh 已提交
687
		t.Errorf("failed to get service url. args: %q: %v", rr.Command(), err)
688
	}
689 690 691 692 693 694 695

	endpoint = strings.TrimSpace(rr.Stdout.String())
	u, err = url.Parse(endpoint)
	if err != nil {
		t.Fatalf("failed to parse %q: %v", endpoint, err)
	}
	if u.Scheme != "http" {
M
lint  
Medya Gh 已提交
696
		t.Fatalf("expected scheme to be -%q- got scheme: *%q*", "http", u.Scheme)
697 698 699 700
	}

	t.Logf("url: %s", endpoint)
	resp, err := retryablehttp.Get(endpoint)
701
	if err != nil {
702
		t.Fatalf("get failed: %v\nresp: %v", err, resp)
703 704
	}
	if resp.StatusCode != http.StatusOK {
M
lint  
Medya Gh 已提交
705
		t.Fatalf("expected status code for %q to be -%q- but got *%q*", endpoint, http.StatusOK, resp.StatusCode)
706 707 708
	}
}

709 710
// validateAddonsCmd asserts basic "addon" command functionality
func validateAddonsCmd(ctx context.Context, t *testing.T, profile string) {
M
Medya Gh 已提交
711
	// Table output
712 713
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "addons", "list"))
	if err != nil {
M
Medya Gh 已提交
714
		t.Errorf("failed to do addon list: args %q : %v", rr.Command(), err)
715
	}
M
Medya Gh 已提交
716 717
	for _, a := range []string{"dashboard", "ingress", "ingress-dns"} {
		if !strings.Contains(rr.Output(), a) {
M
Medya Gh 已提交
718
			t.Errorf("expected 'addon list' output to include -%q- but got *%s*", a, rr.Output())
719 720
		}
	}
J
Josh Woodcock 已提交
721 722 723 724

	// Json output
	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "addons", "list", "-o", "json"))
	if err != nil {
M
Medya Gh 已提交
725
		t.Errorf("failed to do addon list with json output. args %q: %v", rr.Command(), err)
J
Josh Woodcock 已提交
726 727 728 729
	}
	var jsonObject map[string]interface{}
	err = json.Unmarshal(rr.Stdout.Bytes(), &jsonObject)
	if err != nil {
730
		t.Errorf("failed to decode addon list json output : %v", err)
J
Josh Woodcock 已提交
731
	}
732 733
}

734 735 736 737 738
// validateSSHCmd asserts basic "ssh" command functionality
func validateSSHCmd(ctx context.Context, t *testing.T, profile string) {
	if NoneDriver() {
		t.Skipf("skipping: ssh unsupported by none")
	}
P
Priya Wadhwa 已提交
739
	want := "hello\n"
740 741
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", fmt.Sprintf("echo hello")))
	if err != nil {
M
Medya Gh 已提交
742
		t.Errorf("failed to run an ssh command. args %q : %v", rr.Command(), err)
743 744
	}
	if rr.Stdout.String() != want {
M
Medya Gh 已提交
745
		t.Errorf("expected minikube ssh command output to be -%q- but got *%q*. args %q", want, rr.Stdout.String(), rr.Command())
746 747 748
	}
}

749 750 751 752
// validateMySQL validates a minimalist MySQL deployment
func validateMySQL(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "replace", "--force", "-f", filepath.Join(*testdataDir, "mysql.yaml")))
	if err != nil {
M
Medya Gh 已提交
753
		t.Fatalf("failed to kubectl replace mysql: args %q failed: %v", rr.Command(), err)
754 755
	}

756
	names, err := PodWait(ctx, t, profile, "default", "app=mysql", Minutes(10))
757
	if err != nil {
758
		t.Fatalf("failed waiting for mysql pod: %v", err)
759 760
	}

761 762 763 764
	// Retry, as mysqld first comes up without users configured. Scan for names in case of a reschedule.
	mysql := func() error {
		rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "exec", names[0], "--", "mysql", "-ppassword", "-e", "show databases;"))
		return err
765
	}
M
Medya Gh 已提交
766
	if err = retry.Expo(mysql, 1*time.Second, Minutes(5)); err != nil {
767
		t.Errorf("failed to exec 'mysql -ppassword -e show databases;': %v", err)
768 769 770
	}
}

771 772 773 774 775 776 777 778 779 780
// vmSyncTestPath is where the test file will be synced into the VM
func vmSyncTestPath() string {
	return fmt.Sprintf("/etc/test/nested/copy/%d/hosts", os.Getpid())
}

// localSyncTestPath is where the test file will be synced into the VM
func localSyncTestPath() string {
	return filepath.Join(localpath.MiniPath(), "/files", vmSyncTestPath())
}

781 782 783 784 785 786 787 788 789 790
// testCert is name of the test certificate installed
func testCert() string {
	return fmt.Sprintf("%d.pem", os.Getpid())
}

// localTestCertPath is where the test file will be synced into the VM
func localTestCertPath() string {
	return filepath.Join(localpath.MiniPath(), "/certs", testCert())
}

791 792
// Copy extra file into minikube home folder for file sync test
func setupFileSync(ctx context.Context, t *testing.T, profile string) {
793 794 795
	p := localSyncTestPath()
	t.Logf("local sync path: %s", p)
	err := copy.Copy("./testdata/sync.test", p)
796
	if err != nil {
797
		t.Fatalf("failed to copy ./testdata/sync.test : %v", err)
798
	}
799 800 801

	err = copy.Copy("./testdata/minikube_test.pem", localTestCertPath())
	if err != nil {
802
		t.Fatalf("failed to copy ./testdata/minikube_test.pem : %v", err)
803
	}
804 805 806 807 808 809 810
}

// validateFileSync to check existence of the test file
func validateFileSync(ctx context.Context, t *testing.T, profile string) {
	if NoneDriver() {
		t.Skipf("skipping: ssh unsupported by none")
	}
811 812 813

	vp := vmSyncTestPath()
	t.Logf("Checking for existence of %s within VM", vp)
814
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", fmt.Sprintf("sudo cat %s", vp)))
815
	if err != nil {
M
Medya Gh 已提交
816
		t.Errorf("%s failed: %v", rr.Command(), err)
817
	}
818 819
	got := rr.Stdout.String()
	t.Logf("file sync test content: %s", got)
820 821 822

	expected, err := ioutil.ReadFile("./testdata/sync.test")
	if err != nil {
823
		t.Errorf("failed to read test file '/testdata/sync.test' : %v", err)
824 825
	}

826
	if diff := cmp.Diff(string(expected), got); diff != "" {
827 828 829 830
		t.Errorf("/etc/sync.test content mismatch (-want +got):\n%s", diff)
	}
}

831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850
// validateCertSync to check existence of the test certificate
func validateCertSync(ctx context.Context, t *testing.T, profile string) {
	if NoneDriver() {
		t.Skipf("skipping: ssh unsupported by none")
	}

	want, err := ioutil.ReadFile("./testdata/minikube_test.pem")
	if err != nil {
		t.Errorf("test file not found: %v", err)
	}

	// Check both the installed & reference certs (they should be symlinked)
	paths := []string{
		path.Join("/etc/ssl/certs", testCert()),
		path.Join("/usr/share/ca-certificates", testCert()),
		// hashed path generated by: 'openssl x509 -hash -noout -in testCert()'
		"/etc/ssl/certs/51391683.0",
	}
	for _, vp := range paths {
		t.Logf("Checking for existence of %s within VM", vp)
851
		rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", fmt.Sprintf("sudo cat %s", vp)))
852
		if err != nil {
M
Medya Gh 已提交
853
			t.Errorf("failed to check existence of %q inside minikube. args %q: %v", vp, rr.Command(), err)
854 855 856 857 858
		}

		// Strip carriage returned by ssh
		got := strings.Replace(rr.Stdout.String(), "\r", "", -1)
		if diff := cmp.Diff(string(want), got); diff != "" {
859
			t.Errorf("failed verify pem file. minikube_test.pem -> %s mismatch (-want +got):\n%s", vp, diff)
860 861 862 863
		}
	}
}

864 865 866 867
// validateUpdateContextCmd asserts basic "update-context" command functionality
func validateUpdateContextCmd(ctx context.Context, t *testing.T, profile string) {
	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "update-context", "--alsologtostderr", "-v=2"))
	if err != nil {
M
Medya Gh 已提交
868
		t.Errorf("failed to run minikube update-context: args %q: %v", rr.Command(), err)
869 870
	}

T
Thomas Stromberg 已提交
871
	want := []byte("No changes")
872 873 874 875 876
	if !bytes.Contains(rr.Stdout.Bytes(), want) {
		t.Errorf("update-context: got=%q, want=*%q*", rr.Stdout.Bytes(), want)
	}
}

877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892
// startHTTPProxy runs a local http proxy and sets the env vars for it.
func startHTTPProxy(t *testing.T) (*http.Server, error) {
	port, err := freeport.GetFreePort()
	if err != nil {
		return nil, errors.Wrap(err, "Failed to get an open port")
	}

	addr := fmt.Sprintf("localhost:%d", port)
	proxy := goproxy.NewProxyHttpServer()
	srv := &http.Server{Addr: addr, Handler: proxy}
	go func(s *http.Server, t *testing.T) {
		if err := s.ListenAndServe(); err != http.ErrServerClosed {
			t.Errorf("Failed to start http server for proxy mock")
		}
	}(srv, t)
	return srv, nil
893
}