- 09 6月, 2015 7 次提交
-
-
由 Hixie 提交于
Also change SizedBox. This makes the code that uses Container() and SizedBox() much more readable. The underlying RenderSizedBox is not affected by this change. R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1166203002
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1164363002
-
由 Adam Barth 提交于
The popup menu is displayed in the wrong location with the wrong width, but it does draw. I've also removed the checkbox because the flex container was causing me trouble. I'll add it back in a later CL. R=ianh@google.com Review URL: https://codereview.chromium.org/1166153002
-
由 Adam Barth 提交于
This CL is the first step towards getting PopupMenuItem working in fn2. We introduce the ability to add a minWidth to a Container by creating a RenderConstrainedBox class to apply the new constraints. R=ianh@google.com Review URL: https://codereview.chromium.org/1155683011
-
由 Hixie 提交于
This includes making SizedBox default to infinite size, and making Container default to containing one infinite-sized SizedBox. That way, you can use an empty Container as a spacer in a flex box. The rendering doesn't quite work, because of a bug in flex whereby it doesn't shrink-wrap its contents in the cross-direction, it fills the parent. Collin is on that. R=jackson@google.com Review URL: https://codereview.chromium.org/1163633003
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1169543009
-
由 Hixie 提交于
Changes: - Remove all the old tracing logic since that was a lot of code for just random printf debugging and nobody seems to use it - Convert "defunct", a permanent state transition, to "mounted", a state that can be entered and exitted arbitrarily - Coallesce mount/unmount notifications so there's only one per frame - Remove handleRemoved() since we don't use it - Rename a local variable 'parent' to 'ancestor' to avoid shadowing the field - Replace uses of forEach() with for-in Effects: - Reusing a node provided to a constructor in a new place in a tree (especially at a different depth) no longer fails (it used to fail because the node would be marked defunct then remounted later, at which point it would fail) R=abarth@chromium.org Review URL: https://codereview.chromium.org/1169673002
-
- 06 6月, 2015 3 次提交
-
-
由 Hixie 提交于
Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1161323004
-
由 Hixie 提交于
- several places where we use a getter knowing that it will return a subclass of its declared type, even asserting that it does, but where the analyzer is worried that the getter might start returning a new value unexpectedly, solved by having a temporary local variable shadow the getter and asserting that it doesn't change value - many many places where we do this with parentData specifically, solved by type-erasing parentData. - a place where a mixin wants to be subclassing another class, and uses its methods, solved by saying that the mixin is abstract but implements the superclass R=abarth@chromium.org Review URL: https://codereview.chromium.org/1160923008
-
由 Adam Barth 提交于
Turns out Scaffold needs to hook _remove, so we need to rename it to remove to expose it outside fn2.dart. R=ianh@google.com Review URL: https://codereview.chromium.org/1160013007
-
- 05 6月, 2015 11 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, eseidel@chromium.org, abarth Review URL: https://codereview.chromium.org/1157573012
-
由 Hixie 提交于
Improve the RenderObject.toString() logic so that there's not blank lines everywhere and to generally be better. Adds sizes, positions, transforms, improves RenderParagraph's output. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1160233004
-
由 Adam Barth 提交于
We should be asserting that old.root is a ContainerRenderObjectMixin because we're able to manipulate its child list. R=ianh@google.com Review URL: https://codereview.chromium.org/1169593002
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1162623011
-
由 Adam Barth 提交于
This CL makes FixedHeightScrollable able to measure heights. In the DOM-based version, FixedHeightScrollable forced a synchronous layout in a microtask in order to measure the size of itself and its children. In the DOM-less version, we now require the subclass to tell us the item height and we measure our own height using a layout callback. R=ianh@google.com Review URL: https://codereview.chromium.org/1161063005
-
由 Hixie 提交于
https://www.dartlang.org/articles/style-guide/#names R=jackson@google.com Review URL: https://codereview.chromium.org/1158813004
-
由 Adam Barth 提交于
In the future, we might want to extend this class to clip to a configurable rect in addition to clipping to its bounds. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1145263006
-
由 Hixie 提交于
Rename OneChildListRenderObjectWrapper to MultiChildRenderObjectWrapper to avoid the confusing similarity with OneChildRenderObjectWrapper. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1150543005
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1164073002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1165013003
-
由 Hixie 提交于
The root cause of the crash was threefold: - you can't enumerate enums, in dart; you have to enumerate their values. - RenderNodeWrapper was trying to call remove(child.root) on its root, but that's not something that all RenderNodes have - when a RenderNode was deparented, its relayoutSubtreeRoot wasn't removed, so the node ended up in an inconsistent state regarding its parent tree R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151573020
-
- 04 6月, 2015 4 次提交
-
-
由 Adam Barth 提交于
This CL makes gesture events work again in fn2. R=ianh@google.com Review URL: https://codereview.chromium.org/1146923005
-
由 Collin Jackson 提交于
This also fixes a bug that was preventing markNeedsLayout from working R=abarth@chromium.org, eseidel@chromium.org, abarth, eseidel Review URL: https://codereview.chromium.org/1160013004
-
由 Adam Barth 提交于
This CL introduces RenderStack and fixes a number of bugs to make the Drawer in components2 work. R=ianh@google.com, eseidel@chromium.org Review URL: https://codereview.chromium.org/1147143005
-
由 Adam Barth 提交于
These transforms are currently very basic but they seem to mostly work. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1152273004
-
- 03 6月, 2015 6 次提交
-
-
由 Eric Seidel 提交于
Looks horrible. But it's a start. R=abarth@chromium.org, ianh@google.com BUG= Review URL: https://codereview.chromium.org/1146913005
-
由 Adam Barth 提交于
This CL is a first pass at implementing container in fn2. In this approach, Container is a Component that builds a number of RenderNodeWrappers depending on what is needed. R=ianh@google.com Review URL: https://codereview.chromium.org/1158983005
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1166773003
-
由 Adam Barth 提交于
This machinery existed only to save one null check. R=ianh@google.com Review URL: https://codereview.chromium.org/1163933002
-
由 Adam Barth 提交于
BlockContainer uses a RenderBlock to lay out its children. R=eseidel@chromium.org, jackson@chromium.org Review URL: https://codereview.chromium.org/1166473005
-
由 Adam Barth 提交于
Prevously we listened for events on the document and then walked up the component hierarchy looking for EventListenerNodes. Now we do something similar by hooking the event dispatching logic in the AppView. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1153343004
-
- 29 5月, 2015 5 次提交
-
-
由 Adam Barth 提交于
Previously layout2.dart was a thousand lines long. R=ianh@google.com Review URL: https://codereview.chromium.org/1161003002
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1150253005
-
由 Eric Seidel 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1160843005
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1156303004
-
由 Hixie 提交于
This dramatically simplifies the layout model. I haven't gone through and simplified the existing functions, we should probably go through and figure out if they can be cleaned up a bit. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1161983004
-
- 28 5月, 2015 4 次提交
-
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1156013003
-
由 Hixie 提交于
This gets things off the ground barely enough to show some pixels. These are not pixels that are actually part of the stock app, but it's a start. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1157033006
-
由 Hixie 提交于
This is needed for cases where the UINode doesn't have a list of children (so it doesn't go through the RenderNodeWrapper sync logic that removes children), but it still has multiple slots, and needs to support removing nodes from those slots. (For example, removing a drawer from a ScaffoldContainer.) Also, expose syncChild (it used to be private) so it can be overridden in descendants outside fn.dart. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158563003
-
由 Hixie 提交于
This is needed to create a ScaffoldContainer in scaffold.dart. This exposes: UINode._root => root UINode._removeChild => removeChild RenderNodeWrapper._createNode => createNode RenderNodeWrapper._emptyNode => emptyNode RenderNodeWrapper._syncRenderNode => syncRenderNode R=abarth@chromium.org Review URL: https://codereview.chromium.org/1148323004
-