1. 09 6月, 2016 1 次提交
    • S
      Reconstruct the directory structure of minikin tests. · c38b249e
      Seigo Nonaka 提交于
      To add perftests and reuse some utility classes, reconstruct
      test directory structure.
      
      - Move unit tests from minikin/tests to minikin/tests/unittests
      - Extract utilitiy classes to minikin/tests/utils which will be
        used by perftests eventually.
      
      Change-Id: I5026b177934e72ae67d362ee888302037da2f808
      c38b249e
  2. 26 5月, 2016 7 次提交
  3. 20 4月, 2016 6 次提交
  4. 19 4月, 2016 1 次提交
  5. 15 4月, 2016 3 次提交
  6. 14 4月, 2016 3 次提交
  7. 13 4月, 2016 1 次提交
    • R
      Clear mLineWidths in LineBreaker::finish() · 879e8a3a
      Raph Levien 提交于
      There was the possibility of stale indents from previous invocations
      persisting in the mLineWidths across multiple invocations. This patch
      clears them.
      
      Bug: 28090810
      Change-Id: I3621dfbe983512046289373711709aeade52eab4
      879e8a3a
  8. 12 4月, 2016 3 次提交
    • S
      Fix minikin_unittests am: 6c60831c · ba8a5468
      Seigo Nonaka 提交于
      am: af36413c
      
      * commit 'af36413c':
        Fix minikin_unittests
      
      Change-Id: Ibac5c54ae165d96811238a4e8d2e9612d1192eaf
      ba8a5468
    • S
      Fix minikin_unittests · af36413c
      Seigo Nonaka 提交于
      am: 6c60831c
      
      * commit '6c60831c':
        Fix minikin_unittests
      
      Change-Id: I865dd495ed60b0bbace0ba77b2071dac058887e9
      af36413c
    • S
      Fix minikin_unittests · 6c60831c
      Seigo Nonaka 提交于
      This CL fixes following test cases in minikin_tests
      - FontFamilyTest.hasVariationSelectorTest
      - HbFontCacheTest.getHbFontLockedTest
      - HbFontCacheTest.purgeCacheTest
      
      For the fix of FontFamilyTest.hasVariationSelectorTest, removing virtual
      from GetUniqueId() in MinikinFont.  After [1], MinikinFont's destructor
      started calling purgeHbCache() which calls virtual method,
      MinikinFont::GetUniqueId().  Fortunately, the SkTypeface::uniqueID()
      returns just internal value, so we can store it at the construction time
      and use it instead of calling SkTypeface::uniqueID() every time.
      
      This patch also changes purgeHbFont to purgeHbFontLocked, as all uses of
      it were already under global mutex. This change avoids deadlock on
      explicit unref, as when invoked by a Java finalizer from the Java object
      that holds a reference to the font.
      
      Some of the tests needed to change to using the ref counting protocol
      rather than explicitly destructing font objects, as well.
      
      [1] 9afcc6e2
      
      Bug: 28105730
      Bug: 28105688
      Change-Id: Ie5983c4869147dacabdca81af1605066cd680b3f
      6c60831c
  9. 09 4月, 2016 5 次提交
  10. 08 4月, 2016 4 次提交
    • R
      Avoid copying of font table data · aaa4e347
      Raph Levien 提交于
      The hb_font_t object holds on to tables of font data, acquired through
      the MinikinFont::GetTable interface, which is based on copying data
      into caller-owned buffers. Now that we're caching lots of hb_font_t's,
      the cost of these buffers is significant.
      
      This patch moves to a different interface, inspired by HarfBuzz's
      hb_reference_table API, where the font can provide a pointer to the
      actual font data (which will often be mmap'ed, so it doesn't even
      consume physical RAM).
      
      Bug: 27860101
      Change-Id: Id766ab16a8d342bf7322a90e076e801271d527d4
      aaa4e347
    • R
      Purge hb font on Minikin font destruction am: 9afcc6e2 · ff5e822a
      Raph Levien 提交于
      am: aa495426
      
      * commit 'aa495426':
        Purge hb font on Minikin font destruction
      
      Change-Id: If40c31c90bf4f12fdd882be4f2c6f9b35ba2d09c
      ff5e822a
    • R
      Purge hb font on Minikin font destruction · aa495426
      Raph Levien 提交于
      am: 9afcc6e2
      
      * commit '9afcc6e2':
        Purge hb font on Minikin font destruction
      
      Change-Id: Idb2034353407e8b390cc07862803f846d5adea0c
      aa495426
    • R
      Purge hb font on Minikin font destruction · 9afcc6e2
      Raph Levien 提交于
      This patch eagerly purges the corresponding hb_font_t object from
      the HbFontCache when the underlying MinikinFont is destroyed. After
      that, the key will no longer be accessed, so having the entry is
      wastes memory.
      
      Bug: 27251075
      Bug: 27860101
      Change-Id: I1b98016133fe3baf6525ac37d970a65ddccadb4f
      9afcc6e2
  11. 05 4月, 2016 2 次提交
  12. 04 4月, 2016 1 次提交
    • S
      Support multiple locales for font language settings. · f3afe92d
      Seigo Nonaka 提交于
      Some fonts support multiple scripts, for example, some fonts for
      Korean supports not only "Kore" but also "Jamo".
      
      To select fonts based on their multiple languages, this CL introduces
      the following changes:
      - Compares all languages of the font family and use the maximum score
        for font selection.
      - Even if each language of the font family doesn't support the requested
        language, the font get score of 2 if the requested font is covered by
        all of the languages of the font family. For example, the font for
        "ko-Hang,ko-Hani" gets score of 2 for the requested language "ko-Kore".
      
      Bug: 26687969
      
      Change-Id: I7f13b51464c9b01982bb573251d77052b9ddbd70
      f3afe92d
  13. 01 4月, 2016 2 次提交
  14. 31 3月, 2016 1 次提交
    • R
      Try putting combining marks in the same font run · 16ed4ef0
      Roozbeh Pournader 提交于
      Indic combining marks, when combined with a common character such as
      a hyphen or a dotted circle, used to get rendered in a different font
      due to the greedy algorithm used in determining runs, which resulted
      in the base character and the combining mark getting rendered in
      separate font runs, resulting in a dotted circle appearing in phrases
      such as "100-ാം" (0031 0030 0030 002D 0D3E 0D02).
      
      This change makes combining marks change the font run of the base
      character if the base character is supported in the same font as the
      combining mark, similar to the support for emoji modifiers and the
      combining keycap.
      
      Bug: 25036888
      Bug: 24535344
      Change-Id: I8e2798e8ecb8efaf723a0fd02c05c6fbdef8b365
      16ed4ef0