1. 27 8月, 2019 1 次提交
    • C
      Ensure trailing newline before EOF in C++ sources (#11489) · 92c63e84
      Chris Bracken 提交于
      In generated text fixture location lookup code:
      When the second argument to write_file() is a list, it is written one
      item per line to the path specified by the first argument. This ensures
      that we emit a trailing newline at EOF to comply with -Wnewline-eof.
      
      Elsewhere:
      Lack of a newline at EOF was undefined behaviour prior to C++11. The
      Fuchsia tree sets -Wnewline-eof in its buildroot, so we plan to do the
      same. This cleans up remaining first-party C++ sources that don't
      include a trailing newline.
      92c63e84
  2. 29 5月, 2019 1 次提交
    • C
      Allow specifying both Dart and non-Dart fixtures in engine unit-tests. (#9113) · 37b367e4
      Chinmay Garde 提交于
      * Allow specifying both Dart and non-Dart fixtures in engine unittests.
      
      This fixes numerous issues in the way in which fixtures were managed
      in the engine unit-tests.
      
      * Instead of only being able to specify Dart fixtures, unit-tests may specify
        non-Dart fixtures as well. These are simply copied over to the fixtures
        directory known to the unit-test at runtime.
      * An issue where numerous Dart files could be given to the kernel snapshotter
        has been addressed. It was anticipated that such a (legal) invocation to the
        kernel snapshotter would produce a snapshot with the contents of all the Dart
        files added to the root library. This is incorrect and the behavior in this
        case is undefined.
      * Dart files referenced by the main Dart file are correctly tracked via a
        depfile.
      * The snapshotter arguments have been cleaned up to get rid of unused
        arguments (`—strong`) and  the use of the VM product mode argument has been
        corrected to no longer depend on the Flutter product mode.
      37b367e4
  3. 30 3月, 2019 1 次提交
  4. 16 2月, 2019 1 次提交
  5. 23 1月, 2019 1 次提交
  6. 17 12月, 2018 1 次提交
    • C
      Compile embedder unit test Dart to kernel (#7231) · 67cd7d4d
      Chris Bracken 提交于
      As of the migration to Dart 2, it has been necessary to compile Dart to
      kernel prior to execution. The embedder currently requires that the
      resulting kernel file be named `kernel_blob.bin` and be located at the
      root of the assets directory passed to the embedder API.
      
      This patch updates the test_fixtures build rule to perform a kernel
      compile using frontend_server, outputting `kernel_blob.bin` to
      `fixtures/test_target_name` directory, and updates the embedder
      unittests to specify the kernel file rather than the Dart source file.
      
      Since the kernel compiler requires a `main()` function to be defined, it
      also updates `simple_main.dart` from runtime_unittests to define
      `main()` rather than `simple_main()`.
      
      This also updates all existing sub-targets to be testonly.
      
      This relands commit ac9e521a, which was
      reverted in commit 49411258. Rather than
      running as prebuilt_dart_action, we use dart_action to ensure the
      frontend snapshot it compatible with the VM on which it's executed.
      67cd7d4d
  7. 16 12月, 2018 2 次提交
    • C
      Revert "Compile embedder unit test Dart to kernel (#7227)" (#7230) · 49411258
      Chris Bracken 提交于
      This reverts commit ac9e521a.
      
      This broke dynamic release mode builds of
      //flutter/runtime:runtime_fixtures_kernel (likely all product-mode
      builds).
      49411258
    • C
      Compile embedder unit test Dart to kernel (#7227) · ac9e521a
      Chris Bracken 提交于
      Compile embedder unit test Dart to kernel
      
      As of the migration to Dart 2, it has been necessary to compile Dart to
      kernel prior to execution. The embedder currently requires that the
      resulting kernel file be named `kernel_blob.bin` and be located at the
      root of the assets directory passed to the embedder API.
      
      This patch updates the test_fixtures build rule to perform a kernel
      compile using frontend_server, outputting `kernel_blob.bin` to
      `fixtures/test_target_name` directory, and updates the embedder
      unittests to specify the kernel file rather than the Dart source file.
      
      Since the kernel compiler requires a `main()` function to be defined, it
      also updates `simple_main.dart` from runtime_unittests to define
      `main()` rather than `simple_main()`.
      
      This also updates all existing sub-targets to be testonly.
      ac9e521a
  8. 08 11月, 2018 1 次提交
  9. 26 10月, 2017 1 次提交