- 05 6月, 2015 20 次提交
-
-
由 Eric Seidel 提交于
The goal of this is to have a Renderer-layer abstraction around the Sky Engine c++ apis for drawing a shadow. R=mpcomplete@chromium.org Review URL: https://codereview.chromium.org/1146893004
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151533006
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1162623011
-
由 Hixie 提交于
This makes debugging the render tree a lot easier. Just print the node you care about, and you get an indented tree view of its subtree, including settings. New subclasses should implement the new virtual method debugDescribeSettings() to expose new settings. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1157993005
-
由 Adam Barth 提交于
This CL makes FixedHeightScrollable able to measure heights. In the DOM-based version, FixedHeightScrollable forced a synchronous layout in a microtask in order to measure the size of itself and its children. In the DOM-less version, we now require the subclass to tell us the item height and we measure our own height using a layout callback. R=ianh@google.com Review URL: https://codereview.chromium.org/1161063005
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1163913004
-
由 Hixie 提交于
https://www.dartlang.org/articles/style-guide/#names R=jackson@google.com Review URL: https://codereview.chromium.org/1158813004
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1169583002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1144933007
-
由 Adam Barth 提交于
In the future, we might want to extend this class to clip to a configurable rect in addition to clipping to its bounds. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1145263006
-
由 Hixie 提交于
Rename OneChildListRenderObjectWrapper to MultiChildRenderObjectWrapper to avoid the confusing similarity with OneChildRenderObjectWrapper. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1150543005
-
由 Viktor Lidholt 提交于
Adds support for transfer mode in Paint and SpriteNode classes. Adds support for opacity in sprites, and modifies example game. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1164633004
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1165983002
-
由 Adam Barth 提交于
We still need to add a clip and a way to integrate with layout, but those changes are more invasive and I'll do them in separate CLs. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1166983003
-
由 Matt Perry 提交于
The array should be in column-major format, in the format used by vector_math.dart. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1155193004
-
由 Hixie 提交于
Currently supports only solid borders, but of any colour and size, independently controlling each side. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1154903006
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1164073002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1165013003
-
由 Hixie 提交于
The root cause of the crash was threefold: - you can't enumerate enums, in dart; you have to enumerate their values. - RenderNodeWrapper was trying to call remove(child.root) on its root, but that's not something that all RenderNodes have - when a RenderNode was deparented, its relayoutSubtreeRoot wasn't removed, so the node ended up in an inconsistent state regarding its parent tree R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151573020
-
由 Seth Ladd 提交于
Was removed in https://github.com/domokit/mojo/commit/1a396394dd951450f0ff5c2da81dced0ca18e8c8 R=eseidel@chromium.org, johnmccutchan@google.com Review URL: https://codereview.chromium.org/1159013011
-
- 04 6月, 2015 20 次提交
-
-
由 Adam Barth 提交于
The current copy is in //sky/sdk/lib. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1160393003
-
由 Hixie 提交于
R=jackson@google.com Review URL: https://codereview.chromium.org/1166523006
-
由 Eric Seidel 提交于
I also moved Icon back to using int, since double doesn't actually make sense for an icon pixel size. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1164023005
-
由 Adam Barth 提交于
The skydb tool is actually used to run many mojo apps that aren't related to Sky. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1164023004
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1153673005
-
由 Eric Seidel 提交于
Catch the MalformedURLException instead of dying. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1153033010
-
由 Adam Barth 提交于
This CL makes gesture events work again in fn2. R=ianh@google.com Review URL: https://codereview.chromium.org/1146923005
-
由 Eric Seidel 提交于
Even though Image doesn't yet know how to handle relative urls. TBR=jackson@google.com Review URL: https://codereview.chromium.org/1157163009
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1168623002
-
由 Hixie 提交于
Not tested on device. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1160523005
-
由 Eric Seidel 提交于
This also works around an Android-only crasher for the Dart VM: https://github.com/domokit/mojo/issues/192 R=ianh@google.com Review URL: https://codereview.chromium.org/1157243012
-
由 Collin Jackson 提交于
This also fixes a bug that was preventing markNeedsLayout from working R=abarth@chromium.org, eseidel@chromium.org, abarth, eseidel Review URL: https://codereview.chromium.org/1160013004
-
由 Viktor Lidholt 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1149183004
-
由 Hixie 提交于
Except that nothing actually uses these now so it's a no-op really. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1157243011
-
由 Adam Barth 提交于
This CL introduces RenderStack and fixes a number of bugs to make the Drawer in components2 work. R=ianh@google.com, eseidel@chromium.org Review URL: https://codereview.chromium.org/1147143005
-
由 Hixie 提交于
Also, make the scaffold code more generic (with slots in a map, instead of dedicated members for each slot). This may eventually benefit from being split into a general "multislot" superclass and a scaffold-specific subclass, but for now it'll do. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1152163007
-
由 Hixie 提交于
Also some minor code cleanup in affected files and nearby files. R=mpcomplete@chromium.org Review URL: https://codereview.chromium.org/1160453006
-
由 Matt Perry 提交于
Also add operator==, hashCode, toString, and some basic Color constants to Color. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1162023004
-
由 Matt Perry 提交于
It looked and smelled like an enum, so lets just make it one. This also gives us a nice toString() method. R=abarth@chromium.org, eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1144233004
-
由 Eric Seidel 提交于
R=abarth@chromium.org, viktorl@google.com Review URL: https://codereview.chromium.org/1152483006
-