1. 04 6月, 2014 1 次提交
    • R
      Support for scaleX and skewX · 448b0fd7
      Raph Levien 提交于
      Adds pseudo-css properties for scaleX and skewX, as well as paint flags,
      and plumb them through to the MinikinPaint abstraction and to Harfbuzz,
      to support nontrivial scale and stretch of text.
      
      This is the Minikin part of the fix for bug 15186705 "Usability of the
      suggestion strip in recent OTA's is severely reduced"
      
      Change-Id: Ifa60355e086e4691ff92c5d50d84eb7cea0fea95
      448b0fd7
  2. 30 5月, 2014 3 次提交
    • R
      Fix ZWJ not working for Indic fonts · 066e8575
      Raph Levien 提交于
      This is a fix for bug 15185229 ZWJ not working in Sinhala and Kannada.
      
      Indic fonts (unlike Arabic) require the entire string, including ZWJ,
      to be passed to Harfbuzz; it's not enough for the ZWJ to be present in
      the context. The solution is to be "sticky" in font itemization,
      continuing to use the same font as long as it has Unicode coverage.
      
      Change-Id: I7673bc56fbda09f1e1a4582e8d88342343b706f1
      066e8575
    • R
      Language and variant selection · 7b221d97
      Raph Levien 提交于
      This patch adds a "lang" pseudo-CSS property and uses it both to select
      an appropriate font and control the "locl" OpenType feature to get the
      most appropriate rendering for the langauge and script.  In addition,
      the "-minikin-variant" property selects between "compact" and "elegant"
      variants of a font, as the former is needed for vertically cramped
      spaces.
      
      This is part of the fix for bug 15179652 "Japanese font isn't shown on
      LMP".
      
      Change-Id: I7fab23c12d4c797a6d339a16e497b79a3afe9df1
      7b221d97
    • R
      Fix for Minikin native crash · 0297ee98
      Raph Levien 提交于
      The context start offset wasn't being taken into account for
      accumulating the advance values, leading in some cases to array index
      overflow.
      
      This is a fix for bug 15327918 "SIGSEGV in
      android::MinikinFontSkia::GetSkTypeface()"
      
      Change-Id: I9b646785724c9b72d862b822cd84661c106fbe52
      0297ee98
  3. 27 5月, 2014 4 次提交
    • R
      Fix for bug 15252902 native crash in Minikin · 7c382381
      Raph Levien 提交于
      This is a fix for bug 15252902 "Crash observed on keep launch or
      existing youtube app after playing video". It was doing the test for a
      null font after trying to resolve the font in a cache, which caused a
      crash when there was no font for the run. This patch just tests before
      cache lookup.
      
      Change-Id: Iee41f7ce6b69cb09438462b6aaa916f242da7b77
      7c382381
    • R
      Caching for layouts and harfbuzz faces · 4d4e6bc8
      Raph Levien 提交于
      This patch adds caching for both layouts and for HarfBuzz face objects.
      The granularity of the cache for layouts is words, so it splits the
      input string at word boundaries (using a heuristic). There are is also
      some refactoring to reduce the amount of allocation and copying, and
      movement towards properly supporting contexts.
      
      The size of the caches is a fixed number of entries; thus, it is
      possible to consume a large amount of memory by filling the cache with
      lots of large strings. This should be refined towards a scheme that
      bounds the total memory used by the cache.
      
      This patch fixes bug 15237293 "Regression: Measure performance is
      significantly slower with minikin".
      
      Change-Id: Ie8176857e2d78656ce5479a7c04969819ef2718d
      4d4e6bc8
    • R
      d973b392
    • R
      Do BiDi algorithm for text layout · 86fa46c5
      Raph Levien 提交于
      This is a fix for bug 15130102 "Language name for Hebrew displayed the
      wrong way around on keyboard".
      
      This patch extends the previous BiDi support (when the direction for the
      entire string was given by the caller) to run the BiDi algorithm
      (provided by ICU) over the string to break it into BiDi runs. Thus, it
      handles mixed LTR and RTL strings in a single layout, and also respects
      heuristics for inferring the paragraph direction from the string.
      
      Change-Id: Ia4b869de3c139c5a7d16b8ce7766870b98a815ea
      (cherry picked from commit 4b3a9411)
      86fa46c5
  4. 24 5月, 2014 1 次提交
    • R
      Fix native crash in Latin-1 typefaces · 72fe9422
      Raph Levien 提交于
      This is a fix for bug 15171911 Timely crashes (native crash in
      libminikin) when I go to add a new alarm
      
      This patch fixes an off-by-one error that caused typefaces with only one
      page of Unicode coverage (ASCII or Latin-1) to have nPages = 0 instead
      of the correct value of 1 in the corresponding FontCollection.
      
      Change-Id: Id8be0c9e5713b8af22d863992921ee6382416a34
      72fe9422
  5. 22 5月, 2014 2 次提交
  6. 21 5月, 2014 1 次提交
  7. 20 5月, 2014 3 次提交
  8. 15 5月, 2014 4 次提交
    • L
      Remove references to SkFloatToScalar. · a3998d4f
      Leon Scroggins III 提交于
      The macro has been deprecated, now that SkScalar is never fixed point.
      
      Fixes minikin build.
      
      Change-Id: I02838a7fa167c5cf58ad225f3f2f52659495492c
      a3998d4f
    • R
      Initial BiDi support · d231a4b0
      Raph Levien 提交于
      This patch contains a very basic implementation of BiDi. It respects the
      BiDi flags passed in as an explicit parameter (through the
      "-minikin-bidi" pseudo-CSS property), but doesn't yet do its own BiDi
      run detection. It also takes some shortcuts (marked as TODO) that are
      based on reasonable assumptions of the current font stack, but not
      universally valid.
      
      Even with these shortcomings, it seems to display RTL text from TextView
      correctly.
      
      Change-Id: I223433923c4eb06f90c0327e86bfbe0aff71d4f5
      d231a4b0
    • R
      Fix 64-bit cleanliness problem · 0a689bb9
      Raph Levien 提交于
      This patch fixes a problem where int and ssize_t were being conflated.
      
      Change-Id: I642a4ee1d59d81723034fdfe33bd8ca29a5dc322
      0a689bb9
    • R
      Fix build breakage in sample code · d133eab2
      Raph Levien 提交于
      This updates the Skia sample implementation to implement GetBounds,
      but the FreeType implementation is NYI (to be fixed in future commit).
      
      Change-Id: I24eda14d5fb11c2a1e81394ad8c779de3292dd79
      d133eab2
  9. 13 5月, 2014 2 次提交
    • R
      Better refcounting and locking · b80c1f19
      Raph Levien 提交于
      All major externally accessible objects (especially FontFamily and
      FontCollection) are now reference counted. In addition, there is a
      global lock intended to make operations thread-safe.
      
      WIP notice: in this version of the patch, not all external API entry
      points are protected by the lock. That should be fixed.
      
      Change-Id: I14106196e99eb101e8bf1bcb4b81359759d2086c
      b80c1f19
    • R
      A basket of features: itemization, bounds, refcount · ecc2d34a
      Raph Levien 提交于
      This patch improves script run itemization and also exposes metrics
      and bounds for layouts. In addition, there is a fair amount of internal
      cleanup, including ref counting, and making the MinikinFont abstraction
      strong enough to support both FreeType and Skia implementations. There
      is also a sample implementation using Skia, in the sample directory.
      
      As part of its functionality, his patch measures the bounds of the
      layout and gives access through Layout::GetBounds().  The corresponding
      method is not implemented in the FreeType-only implementation of
      MinikinFont, so that will probably have to be fixed.
      
      Change-Id: Ib1a3fe9d7c90519ac651fb4aa957848e4bb758ec
      ecc2d34a
  10. 12 9月, 2013 2 次提交
  11. 28 6月, 2013 1 次提交
  12. 15 6月, 2013 2 次提交
    • R
      Fix build breakage · f660ef9e
      Raph Levien 提交于
      The MinikinFont class was missing a destructor. The build error was
      not caught because incremental builds didn't see fit to relink after
      I deleted one of the source files (that contained the impl of this
      destructor).
      
      Change-Id: Ic72d56fe28316cd2b2f808910e34ca6f177a1220
      f660ef9e
    • R
      Introduce MinikinFont abstraction · bcc3dc5a
      Raph Levien 提交于
      This commit removes the direct dependency on FreeType and replaces it
      with a MinikinFont abstraction, which is designed to support both
      FreeType and Skia fonts (and possibly others in the future).
      
      Also adds a "total advance" to the Layout, with an API for retrieving
      it.
      
      Change-Id: If20f92db9a43fd15b0fe9794b761ba00fb21338c
      bcc3dc5a
  13. 26 4月, 2013 1 次提交
    • R
      Initial commit of Minikin library · 9cc9bbe1
      Raph Levien 提交于
      This is the initial draft of Minikin, a library intended to perform text
      layout functions. This version does basic weight selection and font runs
      for scripts, and also has a simple renderer for drawing into bitmaps,
      but is lacking measurement, line breaking, and a number of other
      important features. It also lacks caching and other performance
      refinements.
      
      Change-Id: I789a2e47d11d71202dc84b4751b51a5e2cd9c451
      9cc9bbe1
  14. 20 4月, 2013 1 次提交