- 06 6月, 2015 2 次提交
-
-
由 Hixie 提交于
- several places where we use a getter knowing that it will return a subclass of its declared type, even asserting that it does, but where the analyzer is worried that the getter might start returning a new value unexpectedly, solved by having a temporary local variable shadow the getter and asserting that it doesn't change value - many many places where we do this with parentData specifically, solved by type-erasing parentData. - a place where a mixin wants to be subclassing another class, and uses its methods, solved by saying that the mixin is abstract but implements the superclass R=abarth@chromium.org Review URL: https://codereview.chromium.org/1160923008
-
由 Adam Barth 提交于
Turns out Scaffold needs to hook _remove, so we need to rename it to remove to expose it outside fn2.dart. R=ianh@google.com Review URL: https://codereview.chromium.org/1160013007
-
- 05 6月, 2015 34 次提交
-
-
由 Benjamin Lerman 提交于
R=blundell@chromium.org Review URL: https://codereview.chromium.org/1153933003
-
由 Collin Jackson 提交于
R=abarth@chromium.org, eseidel@chromium.org, abarth Review URL: https://codereview.chromium.org/1157573012
-
由 Viktor Lidholt 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151793003
-
由 Eric Seidel 提交于
Fixed the mojo deploy script to no longer deploy mojo. mojo now uses a more sophisticated CDN, etc. Fixed old fn.dart to work again. :) Looks like it was victim of a mass rename. Fixed engine.cc to be able to handle navigating from WebView content to SkyView content. We can't handle the other direction yet, but we don't need to. /sky_home is written in the .sky system but all of our new examples are .dart (and thus SkyView). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1165003006
-
由 Adam Barth 提交于
We're having trouble shrinkwrapping text, so this CL sets an explicit size for the last sale and the change in price. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1164763006
-
由 Hixie 提交于
Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infinite() constructor to a constant. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158263005
-
由 Hixie 提交于
Include DETACHED, NEEDS-LAYOUT, and relayoutSubtreeRoot info in the debug output for the render tree R=chinmaygarde@google.com Review URL: https://codereview.chromium.org/1149083011
-
由 Adam Barth 提交于
RenderScaffold needs to attach and detach its children when asked. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1149893025
-
由 Hixie 提交于
Improve the RenderObject.toString() logic so that there's not blank lines everywhere and to generally be better. Adds sizes, positions, transforms, improves RenderParagraph's output. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1160233004
-
由 Eric Seidel 提交于
TBR=viktorl@google.com Review URL: https://codereview.chromium.org/1158273009
-
由 Eric Seidel 提交于
Does not work yet. R=ianh@google.com Review URL: https://codereview.chromium.org/1163973005
-
由 Adam Barth 提交于
This CL does a bunch of ground work for getting StockList ready for use in stocks2. It's still not quite working because of an interaction with Scaffold that we don't fully understand. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1148793005
-
由 Adam Barth 提交于
R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1166953005
-
由 Adam Barth 提交于
We should be asserting that old.root is a ContainerRenderObjectMixin because we're able to manipulate its child list. R=ianh@google.com Review URL: https://codereview.chromium.org/1169593002
-
由 Eric Seidel 提交于
The goal of this is to have a Renderer-layer abstraction around the Sky Engine c++ apis for drawing a shadow. R=mpcomplete@chromium.org Review URL: https://codereview.chromium.org/1146893004
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151533006
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1162623011
-
由 Hixie 提交于
This makes debugging the render tree a lot easier. Just print the node you care about, and you get an indented tree view of its subtree, including settings. New subclasses should implement the new virtual method debugDescribeSettings() to expose new settings. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1157993005
-
由 Adam Barth 提交于
This CL makes FixedHeightScrollable able to measure heights. In the DOM-based version, FixedHeightScrollable forced a synchronous layout in a microtask in order to measure the size of itself and its children. In the DOM-less version, we now require the subclass to tell us the item height and we measure our own height using a layout callback. R=ianh@google.com Review URL: https://codereview.chromium.org/1161063005
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1163913004
-
由 Hixie 提交于
https://www.dartlang.org/articles/style-guide/#names R=jackson@google.com Review URL: https://codereview.chromium.org/1158813004
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1169583002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1144933007
-
由 Adam Barth 提交于
In the future, we might want to extend this class to clip to a configurable rect in addition to clipping to its bounds. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1145263006
-
由 Hixie 提交于
Rename OneChildListRenderObjectWrapper to MultiChildRenderObjectWrapper to avoid the confusing similarity with OneChildRenderObjectWrapper. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1150543005
-
由 Viktor Lidholt 提交于
Adds support for transfer mode in Paint and SpriteNode classes. Adds support for opacity in sprites, and modifies example game. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1164633004
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1165983002
-
由 Adam Barth 提交于
We still need to add a clip and a way to integrate with layout, but those changes are more invasive and I'll do them in separate CLs. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1166983003
-
由 Matt Perry 提交于
The array should be in column-major format, in the format used by vector_math.dart. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1155193004
-
由 Hixie 提交于
Currently supports only solid borders, but of any colour and size, independently controlling each side. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1154903006
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1164073002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1165013003
-
由 Hixie 提交于
The root cause of the crash was threefold: - you can't enumerate enums, in dart; you have to enumerate their values. - RenderNodeWrapper was trying to call remove(child.root) on its root, but that's not something that all RenderNodes have - when a RenderNode was deparented, its relayoutSubtreeRoot wasn't removed, so the node ended up in an inconsistent state regarding its parent tree R=abarth@chromium.org Review URL: https://codereview.chromium.org/1151573020
-
由 Seth Ladd 提交于
Was removed in https://github.com/domokit/mojo/commit/1a396394dd951450f0ff5c2da81dced0ca18e8c8 R=eseidel@chromium.org, johnmccutchan@google.com Review URL: https://codereview.chromium.org/1159013011
-
- 04 6月, 2015 4 次提交
-
-
由 Adam Barth 提交于
The current copy is in //sky/sdk/lib. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1160393003
-
由 Hixie 提交于
R=jackson@google.com Review URL: https://codereview.chromium.org/1166523006
-
由 Eric Seidel 提交于
I also moved Icon back to using int, since double doesn't actually make sense for an icon pixel size. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1164023005
-
由 Adam Barth 提交于
The skydb tool is actually used to run many mojo apps that aren't related to Sky. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1164023004
-