Prepare an archive of artifacts consumed by `flutter tools` (#2699)

This enables the specification of a local engine (via `--local-engine`)
for flutter tools to use.

sky/build/sky_precompilation_sdk.gni → sky/build/sky_ios_sdk.gni

@@ -6,8 +6,8 @@ import("//build/config/templates/templates.gni")
 import("//sky/engine/bindings/bindings.gni")
 import("//sky/build/template.gni")
 
-template("sky_precompilation_sdk") {
-  assert(is_ios, "The precompilation SDK is only supported for iOS targets")
+template("sky_ios_sdk") {
+  assert(is_ios)
 
   assert(defined(invoker.sdk_name), "The SDK name must be defined")
 
@@ -39,7 +39,10 @@ template("sky_precompilation_sdk") {
     script = "//sky/tools/copy_dir.py"
 
     inputs = [ "$root_build_dir/Flutter.framework/Flutter" ]
-    outputs = [ "$root_build_dir/$sdk_dir/$tools_dir/Flutter.framework/Flutter" ]
+    outputs = [
+      "$sdk_dir",
+      "$sdk_dir/$tools_dir/Flutter.framework/Flutter"
+    ]
 
     args = [
       "--src",
@@ -58,7 +61,7 @@ template("sky_precompilation_sdk") {
     outputs = [  "$sdk_dir/$tools_dir/EmbedderEntryPoints"  ]
   }
 
-  copy("precompilation_xcode_scripts") {
+  copy("ios_xcode_scripts") {
     sources = [
       "//sky/build/SnapshotterInvoke",
       "//sky/build/PackagerInvoke",
@@ -105,7 +108,25 @@ template("sky_precompilation_sdk") {
     outputs = [  "$root_out_dir/{{source_file_part}}"  ]
   }
 
-  group(target_name) {
+  # This archive is only for local consumption by the tools. It is not suitable
+  # for distribution since it only contains artifacts for a single architecture.
+  # It is the responsibility of the buildbot to construct universal binaries
+  # to create an SDK archive suitable for distribution.
+  action("create_sdk_archive") {
+    script = "//sky/build/zip_directory.py"
+
+    archive_name = "FlutterXcode.zip"
+
+    sources = [ sdk_dir ]
+    outputs = [ "$root_out_dir/$archive_name" ]
+
+    args = [
+      "--input-directory",
+      rebase_path(sdk_dir, root_build_dir),
+      "--output-archive",
+      rebase_path("$root_out_dir/$archive_name", root_build_dir),
+    ]
+
     deps = [
       ":copy_flutter_framework",
       ":copy_sdk_xcode_harness",
@@ -113,7 +134,13 @@ template("sky_precompilation_sdk") {
       ":copy_user_editable_files",
       ":embedder_entry_points",
       ":flutter_xcconfig",
-      ":precompilation_xcode_scripts",
+      ":ios_xcode_scripts",
+    ]
+  }
+
+  group(target_name) {
+    deps = [
+      ":create_sdk_archive",
     ]
   }
 }

sky/build/zip_directory.py

+#!/usr/bin/env python
+#
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+'''Zips up an entire directory.'''
+
+import argparse
+import shutil
+import os
+
+def main():
+  parser = argparse.ArgumentParser(description=__doc__)
+
+  parser.add_argument('--input-directory',
+                      required=True,
+                      dest='input_dir',
+                      help='The input directory.')
+  parser.add_argument('--output-archive',
+                      required=True,
+                      dest='output',
+                      help='The path to the output archive.')
+
+  args = parser.parse_args()
+
+  input_dir = os.path.abspath(args.input_dir)
+  output = os.path.abspath(args.output)
+
+  if os.path.isfile(output):
+    os.remove(output)
+
+  temp_file = '%s' % output
+
+  shutil.make_archive(
+    temp_file,
+    'zip',
+    input_dir
+  )
+
+  shutil.move('%s.zip' % temp_file, output)
+
+
+if __name__ == '__main__':
+  main()

sky/shell/BUILD.gn

@@ -240,7 +240,7 @@ if (is_android) {
 } else if (is_ios) {
   import("//build/config/ios/rules.gni")
   import("//build/config/ios/ios_sdk.gni")
-  import("//sky/build/sky_precompilation_sdk.gni")
+  import("//sky/build/sky_ios_sdk.gni")
 
   shared_library("flutter_framework_dylib") {
     output_name = "Flutter"
@@ -388,7 +388,7 @@ if (is_android) {
     ]
   }
 
-  sky_precompilation_sdk("shell") {
+  sky_ios_sdk("shell") {
     sdk_name = "Flutter"
   }
 } else if (is_linux) {