未验证 提交 56f399a5 编写于 作者: C Chris Bracken 提交者: GitHub

Revert "Define SK_VULKAN for clang-tidy runs (#21927)" (#22012)

This breaks linting on other targets that include skia headers that do
ifdef checks on SK_VULKAN.

This reverts commit 25d8fa5a.
上级 638c1823
...@@ -28,11 +28,6 @@ https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter ...@@ -28,11 +28,6 @@ https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter
const String issueUrlPrefix = 'https://github.com/flutter/flutter/issues'; const String issueUrlPrefix = 'https://github.com/flutter/flutter/issues';
/// Symbol definitions passed to clang-tidy.
const List<String> clangTidyDefineArgs = <String>[
"-DSK_VULKAN", // See: https://github.com/flutter/flutter/issues/68331
];
class Command { class Command {
Directory directory = Directory(''); Directory directory = Directory('');
String command = ''; String command = '';
...@@ -51,7 +46,6 @@ String calcTidyArgs(Command command) { ...@@ -51,7 +46,6 @@ String calcTidyArgs(Command command) {
String result = command.command; String result = command.command;
result = result.replaceAll(RegExp(r'\S*clang/bin/clang'), ''); result = result.replaceAll(RegExp(r'\S*clang/bin/clang'), '');
result = result.replaceAll(RegExp(r'-MF \S*'), ''); result = result.replaceAll(RegExp(r'-MF \S*'), '');
result += ' ' + clangTidyDefineArgs.join(' ');
return result; return result;
} }
......
...@@ -2,6 +2,8 @@ ...@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68331
#include "vulkan_window.h" #include "vulkan_window.h"
#include <memory> #include <memory>
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册