Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
weixin_43355755
engine
提交
1a13dac5
E
engine
项目概览
weixin_43355755
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
1a13dac5
编写于
11月 10, 2020
作者:
Y
Yegor
提交者:
GitHub
11月 10, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Simplify API for scheduling Skia object deletions (#22409)
上级
af185be8
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
26 addition
and
21 deletion
+26
-21
lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart
lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart
+25
-19
lib/web_ui/lib/src/engine/canvaskit/skia_object_cache.dart
lib/web_ui/lib/src/engine/canvaskit/skia_object_cache.dart
+1
-2
未找到文件。
lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart
浏览文件 @
1a13dac5
...
...
@@ -1692,13 +1692,12 @@ List<SkDeletable> _skObjectDeleteQueue = <SkDeletable>[];
final
SkObjectFinalizationRegistry
skObjectFinalizationRegistry
=
SkObjectFinalizationRegistry
(
js
.
allowInterop
((
SkDeletable
deletable
)
{
_skObjectDeleteQueue
.
add
(
deletable
);
_skObjectCollector
??=
_scheduleSkObjectCollection
();
_scheduleSkObjectCollection
(
deletable
);
}));
/// Schedules a
n asap timer to delete garbage-collected Skia objects
.
/// Schedules a
Skia object for deletion in an asap timer
.
///
///
We use a timer
for the following reasons:
///
A timer is used
for the following reasons:
///
/// - Deleting the object immediately may lead to dangling pointer as the Skia
/// object may still be used by a function in the current frame. For example,
...
...
@@ -1709,21 +1708,28 @@ final SkObjectFinalizationRegistry skObjectFinalizationRegistry =
/// - A microtask, while solves the problem above, would prevent the event from
/// yielding to the graphics system to render the frame on the screen if there
/// is a large number of objects to delete, causing jank.
Timer
_scheduleSkObjectCollection
(
)
=>
Timer
(
Duration
.
zero
,
()
{
html
.
window
.
performance
.
mark
(
'SkObject collection-start'
);
final
int
length
=
_skObjectDeleteQueue
.
length
;
for
(
int
i
=
0
;
i
<
length
;
i
++)
{
_skObjectDeleteQueue
[
i
].
delete
();
}
_skObjectDeleteQueue
=
<
SkDeletable
>[];
// Null out the timer so we can schedule a new one next time objects are
// scheduled for deletion.
_skObjectCollector
=
null
;
html
.
window
.
performance
.
mark
(
'SkObject collection-end'
);
html
.
window
.
performance
.
measure
(
'SkObject collection'
,
'SkObject collection-start'
,
'SkObject collection-end'
);
});
///
/// Because scheduling a timer is expensive, the timer is shared by all objects
/// deleted this frame. No timer is created if no objects were scheduled for
/// deletion.
void
_scheduleSkObjectCollection
(
SkDeletable
deletable
)
{
_skObjectDeleteQueue
.
add
(
deletable
);
_skObjectCollector
??=
Timer
(
Duration
.
zero
,
()
{
html
.
window
.
performance
.
mark
(
'SkObject collection-start'
);
final
int
length
=
_skObjectDeleteQueue
.
length
;
for
(
int
i
=
0
;
i
<
length
;
i
++)
{
_skObjectDeleteQueue
[
i
].
delete
();
}
_skObjectDeleteQueue
=
<
SkDeletable
>[];
// Null out the timer so we can schedule a new one next time objects are
// scheduled for deletion.
_skObjectCollector
=
null
;
html
.
window
.
performance
.
mark
(
'SkObject collection-end'
);
html
.
window
.
performance
.
measure
(
'SkObject collection'
,
'SkObject collection-start'
,
'SkObject collection-end'
);
});
}
/// Any Skia object that has a `delete` method.
@JS
()
...
...
lib/web_ui/lib/src/engine/canvaskit/skia_object_cache.dart
浏览文件 @
1a13dac5
...
...
@@ -316,8 +316,7 @@ class SkiaObjectBox {
assert
(
removed
);
_isDeleted
=
true
;
if
(
_refs
.
isEmpty
)
{
_skObjectDeleteQueue
.
add
(
skObject
);
_skObjectCollector
??=
_scheduleSkObjectCollection
();
_scheduleSkObjectCollection
(
skObject
);
}
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录