Remove support for the —enable-checked-mode flag from the engine. (#2987)

common/settings.h

@@ -18,7 +18,6 @@ struct Settings {
   // on the target with the port after it has been selected.
   uint32_t observatory_port = 0;
   bool start_paused = false;
-  bool enable_dart_checked_mode = false;
   bool trace_startup = false;
   bool endless_trace_buffer = false;
   std::string aot_snapshot_path;

runtime/dart_init.cc

@@ -522,13 +522,6 @@ void SetRegisterNativeServiceProtocolExtensionHook(
   g_register_native_service_protocol_extensions_hook = hook;
 }
 
-static bool ShouldEnableCheckedMode() {
-  // Checked mode is never enabled during precompilation. Even snapshot
-  // generation disables checked mode arguments.
-  return IsRunningPrecompiledCode() ? false
-                                    : Settings::Get().enable_dart_checked_mode;
-}
-
 void PushBackAll(std::vector<const char*>* args,
                  const char** argv,
                  size_t argc) {
@@ -572,8 +565,11 @@ void InitDartVM() {
                 arraysize(kDartPrecompilationArgs));
   }
 
-  if (ShouldEnableCheckedMode())
+  if (!IsRunningPrecompiledCode()) {
+    // Enable checked mode if we are not running precompiled code. We run non-
+    // precompiled code only in the debug product mode.
     PushBackAll(&args, kDartCheckedModeArgs, arraysize(kDartCheckedModeArgs));
+  }
 
   if (settings.start_paused)
     PushBackAll(&args, kDartStartPausedArgs, arraysize(kDartStartPausedArgs));

sky/shell/shell.cc

@@ -149,8 +149,6 @@ void Shell::InitStandalone(std::string icu_data_path) {
     }
   }
   settings.start_paused = command_line.HasSwitch(switches::kStartPaused);
-  settings.enable_dart_checked_mode =
-      command_line.HasSwitch(switches::kEnableCheckedMode);
   settings.endless_trace_buffer =
       command_line.HasSwitch(switches::kEndlessTraceBuffer);
   settings.trace_startup = command_line.HasSwitch(switches::kTraceStartup);

sky/shell/switches.cc

@@ -18,7 +18,6 @@ const char kAotVmIsolateSnapshot[] = "vm-isolate-snapshot";
 const char kCacheDirPath[] = "cache-dir-path";
 const char kDartFlags[] = "dart-flags";
 const char kDeviceObservatoryPort[] = "observatory-port";
-const char kEnableCheckedMode[] = "enable-checked-mode";
 const char kEndlessTraceBuffer[] = "endless-trace-buffer";
 const char kFLX[] = "flx";
 const char kHelp[] = "help";
@@ -32,7 +31,6 @@ const char kTraceStartup[] = "trace-startup";
 void PrintUsage(const std::string& executable_name) {
   // clang-format off
   std::cerr << "Usage: " << executable_name
-            << " --" << kEnableCheckedMode
             << " --" << kNonInteractive
             << " --" << kStartPaused
             << " --" << kTraceStartup

sky/shell/switches.h

@@ -19,7 +19,6 @@ extern const char kAotVmIsolateSnapshot[];
 extern const char kCacheDirPath[];
 extern const char kDartFlags[];
 extern const char kDeviceObservatoryPort[];
-extern const char kEnableCheckedMode[];
 extern const char kEndlessTraceBuffer[];
 extern const char kFLX[];
 extern const char kHelp[];