提交 ca8850cc 编写于 作者: J Jerry Zhang

Merge pull request #7 from...

Merge pull request #7 from DevFactory/release/synchronized-classes-vector,hashtable,stack-and-stringBuffer-should-not-be-used-fix-1

squid:S1149 - Synchronized classes Vector, Hashtable, Stack and Strin…
...@@ -16,7 +16,7 @@ public class ObjectClassesType { ...@@ -16,7 +16,7 @@ public class ObjectClassesType {
@Override @Override
public String toString() { public String toString() {
StringBuffer sb = new StringBuffer(); StringBuilder sb = new StringBuilder();
for (ObjectClass item : objectClasses) { for (ObjectClass item : objectClasses) {
sb.append(item); sb.append(item);
} }
......
...@@ -17,7 +17,7 @@ public class RequestStatusListType { ...@@ -17,7 +17,7 @@ public class RequestStatusListType {
@Override @Override
public String toString() { public String toString() {
StringBuffer s = new StringBuffer(); StringBuilder s = new StringBuilder();
for (RequestStatus r: requestStatuses){ for (RequestStatus r: requestStatuses){
s.append(r); s.append(r);
} }
......
...@@ -76,7 +76,7 @@ public class ScheduleFileUpdator { ...@@ -76,7 +76,7 @@ public class ScheduleFileUpdator {
private String appendCommitMessage(RequestStatus status) { private String appendCommitMessage(RequestStatus status) {
StringBuffer s = new StringBuffer(); StringBuilder s = new StringBuilder();
s.append("Final approval of MO CR "); s.append("Final approval of MO CR ");
s.append(status.getmocrid()); s.append(status.getmocrid());
s.append(" for "); s.append(" for ");
......
...@@ -153,7 +153,7 @@ public class ObjectClassFormController { ...@@ -153,7 +153,7 @@ public class ObjectClassFormController {
} }
private String constructMailText(@ModelAttribute("userinfo") UserInfo userinfo, @ModelAttribute("mocrid") String mocrid) { private String constructMailText(@ModelAttribute("userinfo") UserInfo userinfo, @ModelAttribute("mocrid") String mocrid) {
StringBuffer textsb = new StringBuffer(); StringBuilder textsb = new StringBuilder();
textsb.append("Hi,\r\n\r\nThese MO CR's shall be approved if no other comments.\r\nIf you have any comment, please comment on this page:\r\n"); textsb.append("Hi,\r\n\r\nThese MO CR's shall be approved if no other comments.\r\nIf you have any comment, please comment on this page:\r\n");
textsb.append("http://"); textsb.append("http://");
textsb.append(webHostname); textsb.append(webHostname);
...@@ -170,7 +170,7 @@ public class ObjectClassFormController { ...@@ -170,7 +170,7 @@ public class ObjectClassFormController {
} }
private String constructMailSubject(@ModelAttribute("mocrid") String mocrid, List<ObjectClass> objectClasses) { private String constructMailSubject(@ModelAttribute("mocrid") String mocrid, List<ObjectClass> objectClasses) {
StringBuffer subjectsb = new StringBuffer(); StringBuilder subjectsb = new StringBuilder();
subjectsb.append("Forthcoming approval of MO CR "); subjectsb.append("Forthcoming approval of MO CR ");
subjectsb.append(mocrid); subjectsb.append(mocrid);
subjectsb.append(" for "); subjectsb.append(" for ");
...@@ -181,7 +181,7 @@ public class ObjectClassFormController { ...@@ -181,7 +181,7 @@ public class ObjectClassFormController {
} }
private void constructDebugMessage(List<ObjectClass> objectClasses) { private void constructDebugMessage(List<ObjectClass> objectClasses) {
StringBuffer debugmessage = new StringBuffer(); StringBuilder debugmessage = new StringBuilder();
for (ObjectClass objcls : objectClasses) { for (ObjectClass objcls : objectClasses) {
debugmessage.append(objcls); debugmessage.append(objcls);
} }
......
...@@ -118,7 +118,7 @@ public class RequestStatusController { ...@@ -118,7 +118,7 @@ public class RequestStatusController {
} }
private String constructMailText(@ModelAttribute(REQUEST_STATUS) RequestStatus requestStatus, List<RequestStatus> requestStatuses, int index) { private String constructMailText(@ModelAttribute(REQUEST_STATUS) RequestStatus requestStatus, List<RequestStatus> requestStatuses, int index) {
StringBuffer textsb = new StringBuffer(); StringBuilder textsb = new StringBuilder();
textsb.append("New Comments: \r\n"); textsb.append("New Comments: \r\n");
textsb.append(requestStatus.getComments()); textsb.append(requestStatus.getComments());
textsb.append(" \r\n"); textsb.append(" \r\n");
...@@ -136,7 +136,7 @@ public class RequestStatusController { ...@@ -136,7 +136,7 @@ public class RequestStatusController {
} }
private String constructMailSubject(@ModelAttribute(REQUEST_STATUS) RequestStatus requestStatus) { private String constructMailSubject(@ModelAttribute(REQUEST_STATUS) RequestStatus requestStatus) {
StringBuffer subjectsb = new StringBuffer(); StringBuilder subjectsb = new StringBuilder();
subjectsb.append("MO CR:"); subjectsb.append("MO CR:");
subjectsb.append(requestStatus.getmocrid()); subjectsb.append(requestStatus.getmocrid());
subjectsb.append(" Updated"); subjectsb.append(" Updated");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册