提交 9529f6d7 编写于 作者: M Mohamed Ezzat

squid:S2325 - private methods that don't access instance data should be static

上级 ca8850cc
...@@ -88,7 +88,7 @@ public class ScheduleFileUpdator { ...@@ -88,7 +88,7 @@ public class ScheduleFileUpdator {
return s.toString(); return s.toString();
} }
private void setCommitDateAndStatus(Date currentTime, List<RequestStatus> requestStatuses, RequestStatus status) { private static void setCommitDateAndStatus(Date currentTime, List<RequestStatus> requestStatuses, RequestStatus status) {
int requestStatusIndex; int requestStatusIndex;
requestStatusIndex = requestStatuses.indexOf(status); requestStatusIndex = requestStatuses.indexOf(status);
requestStatuses.get(requestStatusIndex).setCommitDate(currentTime); requestStatuses.get(requestStatusIndex).setCommitDate(currentTime);
......
...@@ -180,7 +180,7 @@ public class ObjectClassFormController { ...@@ -180,7 +180,7 @@ public class ObjectClassFormController {
return subjectsb.toString(); return subjectsb.toString();
} }
private void constructDebugMessage(List<ObjectClass> objectClasses) { private static void constructDebugMessage(List<ObjectClass> objectClasses) {
StringBuilder debugmessage = new StringBuilder(); StringBuilder debugmessage = new StringBuilder();
for (ObjectClass objcls : objectClasses) { for (ObjectClass objcls : objectClasses) {
debugmessage.append(objcls); debugmessage.append(objcls);
......
...@@ -124,7 +124,7 @@ public class ObjectClassesController { ...@@ -124,7 +124,7 @@ public class ObjectClassesController {
} }
} }
private int isInteger(String s) { private static int isInteger(String s) {
int i; int i;
try { try {
i = Integer.parseInt(s); i = Integer.parseInt(s);
......
...@@ -75,14 +75,14 @@ public class ObjectClassXMLPaser { ...@@ -75,14 +75,14 @@ public class ObjectClassXMLPaser {
return objectClasses; return objectClasses;
} }
private ObjectClass setCommentToObject(Comment node) { private static ObjectClass setCommentToObject(Comment node) {
ObjectClass objectClass; ObjectClass objectClass;
objectClass = new ObjectClass(); objectClass = new ObjectClass();
objectClass.setComment(node.getData()); objectClass.setComment(node.getData());
return objectClass; return objectClass;
} }
private void setElementToObject(ObjectClass objectClass, Element node) { private static void setElementToObject(ObjectClass objectClass, Element node) {
objectClass.setId(node.getAttribute("id")); objectClass.setId(node.getAttribute("id"));
objectClass.setAbbreviation(node.getAttribute("abbrev")); objectClass.setAbbreviation(node.getAttribute("abbrev"));
objectClass.setIntclass(Integer.parseInt(node.getAttribute("intclass"))); objectClass.setIntclass(Integer.parseInt(node.getAttribute("intclass")));
...@@ -121,7 +121,7 @@ public class ObjectClassXMLPaser { ...@@ -121,7 +121,7 @@ public class ObjectClassXMLPaser {
} }
} }
private Element getElementOfObjectClass(ObjectClass objectClass, Document document) { private static Element getElementOfObjectClass(ObjectClass objectClass, Document document) {
Element e = document.createElement("objclass"); Element e = document.createElement("objclass");
e.setAttribute("id", objectClass.getId()); e.setAttribute("id", objectClass.getId());
e.setAttribute("intclass", String.valueOf(objectClass.getIntclass())); e.setAttribute("intclass", String.valueOf(objectClass.getIntclass()));
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册