framework: code clean

cyber/croutine/croutine.cc

@@ -19,6 +19,7 @@
 #include <utility>
 
 #include "cyber/base/concurrent_object_pool.h"
+#include "cyber/common/global_data.h"
 #include "cyber/common/log.h"
 #include "cyber/croutine/routine_context.h"
 #include "cyber/event/perf_event_cache.h"
@@ -41,12 +42,12 @@ void CRoutineEntry(void *arg) {
   r->Run();
   CRoutine::Yield(RoutineState::FINISHED);
 }
-}
+}  // namespace
 
 CRoutine::CRoutine(const std::function<void()> &func) : func_(func) {
   if (unlikely(context_pool == nullptr)) {
     auto routine_num = 100;
-    auto global_conf = common::GlobalData::Instance()->Config();
+    auto &global_conf = common::GlobalData::Instance()->Config();
     if (global_conf.has_scheduler_conf() &&
         global_conf.scheduler_conf().has_routine_num()) {
       routine_num = global_conf.scheduler_conf().routine_num();

cyber/croutine/croutine.h

@@ -76,7 +76,7 @@ class CRoutine {
   void set_id(uint64_t id);
 
   const std::string &name() const;
-  void set_name(std::string name);
+  void set_name(const std::string &name);
 
   int processor_id() const;
   void set_processor_id(int processor_id);
@@ -84,9 +84,6 @@ class CRoutine {
   uint32_t priority() const;
   void set_priority(uint32_t priority);
 
-  double proc_num() const;
-  void set_proc_num(double num);
-
  private:
   CRoutine(CRoutine &) = delete;
   CRoutine &operator=(CRoutine &) = delete;
@@ -103,7 +100,6 @@ class CRoutine {
   std::atomic_flag updated_ = ATOMIC_FLAG_INIT;
 
   bool force_stop_ = false;
-  double proc_num_ = 0.0;
 
   int processor_id_ = -1;
   uint32_t priority_ = 1;
@@ -135,7 +131,6 @@ inline void CRoutine::SetMainContext(
 }
 
 inline RoutineContext *CRoutine::GetContext() { return context_.get(); }
-RoutineState Resume();
 
 inline void CRoutine::Run() { func_(); }
 
@@ -158,7 +153,7 @@ inline void CRoutine::set_id(uint64_t id) { id_ = id; }
 
 inline const std::string &CRoutine::name() const { return name_; }
 
-inline void CRoutine::set_name(std::string name) { name_ = name; }
+inline void CRoutine::set_name(const std::string &name) { name_ = name; }
 
 inline int CRoutine::processor_id() const { return processor_id_; }
 
@@ -187,10 +182,6 @@ inline uint32_t CRoutine::priority() const { return priority_; }
 
 inline void CRoutine::set_priority(uint32_t priority) { priority_ = priority; }
 
-inline double CRoutine::proc_num() const { return proc_num_; }
-
-inline void CRoutine::set_proc_num(double num) { proc_num_ = num; }
-
 inline bool CRoutine::Acquire() {
   return !lock_.test_and_set(std::memory_order_acquire);
 }

cyber/croutine/routine_factory.h

@@ -30,10 +30,6 @@ namespace apollo {
 namespace cyber {
 namespace croutine {
 
-using common::GlobalData;
-using apollo::cyber::event::PerfEventCache;
-using apollo::cyber::event::SchedPerf;
-
 class RoutineFactory {
  public:
   using VoidFunc = std::function<void()>;