code clean

WORKSPACE.in

@@ -81,6 +81,13 @@ new_local_repository(
 #    url = "https://github.com/google/glog/archive/v0.4.0.tar.gz",
 #)
 
+# See https://github.com/bazelbuild/bazel/issues/11406
+#http_archive(
+#    name = "boringssl",
+#    sha256 = "fb236ae74676dba515e1230aef4cc69ab265af72fc08784a6755a319dd013ca6",
+#    urls = ["http://182.92.10.148:8310/archive/6.0/boringssl-83da28a68f32023fd3b95a8ae94991a07b1f6c62.tar.gz"],
+#)
+
 # grpc
 http_archive(
     name = "com_github_grpc_grpc",

modules/common/util/points_downsampler.h

@@ -93,7 +93,7 @@ std::vector<size_t> DownsampleByAngle(const Points &points,
     size_t start = 0;
     size_t end = 1;
     double accum_degree = 0.0;
-    while (end + 1 < points.size()) {
+    while (end + 1 < static_cast<size_t>(points.size())) {
       const double angle = GetPathAngle(points, start, end);
       accum_degree += std::fabs(angle);
 

modules/dreamview/backend/data_collection_monitor/BUILD

@@ -31,8 +31,8 @@ cc_test(
     deps = [
         ":data_collection_monitor",
         "//modules/common/util:json_util",
-        "@com_google_googletest//:gtest_main",
         "@boost",
+        "@com_google_googletest//:gtest_main",
     ],
 )
 

modules/dreamview/backend/point_cloud/BUILD

@@ -15,8 +15,8 @@ cc_library(
         "//modules/dreamview/backend/handlers:websocket_handler",
         "//modules/dreamview/backend/simulation_world:simulation_world_updater",
         "//modules/dreamview/proto:point_cloud_cc_proto",
-        "//modules/drivers/proto:sensor_image_cc_proto",
         "//modules/drivers/proto:pointcloud_cc_proto",
+        "//modules/drivers/proto:sensor_image_cc_proto",
         "//modules/localization/proto:localization_cc_proto",
         "//third_party:boost",
         "//third_party/json",

modules/dreamview/backend/simulation_world/simulation_world_service.h

@@ -294,8 +294,8 @@ class SimulationWorldService {
       return;
     }
 
-    for (size_t i = 0; i + 1 < points.size(); i += downsampleInterval) {
-      *downsampled_points->Add() = points[static_cast<int>(i)];
+    for (int i = 0; i + 1 < points.size(); i += downsampleInterval) {
+      *downsampled_points->Add() = points[i];
     }
 
     // add the last point

modules/map/pnc_map/BUILD

@@ -49,10 +49,10 @@ cc_library(
     copts = ["-DMODULE_NAME=\\\"map\\\""],
     deps = [
         "//modules/common/vehicle_state/proto:vehicle_state_cc_proto",
-        "//modules/routing/proto:routing_cc_proto",
         "//modules/map/hdmap",
         "//modules/map/pnc_map:path",
         "//modules/routing/common:routing_gflags",
+        "//modules/routing/proto:routing_cc_proto",
     ],
 )
 

tools/bazel.rc

@@ -76,10 +76,7 @@ build --copt="-Werror=return-type"
 build --copt="-Werror=unused-variable"
 build --copt="-Werror=unused-but-set-variable"
 build --copt="-Werror=switch"
-# TODO(changh726): disable the following line temporarily as
-# modules/dreamview/backend/simulation_world/ \
-# simulation_world_service.cc:224: can't compile
-#build --cxxopt="-Werror=sign-compare"
+build --cxxopt="-Werror=sign-compare"
 build --cxxopt="-Werror=reorder"
 
 # Enable C++14