- 07 11月, 2020 2 次提交
-
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
- 06 11月, 2020 31 次提交
-
-
由 Anmol Sethi 提交于
Unfortunately we can't use node-mocks-http to test a express.Router that has async routes. See https://github.com/howardabrams/node-mocks-http/issues/225 router will just return undefined if the executing handler is async and so the test will have no way to wait for it to complete. Thus, we have to use supertest which starts an actual HTTP server in the background and uses a HTTP client to send requests.
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
Makes typing much easier. Addresse's Will's last comment.
-
由 Anmol Sethi 提交于
Next commit will address Will's comments about the typings being weird.
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
Addresses Will's comments.
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
More clear.
-
由 Anmol Sethi 提交于
See my discussion with Will in the PR.
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
Will work on testing overlay next.
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Anmol Sethi 提交于
-
由 Asher 提交于
Also type the status.
-
由 Asher 提交于
This matches better with the other routes. Also add a missing authentication check to the path proxy web socket.
-
由 Asher 提交于
It will now redirect all HTML requests. Also it avoids req.accepts since that's always truthy.
-
由 Asher 提交于
Previously it would have just given them the error HTML.
-
由 Asher 提交于
I added another reject that doesn't destroy the response.
-
由 Asher 提交于
This is mostly so we don't have to do any wacky patching but it also makes it so we don't have to keep checking if the request is a web socket request every time we add middleware.
-
由 Asher 提交于
Now async routes are handled!
-
由 Asher 提交于
This lets us actually wait for disposal before a graceful exit.
-
- 05 11月, 2020 7 次提交