Merge pull request #2374 from cdr/lint-vscode-c2c2

vscode: Make eslint pass

ci/dev/lint.sh

@@ -11,6 +11,11 @@ main() {
   if command -v helm && helm kubeval --help > /dev/null; then
     helm kubeval ci/helm-chart
   fi
+
+  cd lib/vscode
+  # Run this periodically in vanilla VS code to make sure we don't add any more warnings.
+  yarn eslint --max-warnings=3
+  cd "$OLDPWD"
 }
 
 main "$@"

ci/steps/fmt.sh

@@ -7,7 +7,7 @@ main() {
   yarn --frozen-lockfile
 
   git submodule update --init
-  # We do not `yarn vscode` to make test.sh faster.
+  # We do not `yarn vscode` to make fmt.sh faster.
   # If the patch fails to apply, then it's likely already applied
   yarn vscode:patch &> /dev/null || true
 

ci/steps/lint.sh

@@ -7,9 +7,8 @@ main() {
   yarn --frozen-lockfile
 
   git submodule update --init
-  # We do not `yarn vscode` to make test.sh faster.
-  # If the patch fails to apply, then it's likely already applied
-  yarn vscode:patch &> /dev/null || true
+  # We need to fetch VS Code's deps for lint dependencies.
+  yarn vscode
 
   yarn lint
 }