1. 11 3月, 2020 1 次提交
    • C
      pkg/proc,service: support linux/386 (#1884) · f3a191cd
      chainhelen 提交于
      Implement debugging function for 386 on linux with reference to AMD64.
      There are a few remaining problems that need to be solved in another time.
      
      1. The stacktrace of cgo are not exactly as expected.
      2. Not implement `core` for now.
      3. Not implement `call` for now. Can't not find `runtime·debugCallV1` or
         similar function in $GOROOT/src/runtime/asm_386.s.
      
      Update #20
      f3a191cd
  2. 10 3月, 2020 3 次提交
  3. 06 3月, 2020 1 次提交
  4. 05 3月, 2020 1 次提交
  5. 04 3月, 2020 1 次提交
  6. 03 3月, 2020 1 次提交
  7. 01 3月, 2020 3 次提交
    • D
      service/api: Refactor examine memory pretty printer · 241f2422
      Derek Parker 提交于
      Use strings.Builder and tabwriter to format the output of the examine
      memory command instead of doing direct string manipulation and
      allocating.
      241f2422
    • D
      *: Add Go 1.14 to test matrix · 6319d50e
      Derek Parker 提交于
      This also removes Go 1.11 from the test matrix.
      
      Now that 1.14 has been released, as always it should be included in the
      test matrix.
      6319d50e
    • J
      proc/native/linux: try to use process_vm_readv/writev · d0d2d478
      Josh Stone 提交于
      This change adds `ProcessVmRead` and `ProcessVmWrite` wrappers around
      the syscalls `process_vm_readv` and `process_vm_writev`, available since
      Linux 3.2. These follow the same permission model as `ptrace`, but they
      don't actually require being attached, which means they can be called
      directly from any thread in the debugger. They also use `iovec` to write
      entire blocks at once, rather than having to peek/poke each `uintptr`.
      
      These wrappers are used in `Thread.ReadMemory` and `WriteMemory`, still
      falling back to `ptrace` if that fails for any reason.  Notably,
      `process_vm_writev` respects memory protection, so it can't modify
      read-only memory like `ptrace`. This frequently occurs when writing
      breakpoints in read-only `.text`, so to avoid a lot of wasted `EFAULT`
      calls, we only try `process_vm_writev` for larger writes.
      d0d2d478
  8. 29 2月, 2020 2 次提交
  9. 27 2月, 2020 3 次提交
  10. 26 2月, 2020 3 次提交
  11. 25 2月, 2020 6 次提交
    • A
      proc,service: allow printing registers for arbitrary frames (#1875) · d925f6b7
      Alessandro Arzilli 提交于
      Adds an optional scope prefix to the `regs` command which allows
      printing registers for any stack frame (as long as they were somehow
      saved). Issue #1838 is not yet to be closed since we are still not
      recovering the registers of a segfaulting frame.
      
      Updates #1838
      d925f6b7
    • A
      18678623
    • A
      proc/native: better error message when building on unsupported systems (#1883) · ade20a4d
      Alessandro Arzilli 提交于
      As we rearrange the code and the Go compiler changes the error message
      returned by the compiler on unsupported architectures will change too,
      making it un-googlable. Since the error message tends to be rather
      obscure too this regularly confuses newbies.
      
      This is an effort to make the error message for unsupported GOOS/GOARCH
      combinations the same across all unsupported combinations and to make
      it more user friendly.
      
      Directories containing Go source code are supposed to contain a single
      package. This property happens to be checked by cmd/go itself so it
      will happen even before the syntax is fully checked and therefore has a
      high probability of being the first (and only) error message being
      print.
      
      Here we take advantage of this by adding to the pkg/proc/native
      directory a file with a bad package line that only gets compiled in on
      unsupported GOOS/GOARCH combinations.
      
      At present the error message for compiling Delve on unsupported systems
      will be:
      
      service/debugger/debugger.go:21:2: found packages native (proc.go) and your_operating_system_and_architecture_combination_is_not_supported_by_delve (support_sentinel.go) in $PATH_TO_DELVE/pkg/proc/native
      ade20a4d
    • E
      service/dap: avoid hardcoded []byte slices in DAP tests (#1881) · 7f14f6ab
      Eli Bendersky 提交于
      * Remove hardcoded tests
      
      * Cleanup - consistent naming, simplify some code, remove unused func
      
      * Address review comments
      
      * Add Seq checks back
      
      * Address more review comments
      
      * Remove hardcoded tests
      
      * Cleanup - consistent naming, simplify some code, remove unused func
      
      * Address review comments
      
      * Add Seq checks back
      
      * Address more review comments
      
      * Make more consistent
      
      * More consistency
      
      * Simplify Except* methods with a helper
      
      Mark t.Helper() where appropriate
      7f14f6ab
    • C
      pkg/proc: Fix ThreadId when ErrNoGoroutine on g0 stack in GetG · d0b21fbb
      chainhelen 提交于
      Avoid always showing `no G executing on thread 0` when ErrNoGoroutine on
      g0 stack in GetG.
      d0b21fbb
    • K
      scripts: support macOS 10.15 or later · 9239013e
      Koichi Shiraishi 提交于
      macOS hasn't /usr/include/sys/types.h header with Canalina or later.
      switch types.h path to CommandLineTools if kernel minor version up to 15 or later.
      9239013e
  12. 22 2月, 2020 2 次提交
    • H
      service/dap: minor cosmetic changes (#1882) · 44c644cc
      Hyang-Ah Hana Kim 提交于
      - Move package doc comments so they are recognized as package doc.
      - Use t.Helper when appropriate.
      44c644cc
    • K
      dwarf/line: Fixed DirIdx (index starts at one) (#1873) · 17f2fa79
      Klemens Morgenstern 提交于
      * Fixed DirIdx (index starts at one)
      
      I am using the elf to load C++ based elf and there the index starts at one and not zero, hence the minor fix.
      
      * Added test
      
      * Added proper test for c-generated elf & replaced index offset by adding build dir
      
      * Changed other IncludeDir test
      
      * Format fix & replace print with actual test
      
      * Format fixes @derekparker requested.
      17f2fa79
  13. 21 2月, 2020 1 次提交
  14. 20 2月, 2020 2 次提交
  15. 19 2月, 2020 1 次提交
  16. 18 2月, 2020 2 次提交
    • O
      proc/core: implementing coredump functionality for ARM64 (#1774) · a83d1c14
      ossdev07 提交于
      * proc/native: optimize native.status through buffering (#1865)
      
      Benchmark before:
      
      BenchmarkConditionalBreakpoints-4              1        15649407130 ns/op
      
      Benchmark after:
      
      BenchmarkConditionalBreakpoints-4   	       1	14586710018 ns/op
      
      Conditional breakpoint evaluation 1.56ms -> 1.45ms
      
      Updates #1549
      
      * proc/core: Review Comments Incorporated
      Signed-off-by: Nossdev07 <ossdev@puresoftware.com>
      Co-authored-by: NAlessandro Arzilli <alessandro.arzilli@gmail.com>
      a83d1c14
    • A
      proc: optimize parseG (#1866) · ecea2e18
      Alessandro Arzilli 提交于
      runtime.g is a large and growing struct, we only need a few fields.
      Instead of using loadValue to load the full contents of g, cache its
      memory and then only load the fields we care about.
      
      Benchmark before:
      
      BenchmarkConditionalBreakpoints-4              1        14586710018 ns/op
      
      Benchmark after:
      
      BenchmarkConditionalBreakpoints-4   	       1	12476166303 ns/op
      
      Conditional breakpoint evaluation: 1.45ms -> 1.24ms
      
      Updates #1549
      ecea2e18
  17. 16 2月, 2020 2 次提交
    • A
      proc/native: optimize native.status through buffering (#1865) · c272212b
      Alessandro Arzilli 提交于
      Benchmark before:
      
      BenchmarkConditionalBreakpoints-4              1        15649407130 ns/op
      
      Benchmark after:
      
      BenchmarkConditionalBreakpoints-4   	       1	14586710018 ns/op
      
      Conditional breakpoint evaluation 1.56ms -> 1.45ms
      
      Updates #1549
      c272212b
    • P
      service/dap: Initial implementation for 'dlv dap' (#1858) · fbc4623c
      polinasok 提交于
      * Initial implementation for 'dlv dap'
      
      * Fix Travis and AppVeyor failures
      
      * Address review comments
      
      * Address review comments
      
      * Regenrate documentation
      
      * Replace dap server printfs with log.Error
      
      * Update 'dap log'
      
      * Fix typos
      
      * Revert logflags changes that got mixed in by accident
      fbc4623c
  18. 15 2月, 2020 1 次提交
  19. 14 2月, 2020 3 次提交
    • D
      proc/gdbserial: Reload thread registers on demand · a277b15d
      Derek Parker 提交于
      Instead of reloading the registers for every thread every time the
      process executes, reload the registers on demand for individual threads
      and memoize the result.
      a277b15d
    • C
      pkg,service: add cmd `examinemem`(`x`) for examining memory. (#1814) · a5d9dbee
      chainhelen 提交于
      According to #1800 #1584 #1038, `dlv` should enable the user to dive into
      memory. User can print binary data in specific memory address range.
      But not support for sepecific variable name or structures temporarily.(Because
      I have no idea that modify `print` command.)
      
      Close #1584.
      a5d9dbee
    • A
      proc: do not load g0 until it's needed when stacktracing (#1863) · 5b4f4a81
      Alessandro Arzilli 提交于
      The stacktrace code occasionally needs the value of g.m.g0.sched.sp to
      switch stacks. Since this is only needed rarely and calling parseG is
      relatively expensive we should delay doing it until we know it will be
      needed.
      
      Benchmark before:
      
      BenchmarkConditionalBreakpoints-4              1        17326345671 ns/op
      
      Benchmark after:
      
      BenchmarkConditionalBreakpoints-4   	       1	15649407130 ns/op
      
      Reduces conditional breakpoint latency from 1.7ms to 1.56ms.
      
      Updates #1549
      5b4f4a81
  20. 13 2月, 2020 1 次提交
    • A
      proc: only format registers value when it's necessary (#1860) · b9d0ddd8
      Alessandro Arzilli 提交于
      A significant amount of time is spent generating the string
      representation for the proc.Registers object of each thread, since this
      field is rarely used (only when the Registers API is called) it should
      be generated on demand.
      
      Also by changing the internal representation of proc.Register to be
      closer to that of op.DwarfRegister it will help us implement #1838
      (when Delve will need to be able to display the registers of an
      internal frame, which we currently represent using op.DwarfRegister
      objects).
      
      Benchmark before:
      
      BenchmarkConditionalBreakpoints-4   	       1	22292554301 ns/op
      
      Benchmark after:
      
      BenchmarkConditionalBreakpoints-4   	       1	17326345671 ns/op
      
      Reduces conditional breakpoint latency from 2.2ms to 1.7ms.
      
      Updates #1549, #1838
      b9d0ddd8