- 04 11月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
TestStepConcurrentDirect will occasionally fail (7% of the time on my setup) by either causing the target processs to execute an invalid instruction or (more infrequently) by switching to the wrong thread. Both of those are caused by receiving SIGTRAPs for threads hitting a breakpoint after it has been removed (the thread hits the breakpoint, we stop everything and remove the breakpoint and only after we receive the signal). Change native.(*nativeProcess).stop to handle SIGTRAPs that can't be attributed to a breakpoint, a hardcoded breakpoint in the program's text, or manual stops (and therefore are likely caused by phantom breakpoint hits). Co-authored-by: Na <a@kra>
-
- 03 11月, 2020 2 次提交
-
-
由 Alessandro Arzilli 提交于
Fixes #2219
-
由 Polina Sokolova 提交于
-
- 30 10月, 2020 1 次提交
-
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 22 10月, 2020 3 次提交
-
-
由 Alessandro Arzilli 提交于
-
由 Alessandro Arzilli 提交于
* service/rpccommon: log error for conns rejected by --only-same-user If no logger is enabled manually write to stderr instead. Fixes #2209 * logflags: fix style complaints from DeepSource
-
由 Alessandro Arzilli 提交于
Fixes #1847
-
- 20 10月, 2020 1 次提交
-
-
由 chainhelen 提交于
-
- 19 10月, 2020 1 次提交
-
-
由 chainhelen 提交于
1. Remove bug about unsupport systems, because we has pretty error msg. 2. Add usage for remote debugging. Relate: #1883, #1829, #861, #1332.
-
- 13 10月, 2020 4 次提交
-
-
由 Alessandro Arzilli 提交于
The test needs to set a breakpoint on main.CallFn after the prologue, on linux/386 this function does not have any instruction after the prologue on the function header line because it doesn't need to allocate space for local variables. Change the fixture so that this isn't a problem. This bug results on the test failing a small percentage of the time. Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
It returns an unexported type and is only used in a single place.
-
由 Alessandro Arzilli 提交于
Due to a missing check TestCgoStacktrace2 didn't actually check anything. Enable it and then skip it on linux/386 and linux/arm64 where it's broken. Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
If the process receives a signal (or sends a singal to itself) and then dies before we can route the signal back to it we still need to retrieve its exit status. Fixes a rare failure of TestIssue1101 in proc_test.go Co-authored-by: Na <a@kra>
-
- 07 10月, 2020 1 次提交
-
-
由 Suzy Mueller 提交于
* service/dap: add "panic" and "fatal error" as stopped reasons The unrecovered panic and fatal throw breakpoints are not set by the user. We now check for these special breakpoints and send appropriate stopped reasons to the client. * Add getter for StopReason * Set threadID and stop reason correctly If there is no selected goroutine, no goroutine ID should be set in the stopped event. The stopped reason can be better determined using the process StopReason. * Update panic breakpoint on next test to work with Go 1.13 runtime When running panic.go with Go1.13, the next line that is stepped to after panic('boom') is the defer function in the runtime package. The unrecovered panic breakpoint is not hit until after several steps. The test now steps until the breakpoint is hit, or the program terminates without hitting the unrecovered panic breakpoint, in which case it fails. * Skip breakpoint on next test in < Go 1.14
-
- 03 10月, 2020 1 次提交
-
-
由 polinasok 提交于
* Support clearing breakpoints and setting conditions * Return unverified breakpoints with errors Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 29 9月, 2020 1 次提交
-
-
由 polinasok 提交于
* Add underlying type when printing interface type * Add todo to remove one level from interface printing Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 28 9月, 2020 1 次提交
-
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 24 9月, 2020 4 次提交
-
-
由 Alessandro Arzilli 提交于
* proc/tests: keep track of tests skipped due to backend problems Mark tests skipped due to backend problems and add a script to keep track of them. * Travis-CI: add ignorechecksum option to chocolatey command Looks like a configuration problem on chocolatey's end.
-
由 Alessandro Arzilli 提交于
* proc: use argument position for addr only when injecting function calls We can not, in general, use the argument position to determine the address of a formal parameter, it will not work in presence of optimizations or inlining. In those cases formal arguments could be stored in registers. Fixes #2176 * Travis-CI: add ignorechecksum option to chocolatey command Looks like a configuration problem on chocolatey's end. Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
* dwarf/line: ignore end_of_sequence entry if AllPCsBetween Go 1.15 (but possibly prior versions of Go too) has a tendency to use an address in the middle of an instruction for this entry, but if it was correct it would be after the last instruction of the function anyway. This problem manifests especially frequently as a target crash in TestStepConcurrentPtr on linux/arm64 (~6% of the runs). * Travis-CI: add ignorechecksum option to chocolatey command Looks like a configuration problem on chocolatey's end. Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
* Travis-CI: add ignorechecksum option to chocolatey command Looks like a configuration problem on chocolatey's end. * service/*: remove threadID argument of (*Debugger).PackageVariables Which thread is used doesn't make any difference to the list of package variables that is returned and this option was only ever used by an old v1 API call.
-
- 16 9月, 2020 4 次提交
-
-
由 Alessandro Arzilli 提交于
* Revert "proc: Find executable should follow symbol links." This reverts commit 3e04ad0f. * proc: resolve symlinks when searching for split debug_info if path is /proc/pid/exe Fixes #2168
-
由 Eli Bendersky 提交于
Pulls in v0.3.0 of google/go-dap; this version has some fixes and API improvements which service/dap will be able to leverage to clean up some code.
-
由 Alessandro Arzilli 提交于
During the testing of the core dump generation feature two bugs were discovered in gdbserial: 1. we don't check that both bytes of the checksum are read, if the buffer only has one byte we can end up reading only one byte instead of two and the second byte will mess up the parsing of the next packet 2. binary encoded packets can start with an 'E' and not be errors, when using binary responses add an extra check for the lenght of the response before deciding that the response is an error. Unfortunately this encoding is inherently ambiguous (we can't distinguish a 3 byte response starting with 'E' from an error) so binary requests that lead to short responses should be avoided. Testing this is complicated, they will be tested implicitly by the upcoming core dump test. Co-authored-by: Na <a@kra>
-
由 polinasok 提交于
* Support global variables * Respond to review comments * Clarify comment * Add more details to test error messages * Remove flaky main..inittask checks * Rename globals flag to match vscode-go * Normalize filepath with slash separator * Improve handling for unknown package * Tweak error message * More refactoring, normalization and error details to deal with Win test failures * Clean up optional launch args processing * Add CurrentPackage to debugger and use instead of ListPackagesBuildInfo Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 11 9月, 2020 1 次提交
-
-
由 hitzhangjie 提交于
Adds a -size argument to examinemem that specifies how to group bytes on output.
-
- 10 9月, 2020 4 次提交
-
-
由 aarzilli 提交于
Move the conversion of some 'proc' types from service/debugger into service/rpc1 and service/rpc2. The methods of service/debugger.(*Debugger) are also used by service/dap which requires these types to be converted differently and converting them twice is inefficent and doesn't make much sense. Updates #2161
-
由 Alessandro Arzilli 提交于
Fixes #2134
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
由 Alessandro Arzilli 提交于
Since proc is supposed to work independently from the target architecture it shouldn't use architecture-dependent types, like uintptr. For example when reading a 64bit core file on a 32bit architecture, uintptr will be 32bit but the addresses proc needs to represent will be 64bit.
-
- 09 9月, 2020 1 次提交
-
-
由 chainhelen 提交于
`sameFrameCond` should not be constructed as one `And Express` when `sameGCond` which is the first child of `BinaryExpr` is nil. Fixes: #2162
-
- 02 9月, 2020 1 次提交
-
-
由 aarzilli 提交于
Adds features to support default file descriptor redirects for the target process: 1. A new command line flag '--redirect' and '-r' are added to specify file redirects for the target process 2. New syntax is added to the 'restart' command to specify file redirects. 3. Interactive instances will check if stdin/stdout and stderr are terminals and print a helpful error message if they aren't.
-
- 01 9月, 2020 5 次提交
-
-
由 aarzilli 提交于
An internal breakpoint condition shouldn't ever error: * use a ThreadContext to evaluate conditions if a goroutine isn't available * evaluate runtime.curg to a fake g variable containing only `goid == 0` when there is no current goroutine Fixes #2113
-
由 Alessandro Arzilli 提交于
Recent changes to the way registers are handled broke reporting of AVX registers (i.e. YMMx). This change restores the functionality by: - concatenating the higher half of the YMMx registers to their corresponding XMMx lower half (YMMx registers do not have an independent DWARF register number) - modifying the formatSSEReg function to handle them when they are present. Fixes #2033
-
由 Alessandro Arzilli 提交于
Match 'go test' behaviour and switch to package directory, unless one is specified with the '--wd' option. Fixes #2125
-
由 Alessandro Arzilli 提交于
Fixes #2126
-
由 Alessandro Arzilli 提交于
Fixes #2138
-
- 28 8月, 2020 2 次提交
-
-
由 Alessandro Arzilli 提交于
(*gdbThread).StepInstruction is a single call to stepInstruction so inline it.
-
由 Poh Zi How 提交于
* Update ClientHowto.md * Update ClientHowto.md
-
- 25 8月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
If OnlyAddr is not set pretty printing an interface will fail with an index out of bounds error.
-