1. 20 6月, 2018 1 次提交
    • A
      proc,command: fix optimized function warning in 1.9 · e19cbcef
      aarzilli 提交于
      A user complained on the mailing list about having continuous
      "optimized function warnings" on non-optimized functions when using 1.9.
      This commit fixes the problem by disabling optimized function detection
      on 1.9 and earlier (where it's impossible) and adds a test so we don't
      break it again in the future.
      e19cbcef
  2. 15 6月, 2018 2 次提交
    • A
      proc: allow "package/path".varname syntax · 2a2d1040
      aarzilli 提交于
      If the application being debugged imports two packages with the same
      name (but different paths) there was no way to disambiguate the two,
      since the character '/' can not appear inside a go identifier.
      
      By allowing users to use a string literal as the package name a package
      path can be specified.
      2a2d1040
    • A
      service,logflags: log all RPC messages · 454491ce
      aarzilli 提交于
      We occasionally receive bug reports from users of VSCode-go and GoLand.
      GoLand has its own way of capturing the packet exchange between itself
      and delve but VSCode-go (supposedly) doesn't.
      So far this hasn't been a problem since all bug reports were obvious
      bugs on the plugin or easy to reproduce without VSCode-go, but it might
      be helpful in the future to have a way to log the packet exchange
      between dlv and a frontend.
      
      This commit adds a --log-output option to enable logging of all rpc
      messages and changes service/rpccommon accordingly.
      454491ce
  3. 12 6月, 2018 10 次提交
  4. 09 6月, 2018 2 次提交
  5. 24 5月, 2018 4 次提交
    • S
      travis: install dwz package on linux tests · 33780e96
      Sergio Lopez 提交于
      33780e96
    • S
      proc_test: implement test for DWZ compressed DWARF · bafa5120
      Sergio Lopez 提交于
      If dwz binary is available in the system, test delve's ability to find
      deduplicated symbols in the DWARF information.
      
      dwzcompression.go contains a small C function (void fortytwo()) which
      calls glibc's fprintf with stdin as first argument. Normally, stdin
      will be present as a DW_TAG_variable as part of a DW_TAG_compile_unit
      named dwzcompression.cgo2.c.
      
      After running dwz on the binary, stdin is moved to a
      DW_TAG_partial_unit, which is imported from dwzcompression.cgo2.c with
      a DW_TAG_imported_unit.
      
      This test verifies that delve is able to find stdin symbol's type, as a
      way to confirm it understands dwz's compressed/deduplicated DWARF
      information.
      bafa5120
    • S
      proc/test/support: implement EnableDWZCompression · ed71248f
      Sergio Lopez 提交于
      The EnableDWZCompression flag allows tests to request BuildFixture to
      run "dwz" on the Fixture's resulting binary to compress/deduplicate its
      DWARF sections.
      ed71248f
    • S
      proc: add support for dwz compressed DWARF · 38307f92
      Sergio Lopez 提交于
      'dwz' is a tool that reduces the size of DWARF sections by
      deduplicating symbols. The deduplicated symbols are moved from their
      original 'compile unit' to a 'partial unit', which is then referenced
      from its original location with an 'imported unit' tag.
      
      In the case of Go binaries, all symbols are located in a single
      'compile unit', and the name of each symbol contains a reference to its
      package, so 'dwz' is not able to deduplicate them. But still, some C
      symbols included in the binary are deduplicated, which also alters the
      structure of the DWARF sections, making delve unable to parse them
      (crashing in the attempt).
      
      While it would've been possible to simply ignore the C symbols, or
      blindly loading all then into BinaryInfo members (packageVars,
      Functions...), for correctness sake this change tries to do the right
      thing, staging symbols into temporary partialUnit objects, moving them
      to BinaryInfo when they are actually requested  by a 'imported unit'
      tag.
      38307f92
  6. 23 5月, 2018 1 次提交
  7. 22 5月, 2018 1 次提交
  8. 19 5月, 2018 1 次提交
    • A
      proc/native,proc/gdbserial: let target access terminal · cc86bde5
      aarzilli 提交于
      Change the linux verison of proc/native and proc/gdbserial (with
      debugserver) so that they let the target process use the terminal when
      delve is launched in headless mode.
      
      Windows already worked, proc/gdbserial (with rr) already worked.
      I couldn't find a way to make proc/gdbserial (with lldb-server) work.
      
      No tests are added because I can't think of a way to test for
      foregroundness of a process.
      
      Fixes #65
      cc86bde5
  9. 16 5月, 2018 1 次提交
    • J
      Keep searching for file:line until found · c7cde8b1
      Jay Mundrawala 提交于
      Go seems to be generating multiple compilation units that have
      the same file. I think this happens for functions that get inlined.
      Without this patch, those inlined functions break the ability to set
      a breakpoint at other lines in the file. I was able to load the same
      binary in gdb and set a breakpoints throughout the file without issue.
      
      ```
      ➜ objdump --dwarf=decodedline automate-gateway | grep handler/users.go
      .../handler/users.go:[++]
      s/.../handler/users.go           20            0xb6dd88
      .../handler/users.go:[++]
      s/.../handler/users.go           20            0xb6e50f
      .../handler/users.go:[++]
      s/automate-gateway/handler/users.go           32            0xb66640
      ```
      
      Inlined functions are still a little weird. setting a breakpoint on
      a function that gets inlined picks the first occurence. That being
      said, I think delve should still do something reasonable for the rest
      of the lines in the file.
      c7cde8b1
  10. 10 5月, 2018 1 次提交
  11. 08 5月, 2018 1 次提交
  12. 05 5月, 2018 1 次提交
  13. 27 4月, 2018 1 次提交
  14. 24 4月, 2018 3 次提交
    • A
      proc: Flag shadowed arguments as shadowed · 7fd47749
      aarzilli 提交于
      Fixes #951
      7fd47749
    • A
      proc: cache entire frame in FrameToScope instead of variablesByTag · 21be5946
      aarzilli 提交于
      Caching the frame in variablesByTag is problematic:
      
      1. accounting for variables that are (partially) stored in registers is
      complicated (see issue #1106)
      2. for some types (strings, interfaces...) simply creating the Variable
      object reads memory, which therefore happens before we can do any
      caching.
      
      Instead cache the entire frame when the EvalScope object is created.
      The cached range is between the SP value of the current frame and the
      CFA of the preceeding frame, if available, or the CFA of the current
      frame otherwise.
      
      Fixes #1106
      21be5946
    • A
      proc: change memCache to delay reading · a5574bcd
      aarzilli 提交于
      Change memCache so that the preloaded memory is not read immediately
      but only after the actual read to the preloaded range.
      
      This allows us to request caching the entire stack frame every time we
      create an eval scope and no unnecessary reads will be made even if the
      user is just trying to evaluate a global variable.
      a5574bcd
  15. 20 4月, 2018 2 次提交
  16. 19 4月, 2018 1 次提交
  17. 18 4月, 2018 1 次提交
  18. 14 4月, 2018 4 次提交
    • A
      proc: Short circuit evaluation of && and || like go does · b9c4a1d6
      aarzilli 提交于
      Change evaluation of binary operators so that both && and || only
      evaluate their second argument conditionally, like go does.
      b9c4a1d6
    • A
      proc_test: instrument TestFrameEvaluation · e1f2626b
      aarzilli 提交于
      I've seen TestFrameEvaluation fail in CI in the past. It's been a while
      since the last time and I couldn't reproduce it locally at all. I'd
      like to have some instrumentation in case it happens again.
      e1f2626b
    • A
      terminal: make printcontext use SelectedGoroutine · 4f70ff0a
      aarzilli 提交于
      printcontext should use SelectedGoroutine instead of trusting that the
      goroutine running on current thread matches the SelectedGoroutine.
      
      When the user switches to a parked goroutine CurrentThread and
      SelectedGoroutine will diverge.
      
      Almost all calls to printcontext are safe, they happen after a continue
      command returns when SelectedGoroutine and CurrentThread always agree,
      but the calls in frameCommand and listCommand are wrong.
      
      Additionally we should stop reporting an error when the debugger is
      stopped on an unknown PC address.
      4f70ff0a
    • A
      4e177bb9
  19. 11 4月, 2018 2 次提交