1. 08 10月, 2019 6 次提交
  2. 26 9月, 2019 3 次提交
  3. 16 9月, 2019 2 次提交
    • A
      proc: correctly mark closure variables as shadowed (#1674) · e9940473
      Alessandro Arzilli 提交于
      If a closure captures a variable but also defines a variable of the
      same name in its root scope the shadowed flag would, sometimes, not be
      appropriately applied to the captured variable.
      
      This change:
      
      1. sorts the variable list by depth *and* declaration line, so that
      closure captured variables always appear before other root-scope
      variables, regardless of the order used by the compiler
      
      2. marks variable with the same name as shadowed even if there is only
      one scope at play.
      
      This fixes the problem but as a side effect:
      
      1. programs compiled with Go prior to version 1.9 will have the
      shadowed flag applied arbitrarily (previously the shadowed flag was not
      applied at all)
      2. programs compiled with Go prior to versoin 1.11 will still exhibit
      the bug, as they do not have DeclLine information.
      
      Fixes #1672
      e9940473
    • A
      travis: bump continuous integration to 1.13 (#1693) · 223eb4cb
      Alessandro Arzilli 提交于
      Bump continuous integration to include Go 1.13, drop 1.10 from
      compatiblity file.
      223eb4cb
  4. 13 9月, 2019 1 次提交
  5. 05 9月, 2019 2 次提交
    • C
      pkg/dwarf/frame/parser: Fix `parse augmentation` (#1679) · 69e6b613
      chainhelen 提交于
      According to the description of "CIE: length, CIE_id, version, augmentation"
      in Page 122 of  http://dwarfstd.org/doc/Dwarf3.pdf ,
      `augmentation` should exclude `version`
      69e6b613
    • H
      proc: round TLS segment size to its alignment (#1682) · 8954858e
      Heschi Kreinick 提交于
      The fix for #1428 was buggy, partly because I communicated poorly. Sorry
      about that.
      
      The size of the TLS segment should be padded such that TLS addresses
      are congruent in the file to where they will end up memory, i.e.
      (tlsoffset%align) == (vaddr%align). In most cases, vaddr will be aligned
      and it won't matter, but if not then simply aligning the end of the
      segment is incorrect. This should be right.
      
      (For the record, the current rounding logic is working in bits, but
      PtrSize is in bytes, so it wasn't working as originally intended
      either.)
      8954858e
  6. 28 8月, 2019 2 次提交
  7. 14 8月, 2019 5 次提交
  8. 13 8月, 2019 2 次提交
    • A
      proc: next/step/stepout restarts thread from wrong instruction (#1657) · 3b0c8865
      Alessandro Arzilli 提交于
      proc.Next and proc.Step will call, after setting their temp
      breakpoints, curthread.SetCurrentBreakpoint. This is intended to find
      if one of the newly created breakpoints happens to be at the same
      instruction that curthread is stopped at.
      However SetCurrentBreakpoint is intended to be called after a Continue
      and StepInstruction operation so it will also detect if curthread is
      stopped one byte after a breakpoint.
      If the instruction immediately preceeding the current instruction of
      curthread happens to:
       1. have one of the newly created temp breakpoints
       2. be one byte long
      SetCurrentBreakpoint will believe that we just hit that breakpoint and
      therefore the instruction should be repeated, and thus rewind the PC of
      curthread by 1.
      
      We should distinguish between the two uses of SetCurrentBreakpoint and
      disable the check for "just hit" breakpoints when inappropriate.
      
      Fixes #1656
      3b0c8865
    • D
      ecc62a0f
  9. 12 8月, 2019 1 次提交
  10. 10 8月, 2019 8 次提交
  11. 02 8月, 2019 2 次提交
    • A
      cmd/dlv: actually disable C compiler optimizations when building (#1647) · c9c455cc
      Alessandro Arzilli 提交于
      * proc: fix stacktraces when a SIGSEGV happens during a cgo call
      
      When a SIGSEGV happens in a cgo call (for example as a result of
      dereferencing a NULL pointer) the stack layout will look like this:
      
      (system stack) runtime.fatalthrow
      (system stack) runtime.throw
      (system stack) runtime.sigpanic
      (system stack) offending C function
      ... other C functions...
      (system stack) runtime.asmcgocall
      (goroutine stack) call inside cgo
      
      The code in switchStack would switch directly from the
      runtime.fatalthrow frame to the first frame in the goroutine stack,
      hiding important information.
      
      Disable this switch for runtime.fatalthrow and reintroduce the check
      for runtime.mstart that existed before this version of the code was
      implemented in commit 7bec20.
      
      This problem was reported in comment:
      https://github.com/go-delve/delve/issues/935#issuecomment-512182533
      
      * cmd/dlv: actually disable C compiler optimizations when building
      c9c455cc
    • A
      Documentation,cmd/dlv: tidy up --help output (#1649) · 2bd1cd3f
      Alessandro Arzilli 提交于
      * scripts: use relative path in gen-cli-docs.go
      
      Makes gen-cli-docs.go work outside GOPATH.
      
      * Documentation,cmd/dlv: tidy up --help output
      
      The description of --log-dest, --log-output and --backend is very
      verbose and messes up the output of --help, move it to two "additional
      help" subcommands.
      2bd1cd3f
  12. 01 8月, 2019 2 次提交
  13. 30 7月, 2019 2 次提交
    • D
      *: Add .cirrus.yml for FreeBSD testing (#1639) · f4eaad69
      Derek Parker 提交于
      * *: Add .cirrus.yml for FreeBSD testing
      
      * *: run go mod tidy
      
      * service/test: prefer 127.0.0.1 over localhost
      
      * dwarf/line: fix TestDebugLinePrologueParser
      
      * vendor: rerun go mod vendor
      f4eaad69
    • J
      terminal/command: add support for next [count] (#1629) · 1a478cdb
      Jeremy Faller 提交于
      * terminal/command: add support for next [count]
      
      * disallow negative counts.
      
      * handle github comments, and regen docs.
      
      * Fix the fact that we don't print the file info in the last step of the next count.
      
      * Fix a typo, cleanup a few other observations.
      1a478cdb
  14. 28 7月, 2019 1 次提交
  15. 27 7月, 2019 1 次提交