Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Add support for evaluateName for variables

* More evaluateName logic tweaks and tests

* Make DeepSource happy
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Use address, not index to differentiate compound map keys

* Clean up calls to expectVarRegex
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Support local attach

* Undo loopprog change

* Remove test check for system-specific error message

* Skip attach tests on freebasd
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Adds a flag that distinguishes the return values of an injected
function call from the return values of a function call executed by the
target program.

* service/dap: expand goroutine info in threads response

* Fix checks

* Make DeepSource happy
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Support evaluate request

* Fix failing tests

* Call support

* Remove debugger.CurrentThread() that got accidentally reintroduced during merge

* Address review comments

* Function to stringify stop reason

* Add resetHandlesForStop

* Handle stop inside call

* More tests

* Address review comments

* Check all threads to determine if call completed

* Fix test

* Fix test

* Fix test

* Address review comments
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* service/dap: add "panic" and "fatal error" as stopped reasons

The unrecovered panic and fatal throw breakpoints are not set by the
user. We now check for these special breakpoints and send appropriate
stopped reasons to the client.

* Add getter for StopReason

* Set threadID and stop reason correctly

If there is no selected goroutine, no goroutine ID should be set in
the stopped event.

The stopped reason can be better determined using the process
StopReason.

* Update panic breakpoint on next test to work with Go 1.13 runtime

When running panic.go with Go1.13, the next line that is stepped to
after panic('boom') is the defer function in the runtime package. The
unrecovered panic breakpoint is not hit until after several steps.

The test now steps until the breakpoint is hit, or the program terminates
without hitting the unrecovered panic breakpoint, in which case it fails.

* Skip breakpoint on next test in < Go 1.14

* Support clearing breakpoints and setting conditions

* Return unverified breakpoints with errors
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Add underlying type when printing interface type

* Add todo to remove one level from interface printing
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Travis-CI: add ignorechecksum option to chocolatey command

Looks like a configuration problem on chocolatey's end.

* service/*: remove threadID argument of (*Debugger).PackageVariables

Which thread is used doesn't make any difference to the list of package
variables that is returned and this option was only ever used by an old
v1 API call.

* Support global variables

* Respond to review comments

* Clarify comment

* Add more details to test error messages

* Remove flaky main..inittask checks

* Rename globals flag to match vscode-go

* Normalize filepath with slash separator

* Improve handling for unknown package

* Tweak error message

* More refactoring, normalization and error details to deal with Win test failures

* Clean up optional launch args processing

* Add CurrentPackage to debugger and use instead of ListPackagesBuildInfo
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Move the conversion of some 'proc' types from service/debugger into
service/rpc1 and service/rpc2. The methods of
service/debugger.(*Debugger) are also used by service/dap which
requires these types to be converted differently and converting them
twice is inefficent and doesn't make much sense.

Updates #2161

Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Issue stopped event on runtime error when continuing

* Support next, stepIn and stepOut

* Refactor stop logic

* Explicitely set AllThreadsContinued

* Make DeepSource happy

* Respond to review comments
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Initial support for scopes and variables requests

* Add detailed variables test

* Address review comments

* Fix typo and redudant escaped characters

* Bug fix for uninitialized interfaces; no refs needed for 0-size vars

* Minor cosmetic tweaks

* Add incomplete loading test

* Make DeepSource happy

* Remove unnecessary t.Helper() calls

* Update broken test after merge

* Add missing return

* Rework test harness to abort testvariables2 before stack overflow

* Remove accidentally duplicated disconnet

* Test for invalid interface type with regex

* Drop testvariables3, clean up and test unreadable case

* Respond to review comments

* Make expectVar test helper less fragile

* Make DeepSource happy

* Use proc.LoadConfig directly

* Adjust test to avoid var count discrepency between Go 1.15 and earlier

* Make compound keys in a map unique for correct display

* Remove locals num check that will break if more vars are added
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* service/dap: Support stackTraceDepth launch argument

* Respond to review comments

* Make DeepSource happy
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* service/dap: Support stackTrace request

* Minor tweaks

* Address review comments

* Fix grammar

* Address review comments

* Address review comments

* Update comments
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* service/dap: Add error checking and tests for buildFlags in launch requests

* Clarify with comments and better naming

* Undo redundant support.go changes

* Undo redundant support.go changes (attempt #2)
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Adds launch request support for program args

* Combine types of function parameters
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Add no-op handlers for unsupported requests

* Fix whitespace

* Add couple of missing unsupported requests

* More comments

* Separate errors for unsupported and not-yet-implemented requests.

* Fix go.mod/sum dependencies
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

Embed the debugger config object in the service config object to avoid needless duplication of fields.

This flag allows users on UNIX systems to set the tty for the program
being debugged by Delve. This is useful for debugging command line
applications which need access to their own TTY, and also for
controlling the output of the debugged programs so that IDEs may open a
dedicated terminal to show the output for the process.

Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* Add support for threads request

* Address review comments

* Relax threads test condition

* Address review comments

* Clean up unnecessary newline

* Respond to review comment
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* logflags: Add pid to server-listening-at message

* Address review comments: use logger
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>

* service/dap: Add support for debug and test modes

* Address code review comments

* Remove //dap comment

* OptFlags() => optfalgs()

* If mode => switch mode

Using a stop channel to signal clean shutdown to the server's
goroutines. Also updates the tests to trigger disconnectChan.

This helps avoid spurious error logs when the client disconnects, when
Ctrl+C is pressed, etc.

* Panic guard for DAP request handling

* Use GetSeq

* Re-vendor new version of go-dap

* Remove comment

* Update error message

* Reuse er.Message in Format

- Move package doc comments so they are recognized as package doc.
- Use t.Helper when appropriate.

* Initial implementation for 'dlv dap'

* Fix Travis and AppVeyor failures

* Address review comments

* Address review comments

* Regenrate documentation

* Replace dap server printfs with log.Error

* Update 'dap log'

* Fix typos

* Revert logflags changes that got mixed in by accident