1. 14 12月, 2017 1 次提交
  2. 08 12月, 2017 4 次提交
  3. 29 11月, 2017 4 次提交
    • A
      pkg/terminal: -offsets flag for stack command · 17bd4b52
      aarzilli 提交于
      Prints the frame and frame pointer offsets for each frame.
      17bd4b52
    • A
      proc: support cgo stacktraces · 5372588c
      aarzilli 提交于
      When creating a stack trace we should switch between the goroutine
      stack and the system stack (where cgo code is executed) as appropriate
      to reconstruct the logical stacktrace.
      
      Goroutines that are currently executing on the system stack will have
      the SystemStack flag set, frames of the goroutine stack will have a
      negative FrameOffset (like always) and frames of the system stack will
      have a positive FrameOffset (which is actually just the CFA value for
      the frame).
      
      Updates #935
      5372588c
    • A
      cmd, proc/test: disable optimizations on the C compiler · 5fdcd2c9
      aarzilli 提交于
      Pass CGO_FLAGS='-O0 -g' to go build to disable optimizations when
      calling the C compiler.
      5fdcd2c9
    • M
      Support --output for debug, trace, and test commands (#1028) · 6fe97fa7
      Martin Tournoij 提交于
      * Support --output for debug, trace, and test commands
      
      With the `--output` parameter you can configure the output binary. For
      example:
      
          dlv debug --output /tmp/xxx
      
      Will build the binary to `/tmp/xxx`, instead of always putting it as
      `debug` in the current directory.
      
      This ensures that the command always works (even if there is already a
      file or directory named `debug`) and doesn't write to the source
      directory. Especially for things like Delve/Vim integration this is a
      good thing to have, I think.
      
      * Address PR feedback and add a test
      
      - We don't need to use `filepath.IsAbs()` on startup; I added that
        because it previously did `"./" + debugname` everywhere, but I don't
        think that's needed at all, since `pathname` without a leading `./`
        implies the current directory.
      
      - Repurpose the existing `TestIssue398` to also test the `--output`
        flag. Also fix an issue where tests wouldn't work if `GOPATH` has
        multiple entries (e..g `GOPATH=$HOME/go:$HOME/mygocode`).
      
      - Print an error if we can't remove the debug binary on exit instead of
        failing silently. Not strictly related to this PR, but a good change
        to add I think.
      
      * Also warn when delve can't remove the binary in test/trace
      
      I only added that to debug, but good to issue this warning consistently.
      6fe97fa7
  4. 22 11月, 2017 3 次提交
  5. 21 11月, 2017 5 次提交
    • A
      pkg/proc: fix StepBreakpoint handling · bc86c662
      aarzilli 提交于
      StepBreakpoints are set on CALL instructions, when they are hit we
      disassemble the current instruction, figure out the destination address
      and set a breakpoint after the prologue of the called function.
      
      In order to disassemble the current instruction we disassemble the area
      of memory starting from PC and going to PC+15 (because 15 bytes is the
      maximum length of one instruction on AMD64). This means that we won't
      just disassemble one instruction but also a few instructions following
      it ending with one truncated instruction.
      
      This usually works fine but sometimes the disassembler will panic with
      an array out of bounds error when trying to disassemble a truncated
      instruction. To avoid this problem this commit changes the funciton
      disassemble to take one extra parameter, singleInstr, when singleInstr
      is set disassemble will quit after disassembling a single instruction.
      bc86c662
    • A
      proc: automatically dereference interfaces on member access · 5f0f77f4
      aarzilli 提交于
      If 'iv' is an interface variable with a struct as a concrete value let
      'iv.A' evaluate to the access to field 'A' of the concrete value of
      'iv'.
      5f0f77f4
    • A
      proc: support access to chan buffers · 844762a8
      aarzilli 提交于
      Replace the unsafe.Pointer type of the buf field of channels with the
      appropriate array type, allow expressions accessing member field of the
      channel struct.
      
      Fixes #962
      844762a8
    • A
      proc: next should not skip lines with conditional bps · 1ced7c3a
      aarzilli 提交于
      Conditional breakpoints with unmet conditions would cause next and step
      to skip the line.
      
      This breakpoint changes the Kind field of proc.Breakpoint from a single
      value to a bit field, each breakpoint object can represent
      simultaneously a user breakpoint and one internal breakpoint (of which
      we have several different kinds).
      
      The breakpoint condition for internal breakpoints is stored in the new
      internalCond field of proc.Breakpoint so that it will not conflict with
      user specified conditions.
      
      The breakpoint setting code is changed to allow overlapping one
      internal breakpoint on a user breakpoint, or a user breakpoint on an
      existing internal breakpoint. All other combinations are rejected. The
      breakpoint clearing code is changed to clear the UserBreakpoint bit and
      only remove the phisical breakpoint if no other bits are set in the
      Kind field. ClearInternalBreakpoints does the same thing but clearing
      all bits that aren't the UserBreakpoint bit.
      
      Fixes #844
      1ced7c3a
    • A
      proc: breakpoints refactoring · 178589a4
      aarzilli 提交于
      Move some duplicate code, related to breakpoints, that was in both
      backends into a single place.
      This is in preparation to solve issue #844 (conditional breakpoints
      make step and next fail) which will make this common breakpoint code
      more complicated.
      178589a4
  6. 18 11月, 2017 2 次提交
    • A
      pkg/proc: remove callFrameRegs from stackIterator · 8d34bb5b
      aarzilli 提交于
      Since it's just a scratchpad to calculate the new set of registers it
      makes more sense to have it as a local variable in Next and
      advanceRegs.
      8d34bb5b
    • A
      proc: refactor stack.go to use DWARF registers · f4e2000f
      aarzilli 提交于
      Instead of only tracking a few cherrypicked registers in stack.go track
      all DWARF registers.
      
      This is needed for cgo code and for the locationlists emitted by go in
      1.10:
      * The debug_frame sections emitted by C compilers can not be used
        without tracking all registers
      * the loclists emitted by go1.10 need all registers of a frame to be
        interpreted.
      f4e2000f
  7. 16 11月, 2017 2 次提交
  8. 04 11月, 2017 6 次提交
  9. 25 10月, 2017 1 次提交
    • A
      proc/eval: support more type casts · 8f16b371
      aarzilli 提交于
      * string to []rune
      * string to []byte
      * []rune to string
      * []byte to string
      * any pointer to uintptr
      
      The string, []rune, []byte conversion pairs aligns this to the go
      language.
      The pointer -> uintptr conversion pair is symmetric to the uintptr ->
      pointer that we already have.
      
      Also lets the user specify any size for byte array types instead of
      just the ones already used by the program, this can be used to read
      arbitrary memory.
      
      Fixes #548, #867
      8f16b371
  10. 21 10月, 2017 1 次提交
  11. 17 10月, 2017 1 次提交
  12. 26 9月, 2017 1 次提交
    • A
      proc: change next to skip deferred functions · 5c9b2009
      aarzilli 提交于
      Make 'next' skip deferred functions unless they are called via a panic.
      Call to a deferred function through 'return' are predictable, if the
      user wants to step into them 'step' can be used but without this change
      there is no way to avoid stepping into them.
      
      Implements #956
      5c9b2009
  13. 21 9月, 2017 1 次提交
    • A
      proc/gdbserial: return error if stopped with a sginal · 2c0e3116
      aarzilli 提交于
      On macOS we can also stop when we receive a signal,
      propagate this reason upwards to the client.
      
      Also clear internal breakpoints after an unrecovered-panic since they
      can not be reached anymore.
      
      Fixes #872
      2c0e3116
  14. 12 9月, 2017 1 次提交
  15. 09 9月, 2017 3 次提交
  16. 31 8月, 2017 3 次提交
  17. 15 8月, 2017 1 次提交