- 29 12月, 2020 2 次提交
-
-
由 Alessandro Arzilli 提交于
Waits for the target process to have received the kill signal in native.nativeProcess.kill. Fixes an infrequent error in TestKill.
-
由 nd 提交于
Sometimes it makes debuggee to hang. Should fix #2244
-
- 28 12月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
Fix bug in DAP test: TestEvaluateCallRequest. In Go 1.15 the call injection will be executed on a different goroutine from the goroutine where it was started on to avoid confusing the garbage collector, the test must be aware of this fact and use the goroutine ID from the stopped response instead of assuming 1 is the currently selected goroutine. Disables TestAttachDetach when running in Github Actions. Disable some coredump tests when running in Github Actions (core size limits?).
-
- 22 12月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
Change 24ec1754 (use CPUID to determine maximum size of XSAVE area) broke the linux/386 backend, this commit fixes it.
-
- 17 12月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
-
- 16 12月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
Do not call detach if the target is no longer valid. Fixes #2259 Co-authored-by: Na <a@kra>
-
- 15 12月, 2020 5 次提交
-
-
由 Alessandro Arzilli 提交于
the maximum size of the Xsave area was previously hardcoded but the CPUID instruction can be used to determine its maximum size.
-
由 Florin Pățan 提交于
This adds the WaitSince and WaitReason fields for the goroutines to allow the users to easily understand why a goroutine is waiting.
-
由 hitzhangjie 提交于
-
由 Alessandro Arzilli 提交于
-
由 Andrei Matei 提交于
The comment on the advanceRegs() method was referencing several nonexistent fields. This patch fixes that, and improves the comment to reference the peculiar interaction between the method and it.regs.
-
- 11 12月, 2020 3 次提交
-
-
由 Alessandro Arzilli 提交于
Fixes #852 Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
evalFunctionCall needs to remove the breakpoint from the current thread after starting the function call injection, otherwise Continue will think that the thread is stopped at a breakpoint and return to the user instead of continuing the call injection.
-
由 Alessandro Arzilli 提交于
Adds a flag that distinguishes the return values of an injected function call from the return values of a function call executed by the target program.
-
- 09 12月, 2020 2 次提交
-
-
由 aarzilli 提交于
Thank you to: @polinasok, @aurkenb, @pohzipohzi, @chainhelen, @hitzhangjie, @eliben, @suzmue, @andreimatei, @aaronsky.
-
由 Andrei Matei 提交于
Fix some stale comments and add some comments that I would have found useful.
-
- 05 12月, 2020 2 次提交
-
-
由 Alessandro Arzilli 提交于
This is needed to fix the problem we have with 1.15.4+ after the backport is applied to it. The DWARF standard isn't clear on what should happen with the end_of_sequence opcode but this is consistent with debug/dwarf.LineReader as well as gdb.
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 01 12月, 2020 2 次提交
-
-
由 polinasok 提交于
* service/dap: expand goroutine info in threads response * Fix checks * Make DeepSource happy Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 18 11月, 2020 1 次提交
-
-
由 Aaron Sky 提交于
* Use the active xcode-select path instead of a hardcoded Xcode path * Refactored exec.Command to invoke Output instead of running with a custom buffer for stdout Addresses review comment by @derekparker
-
- 17 11月, 2020 5 次提交
-
-
由 aarzilli 提交于
Change FindLocation to apply substitute path rules to location expressions. Changes terminal to always print paths after applying substitutions. Implements #2203
-
由 aarzilli 提交于
1. Forward stdin/stdout/stderr to the target process when in foreground mode instead of always forwarding the current tty (issue #1964) 2. When redirecting a file descriptor make sure to also specify something for all three otherwise debugserver will misbehave (either exit on launch or run but giving the target process a closed file descriptor). Fixes #1964
-
由 Alessandro Arzilli 提交于
-
-
由 Andrei Matei 提交于
This patch adds some comments around RequestManualStop().
-
- 13 11月, 2020 1 次提交
-
-
由 polinasok 提交于
* Support evaluate request * Fix failing tests * Call support * Remove debugger.CurrentThread() that got accidentally reintroduced during merge * Address review comments * Function to stringify stop reason * Add resetHandlesForStop * Handle stop inside call * More tests * Address review comments * Check all threads to determine if call completed * Fix test * Fix test * Fix test * Address review comments Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 10 11月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
On linux we can not read memory if the thread we use to do it is occupied doing certain system calls. The exact conditions when this happens have never been clear. This problem was worked around by using the Blocked method which recognized the most common circumstances where this would happen. However this is a hack: Blocked returning true doesn't mean that the problem will manifest and Blocked returning false doesn't necessarily mean the problem will not manifest. A side effect of this is issue #2151 where sometimes we can't read the memory of a thread and find its associated goroutine. This commit fixes this problem by always reading memory using a thread we know to be good for this, specifically the one returned by ContinueOnce. In particular the changes are as follows: 1. Remove (ProcessInternal).CurrentThread and (ProcessInternal).SetCurrentThread, the "current thread" becomes a field of Target, CurrentThread becomes a (*Target) method and (*Target).SwitchThread basically just sets a field Target. 2. The backends keep track of their own internal idea of what the current thread is, to use it to read memory, this is the thread they return from ContinueOnce as trapthread 3. The current thread in the backend and the current thread in Target only ever get synchronized in two places: when the backend creates a Target object the currentThread field of Target is initialized with the backend's current thread and when (*Target).Restart gets called (when a recording is rewound the currentThread used by Target might not exist anymore). 4. We remove the MemoryReadWriter interface embedded in Thread and instead add a Memory method to Process that returns a MemoryReadWriter. The backends will return something here that will read memory using the current thread saved by the backend. 5. The Thread.Blocked method is removed One possible problem with this change is processes that have threads with different memory maps. As far as I can determine this could happen on old versions of linux but this option was removed in linux 2.5. Fixes #2151
-
- 04 11月, 2020 1 次提交
-
-
由 Alessandro Arzilli 提交于
TestStepConcurrentDirect will occasionally fail (7% of the time on my setup) by either causing the target processs to execute an invalid instruction or (more infrequently) by switching to the wrong thread. Both of those are caused by receiving SIGTRAPs for threads hitting a breakpoint after it has been removed (the thread hits the breakpoint, we stop everything and remove the breakpoint and only after we receive the signal). Change native.(*nativeProcess).stop to handle SIGTRAPs that can't be attributed to a breakpoint, a hardcoded breakpoint in the program's text, or manual stops (and therefore are likely caused by phantom breakpoint hits). Co-authored-by: Na <a@kra>
-
- 03 11月, 2020 2 次提交
-
-
由 Alessandro Arzilli 提交于
Fixes #2219
-
由 Polina Sokolova 提交于
-
- 30 10月, 2020 1 次提交
-
-
由 polinasok 提交于
Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
-
- 22 10月, 2020 3 次提交
-
-
由 Alessandro Arzilli 提交于
-
由 Alessandro Arzilli 提交于
* service/rpccommon: log error for conns rejected by --only-same-user If no logger is enabled manually write to stderr instead. Fixes #2209 * logflags: fix style complaints from DeepSource
-
由 Alessandro Arzilli 提交于
Fixes #1847
-
- 20 10月, 2020 1 次提交
-
-
由 chainhelen 提交于
-
- 19 10月, 2020 1 次提交
-
-
由 chainhelen 提交于
1. Remove bug about unsupport systems, because we has pretty error msg. 2. Add usage for remote debugging. Relate: #1883, #1829, #861, #1332.
-
- 13 10月, 2020 3 次提交
-
-
由 Alessandro Arzilli 提交于
The test needs to set a breakpoint on main.CallFn after the prologue, on linux/386 this function does not have any instruction after the prologue on the function header line because it doesn't need to allocate space for local variables. Change the fixture so that this isn't a problem. This bug results on the test failing a small percentage of the time. Co-authored-by: Na <a@kra>
-
由 Alessandro Arzilli 提交于
It returns an unexported type and is only used in a single place.
-
由 Alessandro Arzilli 提交于
Due to a missing check TestCgoStacktrace2 didn't actually check anything. Enable it and then skip it on linux/386 and linux/arm64 where it's broken. Co-authored-by: Na <a@kra>
-