1. 18 5月, 2021 7 次提交
    • J
      service/dap: Fix build error due to unresolved merge conflict (#2493) · 54738875
      John-Michael Faircloth 提交于
      My local build of delve which apparently pulls in the master branch starting breaking. This is the culprit.
      
      Error:
      ```
      #9 75.27 # github.com/go-delve/delve/service/dap
      #9 75.27 /usr/src/github.com/go-delve/delve/service/dap/server.go:107:1: syntax error: unexpected <<, expecting field name or embedded type
      #9 75.27 /usr/src/github.com/go-delve/delve/service/dap/server.go:110:1: syntax error: unexpected ==, expecting field name or embedded type
      #9 75.27 /usr/src/github.com/go-delve/delve/service/dap/server.go:113:1: syntax error: unexpected >>, expecting field name or embedded type
      ```
      54738875
    • A
      pkg/proc/native/linux: fix target crashes induced by RequestManualStop (#2484) · d2bca7a3
      Alessandro Arzilli 提交于
      A RequestManualStop received while the target program is stopped can
      induce a crash when the target is restarted.
      This is caused by the phantom breakpoint detection that was introduced
      in PR #2179 / commit e69d536e.
      Instead of always interpreting an unexplained SIGTRAP as a phantom
      breakpoint memorize all possible unreported breakpoint hits and only
      act on it when the thread hasn't moved from one.
      
      Also clarifies the behavior of the halt command when it is received
      while the target is stopped or in the process of stopping.
      d2bca7a3
    • A
      proc/native/linux: better handling of process death due to signals (#2477) · bd2a4fe5
      Alessandro Arzilli 提交于
      Handle the signaled status for the thread leader like we handle the
      exited status, by returning ErrProcessExited and recording the killer
      signal  in it.
      Prior to this commit we would find out about the death of the thread
      later in the loop, the condition would still be reported as
      ErrProcessExited, but without recording the signal number anywhere.
      
      Also fixes a bug in TestAttachStopOnEntry where the test would
      inadvertently cause a SIGPIPE to be sent to the target process, making
      it terminate early.
      bd2a4fe5
    • S
      service/dap: implement exception info (#2444) · 30cdedae
      Suzy Mueller 提交于
      * service/dap: implement exception info
      
      * remove adding additional thread
      
      * Fix tests
      
      * add exceptionInfo tests
      
      * update comments
      
      * map paths to client paths
      
      * remove launch.json
      
      * remove change to ConvertEvalScope
      
      * correct name of supportsExceptionInfoRequest
      
      * Add TODO for deleting output event
      
      * Print Stack header to buffer
      
      * Try to move resolving exception info to onExceptionInfoRequest
      
      * save the error and return if it is the current thread
      
      * rename thread to g
      
      * findgoroutine returns goroutine
      
      * clean up findgoroutine
      
      * log errors
      
      * remove output event
      
      * fix grammar
      30cdedae
    • S
      service/dap: warn users of debugging optimized functions (#2475) · 1e9c5c3b
      Suzy Mueller 提交于
      * service/dap: warn users of debugging optimized functions
      
      * Add test for optimized scopes
      
      * service/dap: warn users of debugging optimized functions
      
      * rename functionscope
      
      * update warning message
      1e9c5c3b
    • P
      service/dap: support setting breakpoints while running (#2472) · 11cf6e68
      polinasok 提交于
      * service/dap: support setting breakpoints while running
      
      * Review comments, faster test
      
      * Fix comments
      
      * Address review comments
      
      * Do not continue automatically
      
      * Add TODO to resume exeuction
      
      * Handle async test messages in either order
      Co-authored-by: NPolina Sokolova <polinasok@users.noreply.github.com>
      11cf6e68
    • S
      32021981
  2. 17 5月, 2021 1 次提交
  3. 15 5月, 2021 1 次提交
  4. 13 5月, 2021 1 次提交
  5. 11 5月, 2021 2 次提交
  6. 07 5月, 2021 2 次提交
  7. 06 5月, 2021 2 次提交
    • H
      daptest/gen: autogenerate some assertion functions (#2441) · 4b4f7a58
      Hyang-Ah Hana Kim 提交于
      daptest has type assertion functions that panic
      if the read response/event message is not
      the expected type. This is not only against the
      recommended style guideline (Don't Panic, Useful
      Test Failures, ...), but also it prevents from
      quickly diagnosing test failures occurred in remote
      CIs.
      
      This PR changes the type assertion to the two
      return value type assertion, and t.Fatal with details
      if the type is not expected.
      service/dap/daptest/main.go is a program that auto
      generates those assertion functions in resp.go.
      
      Run `go generate` from the service/dap directory
      to update resp.go.
      4b4f7a58
    • S
      service/dap: validate the client configurations in initialize request (#2435) · 49555a9e
      Suzy Mueller 提交于
      The client can specify certain configurations in the initialize request.
      For example, pathFormat determines the pathFormat. We do not currently
      support configuring pathFormat, linesStartAt1, or columnsStartAt1, so
      we report an error if the client attempts to set these to an
      unsupported value.
      49555a9e
  8. 05 5月, 2021 7 次提交
  9. 04 5月, 2021 1 次提交
  10. 29 4月, 2021 2 次提交
  11. 27 4月, 2021 2 次提交
    • F
      examinememory: evaluate addr as expression (#2385) · 7bf5482b
      Felix Geisendörfer 提交于
      * examinememory: evaluate addr as expression
      
      This makes it easy to read memory locations at an offset of a known
      address, e.g.:
      
      x 0xc000046800 + 32
      
      * use feedback from @aarzilli
      
      - expression mode is now enabled via -x flag
      - support "-x var", "-x &var" in addition to "-x <addr expr>"
      - some refactoring
      
      * add test cases
      
      * deal with double spaces
      
      * update docs
      
      * add new failing test
      
      * fix docs
      
      * simplify implementation, update test & docs
      
      * Fix docs
      7bf5482b
    • S
      service/dap: add go build stderr to error response (#2448) · bbae9a9d
      Suzy Mueller 提交于
      * service/dap: add go build stderr to error response
      
      * service/dap: add go build stderr to error response
      
      * Skip message check for build errors
      
      * test for flag provided message
      bbae9a9d
  12. 23 4月, 2021 1 次提交
  13. 22 4月, 2021 3 次提交
  14. 20 4月, 2021 3 次提交
    • S
      service/dap: rename launch configuration 'wd' to 'cwd' (#2433) · af1796d1
      Suzy Mueller 提交于
      Rename the launch configuration for specifying the working directory.
      af1796d1
    • S
      service/dap: annotate shadowed variable names in variables request (#2428) · 2408ed87
      Suzy Mueller 提交于
      * service/dap: annotate shadowed variable names in variables request
      
      In order to distinguish variables that are shadowed, this change
      updates the names from 'name' to '(name)'. This is the same syntax
      used in the terminal package.
      
      * remove unnecessary comment
      
      * Add todo for evaluate name
      
      * Check the evaluateName result is the unshadowed var
      2408ed87
    • A
      service/rpccommon: fix shutdown related bugs (#2439) · e3d43887
      Alessandro Arzilli 提交于
      * service/rpcommon: resolve race between Detach and shutdown
      
      Detach will close DisconnectChan causing the server to initiate
      shutdown, there is a race between Detach writing its response to the
      client and the shutdown terminating the server process.
      If Detach loses the race the response to the Detach request is never
      sent to the client and the client will report an EOF error instead.
      
      This change delays the start of the shutdown process until after Detach
      has written its response.
      
      Fixes an occasional failure of TestContinue.
      
      * service/rpccommon: ignore listener error when shutting down
      
      Ignore the closed listener error when the server is being shut down in
      response to a SIGINT signal.
      
      Fixes #1633
      e3d43887
  15. 17 4月, 2021 1 次提交
  16. 16 4月, 2021 1 次提交
    • S
      service/dap: add substitutePath configuration (#2379) · 4eb54b01
      Suzy Mueller 提交于
      * service/dap: add substitutePath configuration
      
      Similar to substitute-path configuration in the dlv cli, substitutePath
      in dap allows users to specify path mappings that are applied to the
      source files in stacktrace and breakpoint requests.
      
      Updates #2203
      
      * service/dap: refactor the startup of the fixture for attach
      
      Add a helper function for starting up a process to attach to.
      
      * service/dap: update substitute path tests for windows
      
      * service/dap: remove lines that should have been removed in merge
      
      * respond to comments on pr
      
      * move logging to helper functions
      
      * make test comments more clear
      
      * Add comments about absolute paths
      
      * fix log messages
      
      * clarify test comments
      
      * remove comment about absolute paths
      4eb54b01
  17. 14 4月, 2021 1 次提交
  18. 13 4月, 2021 2 次提交