提交 c91ca831 编写于 作者: D Derek Parker

build: Always pass ldflags to builds on OSX

Previously, 'ldflags' were added to the compiler invocation based on the
version of Go the user was running. It seems to make more sense to
simply always pass along the flags on Darwin (due to the bug mentioned
in the comment above this line in the diff) as that is less brittle than
branching on the Go version, and yet will not break current users /
developers work flow.
上级 5ba04353
......@@ -9,7 +9,7 @@ GOVERSION=$(shell go version)
# will be malformed once we codesign it and
# unable to execute.
# See https://github.com/golang/go/issues/11887#issuecomment-126117692.
ifneq (,$(findstring 1.5, $(GOVERSION)))
ifeq "$(UNAME)" "Darwin"
FLAGS=-ldflags="-s"
endif
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册