PULL_REQUEST_TEMPLATE.md 1.6 KB
Newer Older
Y
yukon 已提交
1 2 3 4 5 6 7 8 9 10 11 12
## What is the purpose of the change

XXXXX

## Brief changelog

XX

## Verifying this change

XXXX

V
von gosling 已提交
13
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
Y
yukon 已提交
14

V
von gosling 已提交
15 16
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
Y
yukon 已提交
17
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
V
von gosling 已提交
18
- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
Y
yukon 已提交
19 20
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).