refactor test to make code climate happy

src/user/common.spec.ts

+import { SinonSandbox } from 'sinon'
+import { Puppet, RoomPayload } from 'wechaty-puppet'
+
+export const mockRoomPayload = (
+  sandbox: SinonSandbox,
+  puppet: Puppet,
+  topic: string,
+) => {
+  sandbox.stub(puppet, 'roomPayload').callsFake(async () => {
+    await new Promise(r => setImmediate(r))
+    return { topic } as RoomPayload
+  })
+}

src/user/message.spec.ts

@@ -28,11 +28,11 @@ import {
   ContactPayload,
   MessagePayload,
   MessageType,
-  RoomPayload,
 }                       from 'wechaty-puppet'
 import { PuppetMock }   from 'wechaty-puppet-mock'
 
 import { Wechaty }      from '../wechaty'
+import { mockRoomPayload } from './common.spec'
 
 test('recalled()', async t => {
 
@@ -72,12 +72,8 @@ test('recalled()', async t => {
       } as MessagePayload
     }
   })
-  sandbox.stub(puppet, 'roomPayload').callsFake(async () => {
-    await new Promise(r => setImmediate(r))
-    return {
-      topic: EXPECTED_ROOM_TOPIC,
-    } as RoomPayload
-  })
+
+  mockRoomPayload(sandbox, puppet, EXPECTED_ROOM_TOPIC)
 
   sandbox.stub(puppet, 'roomMemberList').callsFake(async () => {
     await new Promise(r => setImmediate(r))

src/user/room.spec.ts

@@ -26,11 +26,11 @@ import sinon from 'sinon'
 import {
   ContactPayload,
   RoomMemberPayload,
-  RoomPayload
 }                       from 'wechaty-puppet'
 import { PuppetMock }   from 'wechaty-puppet-mock'
 
 import { Wechaty }      from '../wechaty'
+import { mockRoomPayload } from './common.spec'
 
 test('findAll()', async t => {
   const EXPECTED_ROOM_ID      = 'test-id'
@@ -45,12 +45,7 @@ test('findAll()', async t => {
   await wechaty.start()
 
   sandbox.stub(puppet, 'roomSearch').resolves(EXPECTED_ROOM_ID_LIST)
-  sandbox.stub(puppet, 'roomPayload').callsFake(async () => {
-    await new Promise(r => setImmediate(r))
-    return {
-      topic: EXPECTED_ROOM_TOPIC,
-    } as RoomPayload
-  })
+  mockRoomPayload(sandbox, puppet, EXPECTED_ROOM_TOPIC)
 
   const roomList = await wechaty.Room.findAll()
   t.equal(roomList.length, 1, 'should find 1 room')
@@ -86,12 +81,7 @@ test('say()', async _ => {
       roomAlias: CONTACT_MAP[contactId],
     } as RoomMemberPayload
   })
-  sandbox.stub(puppet, 'roomPayload').callsFake(async () => {
-    await new Promise(r => setImmediate(r))
-    return {
-      topic: EXPECTED_ROOM_TOPIC,
-    } as RoomPayload
-  })
+  mockRoomPayload(sandbox, puppet, EXPECTED_ROOM_TOPIC)
   sandbox.stub(puppet, 'contactPayload').callsFake(async (contactId) => {
     await new Promise(r => setImmediate(r))
     return {