try to fix contact.findAll() return empty (#1358)

src/puppet/puppet.ts

@@ -388,11 +388,22 @@ export abstract class Puppet extends EventEmitter {
       return searchIdList
     }
 
-    const searchContactPayloadList: ContactPayload[] = await Promise.all(
-      searchIdList.map(
-        id => this.contactPayload(id),
-      ),
-    )
+    const searchContactPayloadList: ContactPayload[] = (
+      await Promise.all(
+        searchIdList.map(
+          async id => {
+            try {
+              const payload = await this.contactPayload(id)
+              return payload
+            } catch (e) {
+              // compatible with {} payload, which means that
+              // contact id is not friend with the current user
+              return {} as any
+            }
+          },
+        ),
+      )
+    ).filter(payload => Object.keys(payload).length > 0)
 
     const filterFuncion: ContactPayloadFilterFunction = this.contactQueryFilterFactory(query)
 

src/user/contact.ts

@@ -186,11 +186,11 @@ export class Contact extends Accessory implements Sayable {
    */
   public static async findAll<T extends typeof Contact>(
     this  : T,
-    query : string | ContactQueryFilter = { name: /.*/ },
+    query? : string | ContactQueryFilter,
   ): Promise<T['prototype'][]> {
     log.verbose('Cotnact', 'findAll(%s)', JSON.stringify(query))
 
-    if (Object.keys(query).length !== 1) {
+    if (query && Object.keys(query).length !== 1) {
       throw new Error('query only support one key. multi key support is not availble now.')
     }